You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-08-14] [$250] Pay someone - Missing paid system message for paying someone #45203
Version Number: 9.0.6-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team
Action Performed:
Go to staging.new.expensify.com
Go to DM
Click + > Pay
Enter amount and pay the user
Click on the expense preview
Expected Result:
There will be a paid system message for paying someone (according to PR 43742)
Actual Result:
There is no paid system message for paying someone
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
@MitchExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.17-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
[@parasharrajat] Determine if we should create a regression test for this bug.
[@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not needed
[@parasharrajat] Determine if we should create a regression test for this bug. Yes
[@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Regression Test Steps
Go to DM
Click + button on the left side of composer -> click Pay
Complete the step
Click on the pay/expense message preview
Verify there is a paid system message for paying someone
Activity
melvin-bot commentedon Jul 10, 2024
Triggered auto assignment to @MitchExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.lanitochka17 commentedon Jul 10, 2024
@MitchExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
lanitochka17 commentedon Jul 10, 2024
We think that this bug might be related to #wave-collect - Release 1
tsa321 commentedon Jul 11, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Missing paid system message for paying someone
What is the root cause of that problem?
Here:
App/src/libs/ReportActionsUtils.ts
Lines 388 to 390 in d739580
the sent money/paid IOU report actions are being filtered out and therefore won't appear in
reportActionsToDisplayas shownApp/src/pages/home/report/ReportActionsView.tsx
Lines 218 to 219 in d739580
Consequently, they won't be displayed.
What changes do you think we should make in order to solve the problem?
If the expected result is to display the message, one solution is to remove this filter, allowing the messages to appear as intended.
melvin-bot commentedon Jul 14, 2024
Triggered auto assignment to @MitchExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.51 remaining items
melvin-bot commentedon Aug 7, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.17-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-08-14. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Aug 7, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
parasharrajat commentedon Aug 8, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
Regression Test Steps
Do you agree 👍 or 👎 ?
joekaufmanexpensify commentedon Aug 12, 2024
Looks good to me! I will complete checklist.
joekaufmanexpensify commentedon Aug 13, 2024
Checklist is complete! All set to issue payment soon. We need to pay:
joekaufmanexpensify commentedon Aug 14, 2024
All set to issue payment.
joekaufmanexpensify commentedon Aug 14, 2024
@tsa321 $250 sent and contract ended!
joekaufmanexpensify commentedon Aug 14, 2024
Upwork job closed.
joekaufmanexpensify commentedon Aug 14, 2024
Closing as all that's left is for @parasharrajat to request payment via NewDot. Thanks everyone!
parasharrajat commentedon Aug 30, 2024
Payment requested as per #45203 (comment)
JmillsExpensify commentedon Sep 2, 2024
$250 approved for @parasharrajat