Skip to content

[HOLD for payment 2024-08-14] [$250] Pay someone - Missing paid system message for paying someone #45203

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.6-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to DM
  3. Click + > Pay
  4. Enter amount and pay the user
  5. Click on the expense preview

Expected Result:

There will be a paid system message for paying someone (according to PR 43742)

Actual Result:

There is no paid system message for paying someone

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6538116_1720629865877.20240711_004214.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~010ff4cba2e4566fca
  • Upwork Job ID: 1813273027515516872
  • Last Price Increase: 2024-07-16
  • Automatic offers:
    • tsa321 | Contributor | 103348532
Issue OwnerCurrent Issue Owner: @joekaufmanexpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 10, 2024
  2. melvin-bot commented on Jul 10, 2024

    @melvin-bot

    Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. lanitochka17 commented on Jul 10, 2024

    @lanitochka17
    Author

    @MitchExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  4. lanitochka17 commented on Jul 10, 2024

    @lanitochka17
    Author

    We think that this bug might be related to #wave-collect - Release 1

  5. tsa321 commented on Jul 11, 2024

    @tsa321
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Missing paid system message for paying someone

    What is the root cause of that problem?

    Here:

    function getFilteredForOneTransactionView(reportActions: ReportAction[]): ReportAction[] {
    return reportActions.filter((action) => !isSentMoneyReportAction(action));
    }

    the sent money/paid IOU report actions are being filtered out and therefore won't appear in reportActionsToDisplay as shown

    return moneyRequestActions.length === 1 ? ReportActionsUtils.getFilteredForOneTransactionView([...actions, createdAction]) : [...actions, createdAction];
    }, [allReportActions, report, transactionThreadReport]);

    Consequently, they won't be displayed.

    What changes do you think we should make in order to solve the problem?

    If the expected result is to display the message, one solution is to remove this filter, allowing the messages to appear as intended.

  6. removed their assignment
    on Jul 14, 2024
  7. added
    BugSomething is broken. Auto assigns a BugZero manager.
    and removed
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 14, 2024
  8. melvin-bot commented on Jul 14, 2024

    @melvin-bot

    Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  9. 51 remaining items

  10. melvin-bot commented on Aug 7, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.17-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-08-14. 🎊

    For reference, here are some details about the assignees on this issue:

  11. melvin-bot commented on Aug 7, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  12. parasharrajat commented on Aug 8, 2024

    @parasharrajat
    Member

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    Regression Test Steps

    1. Go to DM
    2. Click + button on the left side of composer -> click Pay
    3. Complete the step
    4. Click on the pay/expense message preview
    5. Verify there is a paid system message for paying someone

    Do you agree 👍 or 👎 ?

  13. joekaufmanexpensify commented on Aug 12, 2024

    @joekaufmanexpensify
    Contributor

    Looks good to me! I will complete checklist.

  14. joekaufmanexpensify commented on Aug 13, 2024

    @joekaufmanexpensify
    Contributor

    Checklist is complete! All set to issue payment soon. We need to pay:

  15. joekaufmanexpensify commented on Aug 14, 2024

    @joekaufmanexpensify
    Contributor

    All set to issue payment.

  16. joekaufmanexpensify commented on Aug 14, 2024

    @joekaufmanexpensify
    Contributor

    @tsa321 $250 sent and contract ended!

  17. joekaufmanexpensify commented on Aug 14, 2024

    @joekaufmanexpensify
    Contributor

    Upwork job closed.

  18. joekaufmanexpensify commented on Aug 14, 2024

    @joekaufmanexpensify
    Contributor

    Closing as all that's left is for @parasharrajat to request payment via NewDot. Thanks everyone!

  19. parasharrajat commented on Aug 30, 2024

    @parasharrajat
    Member

    Payment requested as per #45203 (comment)

  20. JmillsExpensify commented on Sep 2, 2024

    @JmillsExpensify
    Contributor

    $250 approved for @parasharrajat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions