Skip to content

Unable to login with non-existing account that owes money #45252

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.6-0
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:
User B has no account yet

Steps:

  1. User A with gmail account go to FAB> Submit expense> Add User B email address> Complete the submit flow
  2. Wait for a minute
  3. Repeat step 1 to submit a second IOU to user B
  4. As User B go to staging.new.expensify.com> Type email address and click Continue

Expected Result:

User B should be able to login

Actual Result:

Unable to login with non-existing account that owes money. "Cannot get account details, please try again or contact concierge@expensify.com"
error message is displayed on login page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6538444_1720651977684.Recording__3476.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~017518e8ff7a1d7f72
  • Upwork Job ID: 1811408479840104416
  • Last Price Increase: 2024-07-18
Issue OwnerCurrent Issue Owner: @mkhutornyi

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 11, 2024
  2. melvin-bot commented on Jul 11, 2024

    @melvin-bot

    Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. joekaufmanexpensify commented on Jul 11, 2024

    @joekaufmanexpensify
    Contributor

    I can reproduce this, but only specifically when submitting two IOUs to someone hasn't created an account yet. If I only submit one, I have no problem logging into the new account.

    image
  4. joekaufmanexpensify commented on Jul 11, 2024

    @joekaufmanexpensify
    Contributor

    That said, this is a pretty bad bug for a core flow, so makes sense to me to fix now.

  5. changed the title [-]Login - Unable to login with non-existing account that owes money[/-] [+][$250] Login - Unable to login with non-existing account that owes money[/+] on Jul 11, 2024
  6. melvin-bot commented on Jul 11, 2024

    @melvin-bot
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jul 11, 2024
  8. melvin-bot commented on Jul 11, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @mkhutornyi (External)

  9. mkhutornyi commented on Jul 11, 2024

    @mkhutornyi
    Contributor

    @kabeer95 Please read through contributing guideline and follow proposal template. Thanks

  10. kabeer95 commented on Jul 11, 2024

    @kabeer95

    Problem Statement: The problem we are trying to solve is that when a user attempts to log in with a non-existing account that owes money, the system does not handle the situation correctly, leading to a poor user experience.

    Root Cause: The root cause of this problem is that the current login system does not have a mechanism to detect and handle cases where a user attempts to log in with a non-existing account that owes money. This lack of error handling and recovery flow leads to a poor user experience and potential frustration.

    Proposed Solution: To solve this problem, I propose the following changes:

    Implement robust error handling to detect when a user attempts to log in with a non-existing account that owes money.
    Display clear and concise error messaging to the user, indicating that the account does not exist or that there is an outstanding balance.
    Redirect the user to a recovery flow, where they can recover their account or resolve the outstanding balance.
    Alternative Solutions Explored:

    Soft Delete: Instead of completely removing the account, we could implement a soft delete mechanism that marks the account as inactive but still retains the account information. This would allow users to recover their account and resolve the outstanding balance.
    Account Lookup: We could implement an account lookup feature that allows users to search for their account and recover it if it exists. This would provide an additional recovery path for users who have forgotten their login credentials.
    Grace Period: We could introduce a grace period for accounts with outstanding balances, allowing users to log in and resolve the balance within a certain timeframe before the account is marked as non-existent.
    These alternative solutions were explored, but the proposed solution was deemed the most effective and efficient way to solve the problem.

  11. joekaufmanexpensify commented on Jul 12, 2024

    @joekaufmanexpensify
    Contributor

    Still pending proposals

  12. 22 remaining items

  13. iwiznia commented on Jul 22, 2024

    @iwiznia
    Contributor
  14. iwiznia commented on Jul 22, 2024

    @iwiznia
    Contributor

    BTW I think it's totally fine to send clientUpdateID in all requests, even if we only need it for writes.

  15. Julesssss commented on Jul 22, 2024

    @Julesssss
    Contributor

    PR merged, thanks

  16. removed
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jul 22, 2024
  17. changed the title [-][$250] Login - Unable to login with non-existing account that owes money[/-] [+]Unable to login with non-existing account that owes money[/+] on Jul 22, 2024
  18. joekaufmanexpensify commented on Jul 22, 2024

    @joekaufmanexpensify
    Contributor

    Sweet, thank you both!

  19. melvin-bot commented on Jul 29, 2024

    @melvin-bot

    @iwiznia, @Julesssss Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  20. Julesssss commented on Jul 30, 2024

    @Julesssss
    Contributor

    Fix is on prod

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Help WantedApply this label when an issue is open to proposals by contributorsReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions