You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-08-02] [$250] Name of the Expensify user is not centered in the profile detail view #45346
What changes do you think we should make in order to solve the problem?
We should include the styles.alignItemsCenter for the nameSectionGroupWorkspace with the condition that the account id is the main participant to be displayed and is CONST.ACCOUNT_ID.NOTIFICATIONS or chat is a system chat, isSystemChat.
What alternative solutions did you explore? (Optional)
Create a different section like nameSectionGroupWorkspace and nameSectionTitleField to align the titles to the center for chats with the CONST.ACCOUNT_ID.NOTIFICATIONS account id, unlike other reports where it is aligned to the left.
What changes do you think we should make in order to solve the problem?
This bug happens for all reports that are not DM and the report name can not be edited.
If the report name cannot be edited we should add titleContainerStyle prop with style styles.alignItemsCenter to MenuItemWithTopDescription. This change will also work when the report has the description.
changed the title [-]Name of the Expensify user is not centered in the profile detail view[/-][+][$250] Name of the Expensify user is not centered in the profile detail view[/+]on Jul 15, 2024
changed the title [-][$250] Name of the Expensify user is not centered in the profile detail view[/-][+][HOLD for payment 2024-08-02] [$250] Name of the Expensify user is not centered in the profile detail view[/+]on Jul 26, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.12-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
[@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@fedirjh] Determine if we should create a regression test for this bug.
[@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Link to discussion: N/A This bug should have been caught with the current checklist.
Determine if we should create a regression test for this bug: Yes
Regression Test Proposal
1. Open the Expensify chat report or any other, where the report title cannot be edited.
2. Click on the header of the report to see the details.
3. Observe the report title and ensure it is centered on the page.
$250 approved for @fedirjh. Going to close this once since regression issue is added and all payments approved. @fedirjh Please submit an expense in New Expensify when you get a chance!
Activity
melvin-bot commentedon Jul 12, 2024
Triggered auto assignment to @strepanier03 (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.Krishna2323 commentedon Jul 12, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Name of the Expensify user is not centered in the profile detail view
What is the root cause of that problem?
The text is not centered when
isSystemChatis true.App/src/pages/ReportDetailsPage.tsx
Lines 573 to 592 in ec19663
What changes do you think we should make in order to solve the problem?
We should check for
isSystemChatand addmarginHorizontal: autototitleStyleprop if it is true.What alternative solutions did you explore? (Optional)
We can add
flex:1andtextAlign: centerifisSystemChatis true. We should also check for other similar cases.Tony-MK commentedon Jul 12, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
When the header of the report is clicked the app navigates to the report details page through the
navigateToDetailsPagefunction.Instead of the profile page since the
CONST.ACCOUNT_ID.NOTIFICATIONSaccount id is part of theCONST.RESTRICTED_ACCOUNT_IDSin the profile page.App/src/pages/ProfilePage.tsx
Line 148 in ec19663
The report detail page does not align the title to the center while the profile page does.
App/src/pages/ReportDetailsPage.tsx
Lines 573 to 580 in ec19663
What changes do you think we should make in order to solve the problem?
We should include the
styles.alignItemsCenterfor thenameSectionGroupWorkspacewith the condition that the account id is the main participant to be displayed and isCONST.ACCOUNT_ID.NOTIFICATIONSor chat is a system chat,isSystemChat.App/src/pages/ReportDetailsPage.tsx
Line 580 in ec19663
We could change the line of code above with the one below for the
isSystemChatsolution option.What alternative solutions did you explore? (Optional)
Create a different section like
nameSectionGroupWorkspaceandnameSectionTitleFieldto align the titles to the center for chats with theCONST.ACCOUNT_ID.NOTIFICATIONSaccount id, unlike other reports where it is aligned to the left.nkdengineer commentedon Jul 15, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
In
ReportDetailPage, the report name is not alignedApp/src/pages/ReportDetailsPage.tsx
Lines 585 to 591 in 77d95c5
What changes do you think we should make in order to solve the problem?
This bug happens for all reports that are not DM and the report name can not be edited.
If the report name cannot be edited we should add
titleContainerStyleprop with stylestyles.alignItemsCentertoMenuItemWithTopDescription. This change will also work when the report has the description.App/src/pages/ReportDetailsPage.tsx
Lines 585 to 591 in 77d95c5
And add style
styles.mw100here to avoid the title overflowing.App/src/components/MenuItem.tsx
Line 656 in 39463bd
What alternative solutions did you explore? (Optional)
NA
Screen.Recording.2024-07-15.at.14.36.14.mov
Result
melvin-bot commentedon Jul 15, 2024
@strepanier03 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
melvin-bot commentedon Jul 15, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01d58bde936bd4c0a6
[-]Name of the Expensify user is not centered in the profile detail view[/-][+][$250] Name of the Expensify user is not centered in the profile detail view[/+]melvin-bot commentedon Jul 15, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (
External)22 remaining items
[-][$250] Name of the Expensify user is not centered in the profile detail view[/-][+][HOLD for payment 2024-08-02] [$250] Name of the Expensify user is not centered in the profile detail view[/+]melvin-bot commentedon Jul 26, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jul 26, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.12-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-08-02. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jul 26, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
fedirjh commentedon Aug 2, 2024
BugZero Checklist:
Regression Test Proposal
github-actions commentedon Aug 2, 2024
true
strepanier03 commentedon Aug 2, 2024
Payment Summary
@JmillsExpensify payment request incoming.
JmillsExpensify commentedon Aug 2, 2024
$250 approved for @fedirjh. Going to close this once since regression issue is added and all payments approved. @fedirjh Please submit an expense in New Expensify when you get a chance!