Skip to content

[HOLD for payment 2024-08-02] [$250] Name of the Expensify user is not centered in the profile detail view #45346

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.6-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1720777243552389

Action Performed:

  1. Open Expensify chat report
  2. Click on the header to see the details

Expected Result:

"Expensify" name should be centered like "Chronos"

Actual Result:

The name for the Expensify user is not centered in the details view

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

CleanShot 2024-07-12 at 11 40 50@2x
CleanShot 2024-07-12 at 11 40 07@2x
Snip - (56) New Expensify - Google Chrome

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01d58bde936bd4c0a6
  • Upwork Job ID: 1812986703312855628
  • Last Price Increase: 2024-07-15
  • Automatic offers:
    • nkdengineer | Contributor | 103218448
Issue OwnerCurrent Issue Owner: @strepanier03

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 12, 2024
  2. melvin-bot commented on Jul 12, 2024

    @melvin-bot

    Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. Krishna2323 commented on Jul 12, 2024

    @Krishna2323
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Name of the Expensify user is not centered in the profile detail view

    What is the root cause of that problem?

    The text is not centered when isSystemChat is true.

    const nameSectionGroupWorkspace = (
    <OfflineWithFeedback
    pendingAction={report?.pendingFields?.reportName}
    errors={report?.errorFields?.reportName}
    errorRowStyles={[styles.ph5]}
    onClose={() => Report.clearPolicyRoomNameErrors(report?.reportID)}
    >
    <View style={[styles.flex1, !shouldDisableRename && styles.mt3]}>
    <MenuItemWithTopDescription
    shouldShowRightIcon={!shouldDisableRename}
    interactive={!shouldDisableRename}
    title={reportName}
    titleStyle={styles.newKansasLarge}
    shouldCheckActionAllowedOnPress={false}
    description={!shouldDisableRename ? roomDescription : ''}
    furtherDetails={chatRoomSubtitle && !isGroupChat ? additionalRoomDetails : ''}
    onPress={() => Navigation.navigate(ROUTES.REPORT_SETTINGS_NAME.getRoute(report.reportID))}
    />
    </View>
    </OfflineWithFeedback>

    What changes do you think we should make in order to solve the problem?

    We should check for isSystemChat and add marginHorizontal: auto to titleStyle prop if it is true.

    What alternative solutions did you explore? (Optional)

    We can add flex:1 and textAlign: center if isSystemChat is true. We should also check for other similar cases.

  4. Tony-MK commented on Jul 12, 2024

    @Tony-MK
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    What is the root cause of that problem?

    When the header of the report is clicked the app navigates to the report details page through the navigateToDetailsPage function.

    Instead of the profile page since the CONST.ACCOUNT_ID.NOTIFICATIONS account id is part of the CONST.RESTRICTED_ACCOUNT_IDS in the profile page.

    const shouldShowBlockingView = (!isValidAccountID && !isLoading) || CONST.RESTRICTED_ACCOUNT_IDS.includes(accountID);

    The report detail page does not align the title to the center while the profile page does.

    const nameSectionGroupWorkspace = (
    <OfflineWithFeedback
    pendingAction={report?.pendingFields?.reportName}
    errors={report?.errorFields?.reportName}
    errorRowStyles={[styles.ph5]}
    onClose={() => Report.clearPolicyRoomNameErrors(report?.reportID)}
    >
    <View style={[styles.flex1, !shouldDisableRename && styles.mt3]}>

    What changes do you think we should make in order to solve the problem?

    We should include the styles.alignItemsCenter for the nameSectionGroupWorkspace with the condition that the account id is the main participant to be displayed and is CONST.ACCOUNT_ID.NOTIFICATIONS or chat is a system chat, isSystemChat.

    <View style={[styles.flex1, !shouldDisableRename && styles.mt3]}>

    We could change the line of code above with the one below for the isSystemChat solution option.

     <View style={[styles.flex1, !shouldDisableRename && styles.mt3, isSystemChat && styles.alignItemsCenter]}>
    

    What alternative solutions did you explore? (Optional)

    Create a different section like nameSectionGroupWorkspace and nameSectionTitleField to align the titles to the center for chats with the CONST.ACCOUNT_ID.NOTIFICATIONS account id, unlike other reports where it is aligned to the left.

    Centered Result

  5. nkdengineer commented on Jul 15, 2024

    @nkdengineer
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    What is the root cause of that problem?

    In ReportDetailPage, the report name is not aligned

    <MenuItemWithTopDescription
    shouldShowRightIcon={!shouldDisableRename}
    interactive={!shouldDisableRename}
    title={reportName}
    titleStyle={styles.newKansasLarge}
    shouldCheckActionAllowedOnPress={false}
    description={!shouldDisableRename ? roomDescription : ''}

    What changes do you think we should make in order to solve the problem?

    This bug happens for all reports that are not DM and the report name can not be edited.
    If the report name cannot be edited we should add titleContainerStyle prop with style styles.alignItemsCenter to MenuItemWithTopDescription. This change will also work when the report has the description.

    titleContainerStyle={shouldDisableRename && styles.alignItemsCenter}
    

    <MenuItemWithTopDescription
    shouldShowRightIcon={!shouldDisableRename}
    interactive={!shouldDisableRename}
    title={reportName}
    titleStyle={styles.newKansasLarge}
    shouldCheckActionAllowedOnPress={false}
    description={!shouldDisableRename ? roomDescription : ''}

    And add style styles.mw100 here to avoid the title overflowing.

    <View style={[styles.flexRow, styles.alignItemsCenter]}>

    What alternative solutions did you explore? (Optional)

    NA

    Screen.Recording.2024-07-15.at.14.36.14.mov

    Result

  6. melvin-bot commented on Jul 15, 2024

    @melvin-bot

    @strepanier03 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  7. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jul 15, 2024
  8. melvin-bot commented on Jul 15, 2024

    @melvin-bot
  9. changed the title [-]Name of the Expensify user is not centered in the profile detail view[/-] [+][$250] Name of the Expensify user is not centered in the profile detail view[/+] on Jul 15, 2024
  10. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jul 15, 2024
  11. melvin-bot commented on Jul 15, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

  12. 22 remaining items

  13. changed the title [-][$250] Name of the Expensify user is not centered in the profile detail view[/-] [+][HOLD for payment 2024-08-02] [$250] Name of the Expensify user is not centered in the profile detail view[/+] on Jul 26, 2024
  14. melvin-bot commented on Jul 26, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot commented on Jul 26, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.12-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-08-02. 🎊

    For reference, here are some details about the assignees on this issue:

  16. melvin-bot commented on Jul 26, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
    • [@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@fedirjh] Determine if we should create a regression test for this bug.
    • [@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  17. fedirjh commented on Aug 2, 2024

    @fedirjh
    Contributor

    BugZero Checklist:

    Regression Test Proposal

    1. Open the Expensify chat report or any other, where the report title cannot be edited.
    2. Click on the header of the report to see the details.
    3. Observe the report title and ensure it is centered on the page.
    
    • Do we agree 👍 or 👎
  18. github-actions commented on Aug 2, 2024

    @github-actions
    Contributor

    true

  19. strepanier03 commented on Aug 2, 2024

    @strepanier03
    Contributor

    Payment Summary

    @JmillsExpensify payment request incoming.

  20. JmillsExpensify commented on Aug 2, 2024

    @JmillsExpensify
    Contributor

    $250 approved for @fedirjh. Going to close this once since regression issue is added and all payments approved. @fedirjh Please submit an expense in New Expensify when you get a chance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions