Skip to content

[$500] [Medium] TRIPPREVIEW is not showing the preview/info #45348

Closed

Description

@kevinksullivan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation: https://expensify.slack.com/archives/C05S5EV2JTX/p1720621730730619

Action Performed:

  1. Book a trip in spotnana
  2. Navigate to the workspace chat

Expected Result:

Preview should load/show info

Actual Result:

Preview is not reliably loading/showing information

https://files.slack.com/files-pri/T047TPA624F-F07BMUQ00P8/screenshot_2024-07-10_at_7.58.02___pm.png

Screenshots/Videos

image

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~014f530c69599f191f
  • Upwork Job ID: 1812949990970484758
  • Last Price Increase: 2024-09-30
Issue OwnerCurrent Issue Owner: @johncschuster

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 12, 2024
  2. moved this to Critical - GBTA July 22 in [#whatsnext] #Travelon Jul 12, 2024
  3. melvin-bot commented on Jul 12, 2024

    @melvin-bot

    Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. melvin-bot commented on Jul 15, 2024

    @melvin-bot

    @johncschuster Whoops! This issue is 2 days overdue. Let's get this updated quick!

  5. johncschuster commented on Jul 15, 2024

    @johncschuster
    Contributor

    Given the urgency, I've opted to assign this to the engineers curating the #travel-gbta-july-22-2024 project. Please reassign as needed!

  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jul 15, 2024
  7. 161 remaining items

  8. cristipaval commented on Dec 12, 2024

    @cristipaval
    Contributor

    Fix PR hit production. Closing

  9. moved this from Medium - NewDot MVP - Feb '25 to Done in [#whatsnext] #Travelon Dec 12, 2024
  10. shubham1206agra commented on Dec 12, 2024

    @shubham1206agra
    Contributor

    Hello @cristipaval

    I am sorry for asking this
    But am I eligible for compensation here?
    Since I originally reported the issue https://expensify.slack.com/archives/C05S5EV2JTX/p1720621730730619
    And I tried to drive this issue here https://expensify.slack.com/archives/C05S5EV2JTX/p1725546707583219

  11. moved this from Done to Critical - Feb '25 Earnings in [#whatsnext] #Travelon Dec 12, 2024
  12. cristipaval commented on Dec 12, 2024

    @cristipaval
    Contributor

    @johncschuster could you please check the above comment? 🙏

  13. johncschuster commented on Dec 13, 2024

    @johncschuster
    Contributor

    @shubham1206agra can you help me understand what the compensation would be for? Would it be for reporting the issue, or did you contribute to the PR that led to the resolution?

    If the latter, can you point out where you contributed? That'll make it way easier to review given the length of this issue. Thank you!

  14. shubham1206agra commented on Dec 14, 2024

    @shubham1206agra
    Contributor

    @shubham1206agra can you help me understand what the compensation would be for? Would it be for reporting the issue, or did you contribute to the PR that led to the resolution?

    If the latter, can you point out where you contributed? That'll make it way easier to review given the length of this issue. Thank you!

    @johncschuster Did both, but there are a lot of places where we discussed this in Slack (some are in private DMs). One thread I found is in #45348 (comment)

  15. johncschuster commented on Dec 17, 2024

    @johncschuster
    Contributor

    Thanks for your comment! I can see where you contributed via Slack (that thread was helpful!). Did you contribute to a PR, either as a contributor or as a reviewer?

  16. shubham1206agra commented on Dec 17, 2024

    @shubham1206agra
    Contributor

    Thanks for your comment! I can see where you contributed via Slack (that thread was helpful!). Did you contribute to a PR, either as a contributor or as a reviewer?

    Not really. Since the fix was made internally.

  17. moved this from Critical - Feb '25 Earnings to Medium - NewDot MVP - Feb '25 in [#whatsnext] #Travelon Dec 17, 2024
  18. cristipaval commented on Dec 17, 2024

    @cristipaval
    Contributor

    I also participated in that Slack thread, where we chatted about the steps to reproduce the issue. I think we usually do a partial pay when the C+ reviews proposals before we decide to take the issue internally. We also do this when we accept a proposal, the contributor starts working on it, and then we decide to close the issue or fix it internally. Other than the bug report in Slack, I can't tell concrete contributions from @shubham1206agra to the solution, @johncschuster, so I'm not sure if the #bug-zero team pays anything in these situations.

  19. moved this from Medium - NewDot MVP - Feb '25 to Done in [#whatsnext] #Travelon Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2InternalRequires API changes or must be handled by Expensify staffReviewingHas a PR in review

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions