You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$500] [Medium] TRIPPREVIEW is not showing the preview/info #45348
@shubham1206agra can you help me understand what the compensation would be for? Would it be for reporting the issue, or did you contribute to the PR that led to the resolution?
If the latter, can you point out where you contributed? That'll make it way easier to review given the length of this issue. Thank you!
@shubham1206agra can you help me understand what the compensation would be for? Would it be for reporting the issue, or did you contribute to the PR that led to the resolution?
If the latter, can you point out where you contributed? That'll make it way easier to review given the length of this issue. Thank you!
@johncschuster Did both, but there are a lot of places where we discussed this in Slack (some are in private DMs). One thread I found is in #45348 (comment)
Thanks for your comment! I can see where you contributed via Slack (that thread was helpful!). Did you contribute to a PR, either as a contributor or as a reviewer?
Thanks for your comment! I can see where you contributed via Slack (that thread was helpful!). Did you contribute to a PR, either as a contributor or as a reviewer?
I also participated in that Slack thread, where we chatted about the steps to reproduce the issue. I think we usually do a partial pay when the C+ reviews proposals before we decide to take the issue internally. We also do this when we accept a proposal, the contributor starts working on it, and then we decide to close the issue or fix it internally. Other than the bug report in Slack, I can't tell concrete contributions from @shubham1206agra to the solution, @johncschuster, so I'm not sure if the #bug-zero team pays anything in these situations.
Activity
melvin-bot commentedon Jul 12, 2024
Triggered auto assignment to @johncschuster (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jul 15, 2024
@johncschuster Whoops! This issue is 2 days overdue. Let's get this updated quick!
johncschuster commentedon Jul 15, 2024
Given the urgency, I've opted to assign this to the engineers curating the
#travel-gbta-july-22-2024project. Please reassign as needed!161 remaining items
cristipaval commentedon Dec 12, 2024
Fix PR hit production. Closing
shubham1206agra commentedon Dec 12, 2024
Hello @cristipaval
I am sorry for asking this
But am I eligible for compensation here?
Since I originally reported the issue https://expensify.slack.com/archives/C05S5EV2JTX/p1720621730730619
And I tried to drive this issue here https://expensify.slack.com/archives/C05S5EV2JTX/p1725546707583219
cristipaval commentedon Dec 12, 2024
@johncschuster could you please check the above comment? 🙏
johncschuster commentedon Dec 13, 2024
@shubham1206agra can you help me understand what the compensation would be for? Would it be for reporting the issue, or did you contribute to the PR that led to the resolution?
If the latter, can you point out where you contributed? That'll make it way easier to review given the length of this issue. Thank you!
shubham1206agra commentedon Dec 14, 2024
@johncschuster Did both, but there are a lot of places where we discussed this in Slack (some are in private DMs). One thread I found is in #45348 (comment)
johncschuster commentedon Dec 17, 2024
Thanks for your comment! I can see where you contributed via Slack (that thread was helpful!). Did you contribute to a PR, either as a contributor or as a reviewer?
shubham1206agra commentedon Dec 17, 2024
Not really. Since the fix was made internally.
cristipaval commentedon Dec 17, 2024
I also participated in that Slack thread, where we chatted about the steps to reproduce the issue. I think we usually do a partial pay when the C+ reviews proposals before we decide to take the issue internally. We also do this when we accept a proposal, the contributor starts working on it, and then we decide to close the issue or fix it internally. Other than the bug report in Slack, I can't tell concrete contributions from @shubham1206agra to the solution, @johncschuster, so I'm not sure if the #bug-zero team pays anything in these situations.