You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-07-30][$250] Deep-link - Infinite skeleton loader appears when navigating to non-existing profile #45486
Version Number: 9.0.7-4 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail:https://expensify.testrail.io/index.php?/tests/view/4723441 Email or phone of affected tester (no customers):gibethlehem.@gmail.com Issue reported by: Applause - Internal Team
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
I'm looking at this now. It seems very similar to a bug I initially fixed here. Even though that PR wasn't perfect, the RCA remains valid.
Basically, we're trying to use navigation.setParams before the navigation stack is ready. react-navigation assumes that you're calling that in response to a user action, so it isn't working in our case. Instead, we need to pass the correct initial report ID in the initialParams for the ReportScreen from within AuthScreens.
This will be a bit tricky to get right since we'll only want to calculate the initial report once, during the first render, and only if there isn't already a reportID in the URL.
changed the title [-][$250] Deep-link - Infinite skeleton loader appears when navigating to non-existing profile[/-][+][HOLD for payment 2024-07-30][$250] Deep-link - Infinite skeleton loader appears when navigating to non-existing profile[/+]on Jul 23, 2024
Activity
melvin-bot commentedon Jul 16, 2024
Triggered auto assignment to @marcochavezf (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Jul 16, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
marcochavezf commentedon Jul 16, 2024
Git bisect led me to this PR which possibly introduced the bug
marcochavezf commentedon Jul 16, 2024
DM'ed @roryabraham for a possible solution since trying to revert the offending PR brings complex conflicts. I will be back in a couple of hours
cead22 commentedon Jul 16, 2024
FWIW this doesn't seem worth blocking the app deploy to me
roryabraham commentedon Jul 16, 2024
I'm looking at this now. It seems very similar to a bug I initially fixed here. Even though that PR wasn't perfect, the RCA remains valid.
Basically, we're trying to use
navigation.setParamsbefore the navigation stack is ready. react-navigation assumes that you're calling that in response to a user action, so it isn't working in our case. Instead, we need to pass the correct initial report ID in theinitialParamsfor theReportScreenfrom withinAuthScreens.This will be a bit tricky to get right since we'll only want to calculate the initial report once, during the first render, and only if there isn't already a reportID in the URL.
thienlnam commentedon Jul 16, 2024
Removing blocker for this issue
25 remaining items
syedmustafan commentedon Jul 17, 2024
Contributor details
Your Expensify account email: mustafanadeem627@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01153cf0ecb63d1e75
It is working fine upon redirecting to https://staging.new.expensify.com/a/hello
Screen.Recording.2024-07-17.at.7.53.42.PM.mov
melvin-bot commentedon Jul 17, 2024
roryabraham commentedon Jul 17, 2024
Thanks @syedmustafan, I've already got a PR in review to fix this issue
roryabraham commentedon Jul 18, 2024
PR merged
greg-schroeder commentedon Jul 22, 2024
On staging, awaiting deploy to prod
roryabraham commentedon Jul 23, 2024
Deployed to prod 8hr ago.
[-][$250] Deep-link - Infinite skeleton loader appears when navigating to non-existing profile[/-][+][HOLD for payment 2024-07-30][$250] Deep-link - Infinite skeleton loader appears when navigating to non-existing profile[/+]roryabraham commentedon Jul 23, 2024
@greg-schroeder the only payment that will be due here is $250 to @rushatgabhane for the PR review 🙇🏼
JmillsExpensify commentedon Jul 29, 2024
$250 approved for @rushatgabhane