Skip to content

[HOLD for payment 2024-07-30][$250] Deep-link - Infinite skeleton loader appears when navigating to non-existing profile #45486

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.7-4
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4723441
Email or phone of affected tester (no customers): gibethlehem.@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

  1. Log in to any account
  2. On the URL Navigate to https://staging.new.expensify.com/a/hello

Expected Result:

Infinite skeleton loader is not shown when navigating back form "Page not found" page

Actual Result:

Infinite skeleton loader is shown

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6543742_1721125977716.Screen_Recording_2024-07-16_at_1.01.55_PM.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01291dca77c0c7f6cb
  • Upwork Job ID: 1813499751389988808
  • Last Price Increase: 2024-07-17
Issue OwnerCurrent Issue Owner: @

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    DeployBlockerIndicates it should block deploying the API
    on Jul 16, 2024
  2. melvin-bot commented on Jul 16, 2024

    @melvin-bot

    Triggered auto assignment to @marcochavezf (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. github-actions commented on Jul 16, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. marcochavezf commented on Jul 16, 2024

    @marcochavezf
    Contributor

    Git bisect led me to this PR which possibly introduced the bug

  5. marcochavezf commented on Jul 16, 2024

    @marcochavezf
    Contributor

    DM'ed @roryabraham for a possible solution since trying to revert the offending PR brings complex conflicts. I will be back in a couple of hours

  6. removed
    DeployBlockerIndicates it should block deploying the API
    on Jul 16, 2024
  7. cead22 commented on Jul 16, 2024

    @cead22
    Contributor

    FWIW this doesn't seem worth blocking the app deploy to me

  8. roryabraham commented on Jul 16, 2024

    @roryabraham
    Contributor

    I'm looking at this now. It seems very similar to a bug I initially fixed here. Even though that PR wasn't perfect, the RCA remains valid.

    Basically, we're trying to use navigation.setParams before the navigation stack is ready. react-navigation assumes that you're calling that in response to a user action, so it isn't working in our case. Instead, we need to pass the correct initial report ID in the initialParams for the ReportScreen from within AuthScreens.

    This will be a bit tricky to get right since we'll only want to calculate the initial report once, during the first render, and only if there isn't already a reportID in the URL.

  9. thienlnam commented on Jul 16, 2024

    @thienlnam
    Contributor

    Removing blocker for this issue

  10. 25 remaining items

  11. syedmustafan commented on Jul 17, 2024

    @syedmustafan

    Contributor details
    Your Expensify account email: mustafanadeem627@gmail.com
    Upwork Profile Link: https://www.upwork.com/freelancers/~01153cf0ecb63d1e75

    It is working fine upon redirecting to https://staging.new.expensify.com/a/hello

    Screen.Recording.2024-07-17.at.7.53.42.PM.mov
  12. melvin-bot commented on Jul 17, 2024

    @melvin-bot
  13. roryabraham commented on Jul 17, 2024

    @roryabraham
    Contributor

    Thanks @syedmustafan, I've already got a PR in review to fix this issue

  14. roryabraham commented on Jul 18, 2024

    @roryabraham
    Contributor

    PR merged

  15. greg-schroeder commented on Jul 22, 2024

    @greg-schroeder
    Contributor

    On staging, awaiting deploy to prod

  16. roryabraham commented on Jul 23, 2024

    @roryabraham
    Contributor

    Deployed to prod 8hr ago.

  17. changed the title [-][$250] Deep-link - Infinite skeleton loader appears when navigating to non-existing profile[/-] [+][HOLD for payment 2024-07-30][$250] Deep-link - Infinite skeleton loader appears when navigating to non-existing profile[/+] on Jul 23, 2024
  18. roryabraham commented on Jul 23, 2024

    @roryabraham
    Contributor

    @greg-schroeder the only payment that will be due here is $250 to @rushatgabhane for the PR review 🙇🏼

  19. JmillsExpensify commented on Jul 29, 2024

    @JmillsExpensify
    Contributor

    $250 approved for @rushatgabhane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringInternalRequires API changes or must be handled by Expensify staffReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions