You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-08-19] [$250] Cannot search for emojis in status page #45629
We should also look for this issue in similar popovers.
What alternative solutions did you explore? (Optional)
We can warp the children content with FocusTrapForModal directly in PopoverWithoutOverlay, after that we there will be no need to wrap content FocusTrapForModal separately in components that uses PopoverWithMeasuredContent with withoutOverlay.
We can use shouldEnableNewFocusManagement prop to conditionally wrap children content with FocusTrapForModal in PopoverWithoutOverlay.
changed the title [-][$250] Cannot search for emojis in status page[/-][+][HOLD for payment 2024-08-19] [$250] Cannot search for emojis in status page[/+]on Aug 12, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.18-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@situchan] The PR that introduced the bug has been identified. Link to the PR:
[@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@situchan] Determine if we should create a regression test for this bug.
[@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Add focus trap #39520 (review)
[@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
[@situchan] Determine if we should create a regression test for this bug.
[@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Regression Test Steps
Go to settings -> Status > Open emoji picker
Verify that input is focused and can be used for searching emojis
Activity
melvin-bot commentedon Jul 17, 2024
Triggered auto assignment to @stephanieelliott (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.FitseTLT commentedon Jul 17, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Cannot search for emojis in status page
What is the root cause of that problem?
Because we are displaying the popover without overlay here
App/src/components/EmojiPicker/EmojiPicker.tsx
Line 213 in 7ba66a1
What changes do you think we should make in order to solve the problem?
We shouldn't pass
withoutOverlayas true, so we should remove this lineApp/src/components/EmojiPicker/EmojiPicker.tsx
Line 213 in 7ba66a1
Result:
2024-07-18.01-11-24.mp4
What alternative solutions did you explore? (Optional)
Krishna2323 commentedon Jul 18, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Cannot search for emojis in status page
What is the root cause of that problem?
The
EmojiPickercontent isn't wrapped inFocusTrapForModaland due to this the input can't be focused.App/src/components/EmojiPicker/EmojiPicker.tsx
Lines 198 to 232 in d739580
What changes do you think we should make in order to solve the problem?
We need to wrap the content inside
PopoverWithMeasuredContentwithFocusTrapForModal, just like we do inPopoverMenucomponent.App/src/components/PopoverMenu.tsx
Lines 203 to 266 in d739580
We should also look for this issue in similar popovers.
What alternative solutions did you explore? (Optional)
We can warp the children content with
FocusTrapForModaldirectly inPopoverWithoutOverlay, after that we there will be no need to wrap contentFocusTrapForModalseparately in components that usesPopoverWithMeasuredContentwithwithoutOverlay.We can use
shouldEnableNewFocusManagementprop to conditionally wrap children content withFocusTrapForModalinPopoverWithoutOverlay.Result
input_not_focused_emoji_picker.mp4
stephanieelliott commentedon Jul 22, 2024
Gonna close this as
Not a priorityas it does not fit into our current roadmap. May reopen in the future.Krishna2323 commentedon Jul 22, 2024
@stephanieelliott, I think we should fix this bug. @Beamanator, what's your opinion since you reported the bug?
mallenexpensify commentedon Jul 25, 2024
I think we should fix, just happened to me. Searching for emoji via text for status updates is common (3 folks reported bug)
30 remaining items
[-][$250] Cannot search for emojis in status page[/-][+][HOLD for payment 2024-08-19] [$250] Cannot search for emojis in status page[/+]melvin-bot commentedon Aug 12, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Aug 12, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.18-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-08-19. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Aug 12, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
stephanieelliott commentedon Aug 16, 2024
Hey @situchan can you please complete the BZ checklist when you get a chance?
situchan commentedon Aug 19, 2024
Regression Test Steps
stephanieelliott commentedon Aug 20, 2024
Summarizing payment on this issue:
Upwork job is here: https://www.upwork.com/jobs/~01298542065fc43b99
stephanieelliott commentedon Aug 20, 2024
Issue for test rail case here: https://github.com/Expensify/Expensify/issues/421648