You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Task – Deleted task appears on top of assignee LHN if creator delete it in group chat #45826
Version Number: v9.0.10-2 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: n/a Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause internal team Slack conversation:
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
I believe this relates to the same comment from here. Before, closed tasks were being rendered as archived as shown here. This is why they also floated to the bottom. But not, they're no longer being rendered as archived which is why they're higher up in the LHN. I left a fix in the linked comment but I think this behavior might be expected as well? @puneetlath if you could take a look at this one as well that would be great. Basically, deleted tasks are moving up in the LHN (because of recent activity), rather than moving to the bottom. Conversation to follow along
Yeah I agree, I think this is (new) expected behavior. Product-based question though - to me it would be confusing to see that it jumps up when deleted, but you don't actually know what task was deleted (since it only says [Deleted task]. Would it be possible / ideal to keep the task name in there, since we now know it's been deleted due to the subhead there?
Sounds like @puneetlath you'll be the best person to confirm that we should close this out. Thanks!
Ah ok I see. I think that deleted task in the LHN is just the last message posted though. So it would go away if you posted another message in there. So if we were to do this, I think we should show somewhere within the task itself that it's deleted.
Ah okay that makes sense! Adjusting that would be a follow up anyway - I'll put a note to discuss this in Slack at some point to figure out a better solution, since I think it's worth investigating.
But to confirm - this current issue as stated is not an issue, correct? We can close?
Activity
melvin-bot commentedon Jul 20, 2024
Triggered auto assignment to @kevinksullivan (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jul 20, 2024
Triggered auto assignment to @dangrous (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Jul 20, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
srikarparsi commentedon Jul 20, 2024
I believe this relates to the same comment from here. Before, closed tasks were being rendered as archived as shown here. This is why they also floated to the bottom. But not, they're no longer being rendered as archived which is why they're higher up in the LHN. I left a fix in the linked comment but I think this behavior might be expected as well? @puneetlath if you could take a look at this one as well that would be great. Basically, deleted tasks are moving up in the LHN (because of recent activity), rather than moving to the bottom. Conversation to follow along
mountiny commentedon Jul 22, 2024
Coming from that discussion, I do not think this is a blocker and more so an expected behaviour now that we need to align on
dangrous commentedon Jul 22, 2024
Yeah I agree, I think this is (new) expected behavior. Product-based question though - to me it would be confusing to see that it jumps up when deleted, but you don't actually know what task was deleted (since it only says
[Deleted task]. Would it be possible / ideal to keep the task name in there, since we now know it's been deleted due to the subhead there?Sounds like @puneetlath you'll be the best person to confirm that we should close this out. Thanks!
puneetlath commentedon Jul 24, 2024
In general, that makes sense to me. Which sub-header though?
dangrous commentedon Jul 24, 2024
sorry not sure what we call it - the preview in the LHN (

deleted task)Seems like it might be more helpful to say:
Go to the store
deleted task
so you know what was deleted, and it's not repetitive
puneetlath commentedon Jul 24, 2024
Ah ok I see. I think that
deleted taskin the LHN is just the last message posted though. So it would go away if you posted another message in there. So if we were to do this, I think we should show somewhere within the task itself that it's deleted.dangrous commentedon Jul 25, 2024
Ah okay that makes sense! Adjusting that would be a follow up anyway - I'll put a note to discuss this in Slack at some point to figure out a better solution, since I think it's worth investigating.
But to confirm - this current issue as stated is not an issue, correct? We can close?
puneetlath commentedon Jul 25, 2024
Agreed.