Skip to content

Profile - Date of birth - No minimum age limit on date of birth #45852

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.10-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to Account settings > Profile
  3. Click Date of birth

Expected Result:

There should be a minimum age limit on date of birth
For example, previously the app behavior is that user cannot pick date of birth earlier than 5 years

Actual Result:

There is no minimum age limit on date of birth

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6547935_1721467985686.20240720_172804.mp4

View all open jobs on GitHub

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 20, 2024
  2. melvin-bot commented on Jul 20, 2024

    @melvin-bot

    Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. lanitochka17 commented on Jul 20, 2024

    @lanitochka17
    Author

    @kadiealexander FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  4. lanitochka17 commented on Jul 20, 2024

    @lanitochka17
    Author

    We think that this bug might be related to #vip-vsp

  5. etCoderDysto commented on Jul 20, 2024

    @etCoderDysto
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    No minimum age limit on date of birth

    What is the root cause of that problem?

    Minimum age CONST.DATE_BIRTH.MIN_AGE used here is 0

    inputID={INPUT_IDS.DOB}
    label={translate('common.date')}
    defaultValue={privatePersonalDetails?.dob ?? ''}
    minDate={subYears(new Date(), CONST.DATE_BIRTH.MAX_AGE)}
    maxDate={subYears(new Date(), CONST.DATE_BIRTH.MIN_AGE)}

    What changes do you think we should make in order to solve the problem?

    Update the MIN_AGE used here to the desired number. Example 5

    MIN_AGE: 0,

    What alternative solutions did you explore? (Optional)

  6. Krishna2323 commented on Jul 21, 2024

    @Krishna2323
    Contributor

    I think this is expected behaviour introduced in this PR.

    cc: @dukenv0307

  7. kadiealexander commented on Jul 24, 2024

    @kadiealexander
    Contributor

    Agree, this is expected behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions