You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Profile - Date of birth - No minimum age limit on date of birth #45852
Version Number: 9.0.10-2 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team
Action Performed:
Go to staging.new.expensify.com
Go to Account settings > Profile
Click Date of birth
Expected Result:
There should be a minimum age limit on date of birth
For example, previously the app behavior is that user cannot pick date of birth earlier than 5 years
Actual Result:
There is no minimum age limit on date of birth
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
@kadiealexander FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
Activity
melvin-bot commentedon Jul 20, 2024
Triggered auto assignment to @kadiealexander (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.lanitochka17 commentedon Jul 20, 2024
@kadiealexander FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
lanitochka17 commentedon Jul 20, 2024
We think that this bug might be related to #vip-vsp
etCoderDysto commentedon Jul 20, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
No minimum age limit on date of birth
What is the root cause of that problem?
Minimum age CONST.DATE_BIRTH.MIN_AGE used here is 0
App/src/pages/settings/Profile/PersonalDetails/DateOfBirthPage.tsx
Lines 74 to 78 in fa738c6
What changes do you think we should make in order to solve the problem?
Update the MIN_AGE used here to the desired number. Example 5
App/src/CONST.ts
Line 198 in fa738c6
What alternative solutions did you explore? (Optional)
Krishna2323 commentedon Jul 21, 2024
I think this is expected behaviour introduced in this PR.
cc: @dukenv0307
kadiealexander commentedon Jul 24, 2024
Agree, this is expected behaviour.