Skip to content

[HOLD for payment 2024-08-05] [$125] Distance -"Your Location" address is shown in recent destination list #45882

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.10
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4751785
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. Launch app
  2. Tap fab -- new workspace
  3. Tap on workspace chat
  4. Tap plus icon near compose and select submit expense
  5. Tap distance
  6. Select "Your Location" as start point
  7. Select any other location as stop point
  8. Tap next and submit expense
  9. Tap plus icon near compose and select submit expense
  10. Tap distance
  11. Note recent destination

Expected Result:

"Your Location" address must not be shown in recent destination list while making distance request.

Actual Result:

"Your Location" address is shown in recent destination list while making distance request.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6549039_1721626693817.9o.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0190c5e3b9ced7a5ac
  • Upwork Job ID: 1815347966020873156
  • Last Price Increase: 2024-07-22
  • Automatic offers:
    • suneox | Reviewer | 103229659
    • nyomanjyotisa | Contributor | 103229662
Issue OwnerCurrent Issue Owner: @kevinksullivan

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Jul 22, 2024
  2. melvin-bot commented on Jul 22, 2024

    @melvin-bot

    Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Jul 22, 2024

    @melvin-bot

    Triggered auto assignment to @Gonals (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. github-actions commented on Jul 22, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. izarutskaya commented on Jul 22, 2024

    @izarutskaya
    Author

    We think this issue might be related to the #vip-vsb

  6. izarutskaya commented on Jul 22, 2024

    @izarutskaya
    Author

    Production
    Screenshot 2024-07-22 104321

  7. 26 remaining items

  8. changed the title [-][$125] Distance -"Your Location" address is shown in recent destination list[/-] [+][HOLD for payment 2024-08-05] [$125] Distance -"Your Location" address is shown in recent destination list[/+] on Jul 29, 2024
  9. melvin-bot commented on Jul 29, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  10. melvin-bot commented on Jul 29, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.13-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-08-05. 🎊

    For reference, here are some details about the assignees on this issue:

  11. melvin-bot commented on Jul 29, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@suneox] The PR that introduced the bug has been identified. Link to the PR:
    • [@suneox] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@suneox] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@suneox] Determine if we should create a regression test for this bug.
    • [@suneox] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@kevinksullivan] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  12. suneox commented on Aug 7, 2024

    @suneox
    Contributor

    BugZero Checklist

    • [@suneox] The PR that introduced the bug has been identified. Link to the PR: N/A: The initial code implementation for the recent waypoint doesn’t exclude the current location, so I don’t think there’s a PR responsible for this issue.
    • [@suneox] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
    • [@suneox] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
    • [@suneox] Determine if we should create a regression test for this bug. N/A
  13. melvin-bot commented on Aug 8, 2024

    @melvin-bot

    @suneox, @Gonals, @kevinksullivan, @nyomanjyotisa Whoops! This issue is 2 days overdue. Let's get this updated quick!

  14. suneox commented on Aug 9, 2024

    @suneox
    Contributor

    @kevinksullivan We’re still waiting for payment.

  15. kevinksullivan commented on Aug 9, 2024

    @kevinksullivan
    Contributor

    all set

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions