You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-08-05] [$125] Distance -"Your Location" address is shown in recent destination list #45882
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-][$125] Distance -"Your Location" address is shown in recent destination list[/-][+][HOLD for payment 2024-08-05] [$125] Distance -"Your Location" address is shown in recent destination list[/+]on Jul 29, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.13-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@suneox] The PR that introduced the bug has been identified. Link to the PR:
[@suneox] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@suneox] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@suneox] Determine if we should create a regression test for this bug.
[@suneox] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@kevinksullivan] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
[@suneox] The PR that introduced the bug has been identified. Link to the PR: N/A: The initial code implementation for the recent waypoint doesn’t exclude the current location, so I don’t think there’s a PR responsible for this issue.
[@suneox] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
[@suneox] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
[@suneox] Determine if we should create a regression test for this bug. N/A
Activity
melvin-bot commentedon Jul 22, 2024
Triggered auto assignment to @kevinksullivan (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jul 22, 2024
Triggered auto assignment to @Gonals (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Jul 22, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
izarutskaya commentedon Jul 22, 2024
We think this issue might be related to the #vip-vsb
izarutskaya commentedon Jul 22, 2024
Production

26 remaining items
[-][$125] Distance -"Your Location" address is shown in recent destination list[/-][+][HOLD for payment 2024-08-05] [$125] Distance -"Your Location" address is shown in recent destination list[/+]melvin-bot commentedon Jul 29, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jul 29, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.13-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-08-05. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jul 29, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
suneox commentedon Aug 7, 2024
BugZero Checklist
melvin-bot commentedon Aug 8, 2024
@suneox, @Gonals, @kevinksullivan, @nyomanjyotisa Whoops! This issue is 2 days overdue. Let's get this updated quick!
suneox commentedon Aug 9, 2024
@kevinksullivan We’re still waiting for payment.
kevinksullivan commentedon Aug 9, 2024
all set