You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-08-14] [$250] iOS - Expensify Card - Content on Expensify Card intro screen is truncated #45901
Version Number: 9.0.10-2 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team
Action Performed:
Precondition:
Device font size is increased
Launch New Expensify app
Go to workspace settings
Go to Expensify Card (enable on More features if not yet)
Expected Result:
The content will be displayed in two lines if it does not fit the screen (similar behavior with options on onboarding screen)
Actual Result:
"Up to 2% cash back on every US purchase" and "Spend controls and custom limits" are truncated
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
@slafortune FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
Please re-state the problem that we are trying to solve in this issue.
Expensify Card - Content on Expensify Card intro screen is truncated
What is the root cause of that problem?
We are not passing any value to numberOfLinesTitle prop of MenuItem. And MenuItem will use the default numberOfLinesTitle = 1 and truncates the contents.
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@Pujan92] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
[@Pujan92] Determine if we should create a regression test for this bug. Yes
[@Pujan92] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Regression Test Steps
Goto workspace settings page
Enable Expensify Card from More features if it is not enabled yet
Activity
melvin-bot commentedon Jul 22, 2024
Triggered auto assignment to @slafortune (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.lanitochka17 commentedon Jul 22, 2024
@slafortune FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
lanitochka17 commentedon Jul 22, 2024
We think that this bug might be related to #wave-collect - Release 2
etCoderDysto commentedon Jul 22, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Expensify Card - Content on Expensify Card intro screen is truncated
What is the root cause of that problem?
We are not passing any value to
numberOfLinesTitleprop ofMenuItem. AndMenuItemwill use the defaultnumberOfLinesTitle = 1and truncates the contents.App/src/components/FeatureList.tsx
Lines 101 to 108 in e3ebeff
What changes do you think we should make in order to solve the problem?
We should pass
numberOfLinesTitle={0}to the MenuItem to override the default value. No truncation will be applied on the content when the value is 0.What alternative solutions did you explore? (Optional)
We can set 'numberOfLinesTitle' to 2 of we don't want the number of lines not to exceed above 2 lines
Result:
melvin-bot commentedon Jul 22, 2024
Triggered auto assignment to @dubielzyk-expensify (
Design), see these Stack Overflow questions for more details.slafortune commentedon Jul 22, 2024
@dubielzyk-expensify With the font size increased, do we still expect to see full information or is truncated lines the expected outcome?
dubielzyk-expensify commentedon Jul 23, 2024
I don't think we should truncate the text given users should still be able to read it. So I expect two lines of text in this instance.
cc @Expensify/design for extra thoughts.
shawnborton commentedon Jul 23, 2024
Yup, I agree that the text shouldn't be truncated.
dannymcclain commentedon Jul 23, 2024
Definitely agree.
etCoderDysto commentedon Jul 23, 2024
Proposal updated
45 remaining items
slafortune commentedon Aug 14, 2024
@etCoderDysto can you please share your Upworks profile - I'm having a hard time finding you.
slafortune commentedon Aug 14, 2024
Offer sent - https://www.upwork.com/nx/wm/offer/103525438
etCoderDysto commentedon Aug 14, 2024
I have accepted the offer. Thanks!
melvin-bot commentedon Aug 14, 2024
Payment Summary
Upwork Job
BugZero Checklist (@slafortune)
slafortune commentedon Aug 16, 2024
bump @Pujan92, can you please complete the check list?
Pujan92 commentedon Aug 16, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
Regression Test Steps
melvin-bot commentedon Aug 19, 2024
@slafortune, @Pujan92, @MonilBhavsar, @dubielzyk-expensify, @etCoderDysto Whoops! This issue is 2 days overdue. Let's get this updated quick!
slafortune commentedon Aug 19, 2024
@Pujan92 - role C+ owed $250 via NewDot
JmillsExpensify commentedon Aug 20, 2024
$250 approved for @Pujan92