Skip to content

[HOLD for payment 2024-08-14] [$250] iOS - Expensify Card - Content on Expensify Card intro screen is truncated #45901

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.10-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

  • Device font size is increased
  1. Launch New Expensify app
  2. Go to workspace settings
  3. Go to Expensify Card (enable on More features if not yet)

Expected Result:

The content will be displayed in two lines if it does not fit the screen (similar behavior with options on onboarding screen)

Actual Result:

"Up to 2% cash back on every US purchase" and "Spend controls and custom limits" are truncated

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6549113_1721634244605.ScreenRecording_07-22-2024_15-36-33_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0126b472d9d6b81559
  • Upwork Job ID: 1815823007102686005
  • Last Price Increase: 2024-07-23
Issue OwnerCurrent Issue Owner: @slafortune

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 22, 2024
  2. melvin-bot commented on Jul 22, 2024

    @melvin-bot

    Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. lanitochka17 commented on Jul 22, 2024

    @lanitochka17
    Author

    @slafortune FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  4. lanitochka17 commented on Jul 22, 2024

    @lanitochka17
    Author

    We think that this bug might be related to #wave-collect - Release 2

  5. etCoderDysto commented on Jul 22, 2024

    @etCoderDysto
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Expensify Card - Content on Expensify Card intro screen is truncated

    What is the root cause of that problem?

    We are not passing any value to numberOfLinesTitle prop of MenuItem. And MenuItem will use the default numberOfLinesTitle = 1 and truncates the contents.

    <MenuItem
    title={translate(translationKey)}
    icon={icon}
    iconWidth={variables.menuIconSize}
    iconHeight={variables.menuIconSize}
    interactive={false}
    displayInDefaultIconColor
    wrapperStyle={[styles.p0, styles.cursorAuto]}

    What changes do you think we should make in order to solve the problem?

    We should pass numberOfLinesTitle={0} to the MenuItem to override the default value. No truncation will be applied on the content when the value is 0.

    What alternative solutions did you explore? (Optional)

    We can set 'numberOfLinesTitle' to 2 of we don't want the number of lines not to exceed above 2 lines

    Result:

    image

  6. melvin-bot commented on Jul 22, 2024

    @melvin-bot

    Triggered auto assignment to @dubielzyk-expensify (Design), see these Stack Overflow questions for more details.

  7. slafortune commented on Jul 22, 2024

    @slafortune
    Contributor

    @dubielzyk-expensify With the font size increased, do we still expect to see full information or is truncated lines the expected outcome?

  8. dubielzyk-expensify commented on Jul 23, 2024

    @dubielzyk-expensify
    Contributor

    I don't think we should truncate the text given users should still be able to read it. So I expect two lines of text in this instance.

    cc @Expensify/design for extra thoughts.

  9. shawnborton commented on Jul 23, 2024

    @shawnborton
    Contributor

    Yup, I agree that the text shouldn't be truncated.

  10. dannymcclain commented on Jul 23, 2024

    @dannymcclain
    Contributor

    Definitely agree.

  11. etCoderDysto commented on Jul 23, 2024

    @etCoderDysto
    Contributor

    Proposal updated

    • I have added screenshot of the result
  12. 45 remaining items

  13. slafortune commented on Aug 14, 2024

    @slafortune
    Contributor

    @etCoderDysto can you please share your Upworks profile - I'm having a hard time finding you.

  14. slafortune commented on Aug 14, 2024

    @slafortune
    Contributor
  15. etCoderDysto commented on Aug 14, 2024

    @etCoderDysto
    Contributor

    I have accepted the offer. Thanks!

  16. melvin-bot commented on Aug 14, 2024

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@slafortune)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1815823007102686005/hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  17. slafortune commented on Aug 16, 2024

    @slafortune
    Contributor

    bump @Pujan92, can you please complete the check list?

  18. Pujan92 commented on Aug 16, 2024

    @Pujan92
    Contributor

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    Regression Test Steps

    1. Goto workspace settings page
    2. Enable Expensify Card from More features if it is not enabled yet
    3. Goto the Expensify Card item
    4. Verify the features text points aren't truncated
  19. melvin-bot commented on Aug 19, 2024

    @melvin-bot

    @slafortune, @Pujan92, @MonilBhavsar, @dubielzyk-expensify, @etCoderDysto Whoops! This issue is 2 days overdue. Let's get this updated quick!

  20. slafortune commented on Aug 19, 2024

    @slafortune
    Contributor

    @Pujan92 - role C+ owed $250 via NewDot

  21. JmillsExpensify commented on Aug 20, 2024

    @JmillsExpensify
    Contributor

    $250 approved for @Pujan92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2DesignExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions