You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Track expense-App crashes when submitting a track expense to someone #46181
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Was able to reproduce the bug on staging, looks like the API call to SearchForReports failed, in my case it worked for the first few times but then later errored and returned no response:
I don't understand how originalMessage gets to be a string in the first place - can you tell if the stringified message you got here was returned by TrackExpense or something else?
I just tried the TrackExpense API from production and staging, and the backend returns the same format for both
{
"key": "reportActions_2308535023239471",
"onyxMethod": "merge",
"value": {
"983660383098354030": {
"actionName": "ACTIONABLETRACKEXPENSEWHISPER",
"actorAccountID": 8392101,
"avatar": "https://d1wpcgnaa73g0y.cloudfront.net/894b50e60056c966d12216005fbcacec8ce5a2c0.png",
"created": "2024-07-25 21:41:48.670",
"lastModified": "2024-07-25 21:41:48.670",
"message": [
{
"html": "What would you like to do with this expense?",
"text": "What would you like to do with this expense?",
"type": "COMMENT",
"whisperedTo": []
}
],
"originalMessage": {
"html": "What would you like to do with this expense?",
"lastModified": "2024-07-25 21:41:48.670",
"transactionID": "4621430576663691334"
},
"person": [
{
"style": "strong",
"text": "Expensify Concierge",
"type": "TEXT"
}
],
"previousReportActionID": "3201231829538080024",
"reportActionID": "983660383098354030",
"shouldShow": true
}
}
}
"reportActions_8326091604995297": {
"932416413244753707": {
"action": "ACTIONABLETRACKEXPENSEWHISPER",
"actorAccountID": 1,
"actorEmail": "concierge@expensify.com",
"created": "2024-07-25 20:56:55.686",
"message": "{\"html\":\"What would you like to do with this expense?\",\"lastModified\":\"2024-07-25 20:56:55.686\",\"transactionID\":\"146406399869489744\"}",
"reportActionID": 932416413244753700
},
Reacted by Ishpaul Singh, Nikki Wines and Francois Laithier
Activity
melvin-bot commentedon Jul 25, 2024
Triggered auto assignment to @lschurr (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jul 25, 2024
Triggered auto assignment to @NikkiWines (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Jul 25, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
m-natarajan commentedon Jul 25, 2024
We think that this bug might be related to #vip-vsb
MariaHCD commentedon Jul 25, 2024
Was able to reproduce the bug on staging, looks like the API call to SearchForReports failed, in my case it worked for the first few times but then later errored and returned no response:
Internal logs
NikkiWines commentedon Jul 25, 2024
I can reproduce it on dev, but found this PR on the most recent deploy that literally aims to fix this bug #45994
Given that I don't think this is a web deploy blocker (or even a newDot blocker, I just think the bug is not wholly fixed.
10 remaining items
ishpaul777 commentedon Jul 25, 2024
actually the type of reportAction.message is string for ACTIONABLE_MENTION_WHISPER, originalMessage seems depriciated.
App/src/libs/ReportActionsUtils.ts
Lines 193 to 196 in 4c18661
ishpaul777 commentedon Jul 25, 2024
Its a array on production server
NikkiWines commentedon Jul 25, 2024
originalMessagehas been deprecated for a while now (since here)But yeah if
messageis a string then definitely makes sense as the root for the issuefrancoisl commentedon Jul 25, 2024
I don't understand how
originalMessagegets to be a string in the first place - can you tell if the stringified message you got here was returned byTrackExpenseor something else?I just tried the
TrackExpenseAPI from production and staging, and the backend returns the same format for both{ "key": "reportActions_2308535023239471", "onyxMethod": "merge", "value": { "983660383098354030": { "actionName": "ACTIONABLETRACKEXPENSEWHISPER", "actorAccountID": 8392101, "avatar": "https://d1wpcgnaa73g0y.cloudfront.net/894b50e60056c966d12216005fbcacec8ce5a2c0.png", "created": "2024-07-25 21:41:48.670", "lastModified": "2024-07-25 21:41:48.670", "message": [ { "html": "What would you like to do with this expense?", "text": "What would you like to do with this expense?", "type": "COMMENT", "whisperedTo": [] } ], "originalMessage": { "html": "What would you like to do with this expense?", "lastModified": "2024-07-25 21:41:48.670", "transactionID": "4621430576663691334" }, "person": [ { "style": "strong", "text": "Expensify Concierge", "type": "TEXT" } ], "previousReportActionID": "3201231829538080024", "reportActionID": "983660383098354030", "shouldShow": true } } }rlinoz commentedon Jul 25, 2024
It is from SearchForReports
rlinoz commentedon Jul 25, 2024
I think it is coming from here: https://github.com/Expensify/Web-Expensify/pull/42853/files#diff-7a032f7284c8b42392fb9715c5196b05b34ebeb369ee31387f702a26980eb792R6566
It works correctly in the OpenApp flow, but not in the SearchForReports
francoisl commentedon Jul 25, 2024
Ooooh great find - you have to search for your own email to be able to reproduce.
That PR was deployed to production 6 hours ago and I can repro the crash on production too. We should probably revert it tbh.
francoisl commentedon Jul 25, 2024
We're going to cherry-pick a backend fix for this to staging and production now.
Thanks @ishpaul777 and @rlinoz for helping look into this 🙌
NikkiWines commentedon Jul 25, 2024
CP has installed on prod 👍
NikkiWines commentedon Jul 25, 2024
@francoisl confirmed here that this resolved the issue 🎊 🚀 ❤️