You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for Payment 2024-09-06] [$250] mWeb - Submit expense - Site crashes sending a distance expense after two scan expenses #46296
Version Number: 9.0.13-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail:https://expensify.testrail.io/index.php?/tests/view/4765667 Email or phone of affected tester (no customers):nahummelaku9+d27@gmail.com Issue reported by: Applause - Internal Team
Action Performed:
Login to staging.new.expensify.com
Navigate to FAB > Submit expense > Scan
Upload a receipt and click on next
Choose a workspace and submit it
Navigate to FAB>QAB(Scan IOU)
Upload a receipt and submit it to the same workspace
Navigate to FAB>Submit expense > Distance
Enter start and finish locations and click next
Select the same workspace you submitted the scan expenses to and click submit
Expected Result:
Distance expense is created and navigated to the conversation
Actual Result:
The site crashes with a message "Uh-oh, something went wrong!"
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
changed the title [-]mWeb - Submit expense - Site crashes sending a distance expense after two scan expenses[/-][+][$250] mWeb - Submit expense - Site crashes sending a distance expense after two scan expenses[/+]on Jul 31, 2024
@ikevin127 Maybe you can start the testing from your side till the adhoc builds are available. I need the adhoc builds since I'm unable to build locally.
changed the title [-][$250] mWeb - Submit expense - Site crashes sending a distance expense after two scan expenses[/-][+][HOLD for Payment 2024-09-06] [$250] mWeb - Submit expense - Site crashes sending a distance expense after two scan expenses[/+]on Sep 4, 2024
[@ikevin127] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A.
[@ikevin127] Determine if we should create a regression test for this bug.
[@ikevin127] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Regression Test Proposal
Login to staging.new.expensify.com .
Navigate to FAB > Submit expense > Scan.
Upload a receipt and click on Next.
Choose a workspace and submit it.
Navigate to FAB > QAB (Scan IOU).
Upload a receipt and submit it to the same workspace.
Navigate to FAB > Submit expense > Distance.
Enter start and finish locations and click Next.
Select the same workspace you submitted the scan expenses to and click Submit.
Test on different screen sizes / heights (iPhone 4 / 5, Samsung Galaxy S8, etc) and verify that the app doesn't crash when submitting the 3rd Distance request.
Activity
melvin-bot commentedon Jul 26, 2024
Triggered auto assignment to @greg-schroeder (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.ShridharGoel commentedon Jul 26, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Site crashes when distance map calls fitBounds with high padding on low screen size.
What is the root cause of that problem?
This happens when
fitBoundsis called with high padding, but the screen size is small.App/src/components/MapView/MapView.website.tsx
Line 148 in 2583e96
What changes do you think we should make in order to solve the problem?
We can make the
mapPaddingdependent on the screen size.In usages of
DistanceMapView, update mapPadding to below:This is used in
ConfirmedRouteandDistanceRequestFooter.Else, we can put the
getIsNarrowLayoutcheck while calling fitBounds.bernhardoj commentedon Jul 27, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
The app crash when adding a distance request after 2 scan request.
What is the root cause of that problem?
When we have 2 scan expense + 1 distance, the size of the preview becomes small.

Then, we set a padding of 50 to the map which will be used when trying to center the map.
App/src/components/ConfirmedRoute.tsx
Line 111 in 5e65276
App/src/components/MapView/MapView.website.tsx
Line 148 in 5e65276
However, the size of the map is smaller than the padding combined (left+right / top+bottom).
What changes do you think we should make in order to solve the problem?
Change the padding to the smallest size (or 0 or decrease the value) if it's bigger than the map size.
melvin-bot commentedon Jul 29, 2024
@greg-schroeder Whoops! This issue is 2 days overdue. Let's get this updated quick!
[-]mWeb - Submit expense - Site crashes sending a distance expense after two scan expenses[/-][+][$250] mWeb - Submit expense - Site crashes sending a distance expense after two scan expenses[/+]melvin-bot commentedon Jul 31, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01890de5ca6ea4b22c
42 remaining items
ShridharGoel commentedon Aug 21, 2024
@ikevin127 Maybe you can start the testing from your side till the adhoc builds are available. I need the adhoc builds since I'm unable to build locally.
greg-schroeder commentedon Aug 27, 2024
This on staging. Awaiting deploy to prod
ikevin127 commentedon Sep 3, 2024
Given the context above, this issue should be on Payment 2024-09-06 according to 4 days ago's production deploy from Deploy Checklist: New Expensify 2024-08-28.
cc @greg-schroeder @marcaaron
[-][$250] mWeb - Submit expense - Site crashes sending a distance expense after two scan expenses[/-][+][HOLD for Payment 2024-09-06] [$250] mWeb - Submit expense - Site crashes sending a distance expense after two scan expenses[/+]greg-schroeder commentedon Sep 4, 2024
Updated
ikevin127 commentedon Sep 5, 2024
MoneyRequestConfirmPagefor Distance Request #25707Regression Test Proposal
Do we agree 👍 or 👎.
ikevin127 commentedon Sep 8, 2024
cc @greg-schroeder
greg-schroeder commentedon Sep 9, 2024
Sorry, processing
greg-schroeder commentedon Sep 9, 2024
Paid @ikevin127 , sent new offer to @ShridharGoel. Will pay ASAP once accepted