Skip to content

[HOLD for payment 2024-08-07] [HOLD for payment 2024-08-05] [$250] Login - Incorrect error message "The given email is not valid." when login field is empty #46307

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.13-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #45456

Action Performed:

  1. Go to staging.new.expensify.com
  2. Log out if logged in.
  3. Do not enter email or phone number in login field.
  4. Navigate to an expired or invalid magic link (https://staging.new.expensify.com/v/17947659/471551
    )
  5. Click "just sign in here"
  6. Click "request one here"

Expected Result:

Since the login field is empty, the error message should be "Please enter an email or phone number"

Actual Result:

The error message is "The given email is not valid." when the login field is empty

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6553650_1721995908851.20240726_200630.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01c8fc425d7d2acad3
  • Upwork Job ID: 1816860521532505990
  • Last Price Increase: 2024-07-26
  • Automatic offers:
    • DylanDylann | Reviewer | 103281132
    • ShridharGoel | Contributor | 103281135
Issue OwnerCurrent Issue Owner: @johncschuster

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    DeployBlockerIndicates it should block deploying the API
    on Jul 26, 2024
  2. melvin-bot commented on Jul 26, 2024

    @melvin-bot

    Triggered auto assignment to @marcochavezf (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. github-actions commented on Jul 26, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. ShridharGoel commented on Jul 26, 2024

    @ShridharGoel
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Login - Incorrect error message "The given email is not valid." when login field is empty.

    What is the root cause of that problem?

    The login credentials are not available, which leads to sign in happening with a blank email.

    onPress={() => {
    Session.beginSignIn(credentials?.login ?? '');
    Navigation.setNavigationActionToMicrotaskQueue(Navigation.goBack);
    }}

    What changes do you think we should make in order to solve the problem?

    If login data like email is not available, the the request one here option shouldn't be shown.

    {
        credentials?.login ? (
            <Text style={styles.textAlignCenter}>
                {translate('validateCodeModal.expiredCodeDescription')}
                {translate('validateCodeModal.or')}{' '}
                <TextLink
                    onPress={() => {
                        Session.beginSignIn(credentials?.login ?? '');
                        Navigation.setNavigationActionToMicrotaskQueue(Navigation.goBack);
                    }}
                >
                    {translate('validateCodeModal.requestOneHere')}
                </TextLink>
            </Text>
        ) : (
            <Text style={styles.textAlignCenter}>
                {translate('validateCodeModal.expiredCodeDescription')}
            </Text>
        )
    }
    
  5. ShridharGoel commented on Jul 26, 2024

    @ShridharGoel
    Contributor

    @marcochavezf Since this is a deploy blocker, I can open the PR quickly.

  6. marcochavezf commented on Jul 26, 2024

    @marcochavezf
    Contributor

    Sounds good, let's do it @ShridharGoel

  7. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jul 26, 2024
  8. changed the title [-]Login - Incorrect error message "The given email is not valid." when login field is empty[/-] [+][$250] Login - Incorrect error message "The given email is not valid." when login field is empty[/+] on Jul 26, 2024
  9. melvin-bot commented on Jul 26, 2024

    @melvin-bot
  10. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jul 26, 2024
  11. 26 remaining items

  12. johncschuster commented on Jul 31, 2024

    @johncschuster
    Contributor

    Acknowledged! I'll issue payment after the regression threshold is cleared.

  13. changed the title [-][HOLD for payment 2024-08-05] [$250] Login - Incorrect error message "The given email is not valid." when login field is empty[/-] [+][HOLD for payment 2024-08-07] [HOLD for payment 2024-08-05] [$250] Login - Incorrect error message "The given email is not valid." when login field is empty[/+] on Jul 31, 2024
  14. melvin-bot commented on Jul 31, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.14-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-08-07. 🎊

    For reference, here are some details about the assignees on this issue:

  15. melvin-bot commented on Jul 31, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@DylanDylann] The PR that introduced the bug has been identified. Link to the PR:
    • [@DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@DylanDylann] Determine if we should create a regression test for this bug.
    • [@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@johncschuster] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  16. johncschuster commented on Aug 5, 2024

    @johncschuster
    Contributor

    Acknowledged! I'll issue payment after the regression threshold is cleared.

  17. johncschuster commented on Aug 7, 2024

    @johncschuster
    Contributor

    @DylanDylann can you please complete the BZ list above?

  18. johncschuster commented on Aug 7, 2024

    @johncschuster
    Contributor

    I have issued payment for @ShridharGoel. Thanks for your contributions! 🎉

  19. DylanDylann commented on Aug 8, 2024

    @DylanDylann
    Contributor

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    [@DylanDylann] The PR that introduced the bug has been identified. Link to the PR: NA
    [@DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: NA
    [@DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
    [@DylanDylann] Determine if we should create a regression test for this bug. Yes
    [@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    Regression Test Proposal

    1. Log out if logged in.
    2. Do not enter email or phone number in login field.
    3. Navigate to an expired or invalid magic link (https://staging.new.expensify.com/v/17947659/471551)
    4. Click "just sign in here"
    5. Verify that no link should show.

    Do we agree 👍 or 👎

  20. johncschuster commented on Aug 8, 2024

    @johncschuster
    Contributor

    I have issued payment for @DylanDylann. Thanks for your contributions! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions