You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-08-07] [HOLD for payment 2024-08-05] [$250] Login - Incorrect error message "The given email is not valid." when login field is empty #46307
Version Number: 9.0.13-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-]Login - Incorrect error message "The given email is not valid." when login field is empty[/-][+][$250] Login - Incorrect error message "The given email is not valid." when login field is empty[/+]on Jul 26, 2024
changed the title [-][HOLD for payment 2024-08-05] [$250] Login - Incorrect error message "The given email is not valid." when login field is empty[/-][+][HOLD for payment 2024-08-07] [HOLD for payment 2024-08-05] [$250] Login - Incorrect error message "The given email is not valid." when login field is empty[/+]on Jul 31, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.14-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@DylanDylann] The PR that introduced the bug has been identified. Link to the PR:
[@DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@DylanDylann] Determine if we should create a regression test for this bug.
[@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@johncschuster] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@DylanDylann] The PR that introduced the bug has been identified. Link to the PR: NA
[@DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: NA
[@DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
[@DylanDylann] Determine if we should create a regression test for this bug. Yes
[@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Regression Test Proposal
Log out if logged in.
Do not enter email or phone number in login field.
Activity
melvin-bot commentedon Jul 26, 2024
Triggered auto assignment to @marcochavezf (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Jul 26, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
ShridharGoel commentedon Jul 26, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Login - Incorrect error message "The given email is not valid." when login field is empty.
What is the root cause of that problem?
The login credentials are not available, which leads to sign in happening with a blank email.
App/src/components/ValidateCode/ExpiredValidateCodeModal.tsx
Lines 38 to 41 in c0f7868
What changes do you think we should make in order to solve the problem?
If login data like email is not available, the the
request one hereoption shouldn't be shown.ShridharGoel commentedon Jul 26, 2024
@marcochavezf Since this is a deploy blocker, I can open the PR quickly.
marcochavezf commentedon Jul 26, 2024
Sounds good, let's do it @ShridharGoel
[-]Login - Incorrect error message "The given email is not valid." when login field is empty[/-][+][$250] Login - Incorrect error message "The given email is not valid." when login field is empty[/+]melvin-bot commentedon Jul 26, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01c8fc425d7d2acad3
26 remaining items
johncschuster commentedon Jul 31, 2024
Acknowledged! I'll issue payment after the regression threshold is cleared.
[-][HOLD for payment 2024-08-05] [$250] Login - Incorrect error message "The given email is not valid." when login field is empty[/-][+][HOLD for payment 2024-08-07] [HOLD for payment 2024-08-05] [$250] Login - Incorrect error message "The given email is not valid." when login field is empty[/+]melvin-bot commentedon Jul 31, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.14-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-08-07. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jul 31, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
johncschuster commentedon Aug 5, 2024
Acknowledged! I'll issue payment after the regression threshold is cleared.
johncschuster commentedon Aug 7, 2024
@DylanDylann can you please complete the BZ list above?
johncschuster commentedon Aug 7, 2024
I have issued payment for @ShridharGoel. Thanks for your contributions! 🎉
DylanDylann commentedon Aug 8, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@DylanDylann] The PR that introduced the bug has been identified. Link to the PR: NA
[@DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: NA
[@DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
[@DylanDylann] Determine if we should create a regression test for this bug. Yes
[@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Regression Test Proposal
Do we agree 👍 or 👎
johncschuster commentedon Aug 8, 2024
I have issued payment for @DylanDylann. Thanks for your contributions! 🎉