You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Payment due Sept 6] [$250] Search - Expense page composer loses bottom margin when going offline #46404
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
The chatItemComposeSecondaryRow style contains the spacing. shouldUseNarrowLayout is true in RHP and when we go offline, both of the conditions become false, so the spacing is gone.
What changes do you think we should make in order to solve the problem?
Use the previous condition by relying on isSmallScreenWidth.
The reason we have this style in composer is that in ScreenWrapper, we have an offline indicator that is shown only on a small screen. However, we still want to show the offline indicator for the report screen, whether large or small screen, because it's the central screen.
!isSmallScreenWidth makes sure the spacing is always available on the large screen. (isSmallScreenWidth && !isOffline) allows the spacing to show on the small screen, but only when online (if we show it while offline too, then there will be extra space from the ScreenWrapper offline indicator).
Activity
melvin-bot commentedon Jul 29, 2024
Triggered auto assignment to @isabelastisser (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jul 29, 2024
Triggered auto assignment to @carlosmiceli (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Jul 29, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
izarutskaya commentedon Jul 29, 2024
Production
Recording.2656.mp4
nyomanjyotisa commentedon Jul 29, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Expense page composer loses bottom margin when going offline
What is the root cause of that problem?
if
isOfflinewe set the minHeight to 0 hereApp/src/pages/home/report/ReportFooter.tsx
Line 101 in 66ebb3e
And we no longer show the
OfflineIndicatorhere since we change the condition from!isSmallScreenWidthto!shouldUseNarrowLayouton this PRApp/src/pages/home/report/ReportFooter.tsx
Lines 194 to 196 in 66ebb3e
What changes do you think we should make in order to solve the problem?
set the
minHeightto 0 only ifisOffline && !shouldUseNarrowLayoutRESULT

What alternative solutions did you explore? (Optional)
bernhardoj commentedon Jul 29, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Composer bottom spacing is gone when turn offline in report RHP page.
What is the root cause of that problem?
This happens after we replace
isSmallScreenWidthusage withshouldUseNarrowLayout.App/src/pages/home/report/ReportActionCompose/ReportActionCompose.tsx
Lines 496 to 504 in 3722b22
The
chatItemComposeSecondaryRowstyle contains the spacing.shouldUseNarrowLayoutis true in RHP and when we go offline, both of the conditions become false, so the spacing is gone.What changes do you think we should make in order to solve the problem?
Use the previous condition by relying on
isSmallScreenWidth.The reason we have this style in composer is that in ScreenWrapper, we have an offline indicator that is shown only on a small screen. However, we still want to show the offline indicator for the report screen, whether large or small screen, because it's the central screen.
!isSmallScreenWidthmakes sure the spacing is always available on the large screen.(isSmallScreenWidth && !isOffline)allows the spacing to show on the small screen, but only when online (if we show it while offline too, then there will be extra space from the ScreenWrapper offline indicator).63 remaining items
isabelastisser commentedon Aug 27, 2024
It looks like PR was not merged yet. Waiting!
mananjadhav commentedon Sep 4, 2024
This was deployed to production 5 days ago. This should be ready for payout by 09/06.
isabelastisser commentedon Sep 4, 2024
Thanks for the update!
[-][$250] Search - Expense page composer loses bottom margin when going offline[/-][+][Payment due Sept 6] [$250] Search - Expense page composer loses bottom margin when going offline[/+]mananjadhav commentedon Sep 8, 2024
We linked the offending PR here but this is more of an edge case. We still use the
isSmallScreenWidth.Also I think we don't need a regression test for this one. @carlosmiceli wdyt?
@isabelastisser This is ready for payout. Can you please post a payout summary for this one?
carlosmiceli commentedon Sep 9, 2024
@mananjadhav Yeah, no need for regression test here!
isabelastisser commentedon Sep 9, 2024
Payment summary:
@mananjadhav, $250 for C+ review. Payment via NewDot
@bernhardoj, $250 for Contributor proposal - Payment via NewDot.
isabelastisser commentedon Sep 9, 2024
All set!
bernhardoj commentedon Sep 10, 2024
Requested in ND.
JmillsExpensify commentedon Sep 10, 2024
$250 approved for @bernhardoj
garrettmknight commentedon Sep 11, 2024
$250 approved for @mananjadhav