Skip to content

[Payment due Sept 6] [$250] Search - Expense page composer loses bottom margin when going offline #46404

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.13-3
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): bezawitgebremichael+11221122@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
*

Action Performed:

  1. Navigate to staging.new.expensify.com
  2. Create an expense
  3. Go to search
  4. Click on an expense from the expense list
  5. Go offline

Expected Result:

There will be an offline indicator under the composer and the composer will have a bottom margin

Actual Result:

The composer does not have a bottom margin and there is no offline indicator

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6554985_1722117881417.4_5848162808948069413.mp4

Bug6554985_1722117881426!Screenshot_1

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01a491780ac50be9ec
  • Upwork Job ID: 1817922651827967932
  • Last Price Increase: 2024-07-29
Issue OwnerCurrent Issue Owner: @mananjadhav

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Jul 29, 2024
  2. melvin-bot commented on Jul 29, 2024

    @melvin-bot

    Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Jul 29, 2024

    @melvin-bot

    Triggered auto assignment to @carlosmiceli (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. github-actions commented on Jul 29, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. izarutskaya commented on Jul 29, 2024

    @izarutskaya
    Author

    Production

    Recording.2656.mp4
  6. nyomanjyotisa commented on Jul 29, 2024

    @nyomanjyotisa
    Member

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Expense page composer loses bottom margin when going offline

    What is the root cause of that problem?

    if isOffline we set the minHeight to 0 here

    const chatFooterStyles = {...styles.chatFooter, minHeight: !isOffline ? CONST.CHAT_FOOTER_MIN_HEIGHT : 0};

    And we no longer show the OfflineIndicator here since we change the condition from !isSmallScreenWidth to !shouldUseNarrowLayout on this PR

    {!shouldUseNarrowLayout && (
    <View style={styles.offlineIndicatorRow}>{shouldHideComposer && <OfflineIndicator containerStyles={[styles.chatItemComposeSecondaryRow]} />}</View>
    )}

    What changes do you think we should make in order to solve the problem?

    set the minHeight to 0 only if isOffline && !shouldUseNarrowLayout

    const chatFooterStyles = {...styles.chatFooter, minHeight: isOffline && !shouldUseNarrowLayout ? 0 : CONST.CHAT_FOOTER_MIN_HEIGHT};
    

    RESULT
    image

    What alternative solutions did you explore? (Optional)

  7. bernhardoj commented on Jul 29, 2024

    @bernhardoj
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Composer bottom spacing is gone when turn offline in report RHP page.

    What is the root cause of that problem?

    This happens after we replace isSmallScreenWidth usage with shouldUseNarrowLayout.

    <View
    style={[
    styles.flexRow,
    styles.justifyContentBetween,
    styles.alignItemsCenter,
    (!shouldUseNarrowLayout || (shouldUseNarrowLayout && !isOffline)) && styles.chatItemComposeSecondaryRow,
    ]}
    >
    {!shouldUseNarrowLayout && <OfflineIndicator containerStyles={[styles.chatItemComposeSecondaryRow]} />}

    The chatItemComposeSecondaryRow style contains the spacing. shouldUseNarrowLayout is true in RHP and when we go offline, both of the conditions become false, so the spacing is gone.

    What changes do you think we should make in order to solve the problem?

    Use the previous condition by relying on isSmallScreenWidth.

    (!isSmallScreenWidth || (isSmallScreenWidth && !isOffline)) && styles.chatItemComposeSecondaryRow,
    

    The reason we have this style in composer is that in ScreenWrapper, we have an offline indicator that is shown only on a small screen. However, we still want to show the offline indicator for the report screen, whether large or small screen, because it's the central screen.

    !isSmallScreenWidth makes sure the spacing is always available on the large screen. (isSmallScreenWidth && !isOffline) allows the spacing to show on the small screen, but only when online (if we show it while offline too, then there will be extra space from the ScreenWrapper offline indicator).

  8. 63 remaining items

  9. isabelastisser commented on Aug 27, 2024

    @isabelastisser
    Contributor

    It looks like PR was not merged yet. Waiting!

  10. mananjadhav commented on Sep 4, 2024

    @mananjadhav
    Collaborator

    This was deployed to production 5 days ago. This should be ready for payout by 09/06.

  11. isabelastisser commented on Sep 4, 2024

    @isabelastisser
    Contributor

    Thanks for the update!

  12. changed the title [-][$250] Search - Expense page composer loses bottom margin when going offline[/-] [+][Payment due Sept 6] [$250] Search - Expense page composer loses bottom margin when going offline[/+] on Sep 4, 2024
  13. mananjadhav commented on Sep 8, 2024

    @mananjadhav
    Collaborator

    We linked the offending PR here but this is more of an edge case. We still use the isSmallScreenWidth.

    Also I think we don't need a regression test for this one. @carlosmiceli wdyt?

    @isabelastisser This is ready for payout. Can you please post a payout summary for this one?

  14. carlosmiceli commented on Sep 9, 2024

    @carlosmiceli
    Contributor

    @mananjadhav Yeah, no need for regression test here!

  15. isabelastisser commented on Sep 9, 2024

    @isabelastisser
    Contributor

    Payment summary:

    @mananjadhav, $250 for C+ review. Payment via NewDot
    @bernhardoj, $250 for Contributor proposal - Payment via NewDot.

  16. isabelastisser commented on Sep 9, 2024

    @isabelastisser
    Contributor

    All set!

  17. bernhardoj commented on Sep 10, 2024

    @bernhardoj
    Contributor

    Requested in ND.

  18. JmillsExpensify commented on Sep 10, 2024

    @JmillsExpensify
    Contributor

    $250 approved for @bernhardoj

  19. garrettmknight commented on Sep 11, 2024

    @garrettmknight
    Contributor

    $250 approved for @mananjadhav

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in review

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions