You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-08-14] [$250] Dupe detect-Incorrect total amount in the expense report, preview & LHN after deleting offline #46449
Version Number: 9.0.14-1 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team
Action Performed:
Go to staging.new.expensify.com
Go to workspace chat
Submit two same expenses
Click on the expense preview in main chat
Click on the first expense (important)
Go offline
Click Review duplicates
Click Keep this one on the second expense (important)
Click Confirm on the confirmation page
Check the total amount in the expense report and also the expense preview in the main chat and LHN
Expected Result:
The total amount in the expense report, and expense preview in the main chat and LHN will update correctly
Actual Result:
In the expense report, the total is 0.00
In the main chat, the expense preview is the sum of two expenses, including the deleted one
In the LHN, the preview for the main chat is 0.00
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-][$250] Dupe detect-Incorrect total amount in the expense report, preview & LHN after deleting offline[/-][+][HOLD for payment 2024-08-14] [$250] Dupe detect-Incorrect total amount in the expense report, preview & LHN after deleting offline[/+]on Aug 7, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.17-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@akinwale] The PR that introduced the bug has been identified. Link to the PR:
[@akinwale] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@akinwale] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@akinwale] Determine if we should create a regression test for this bug.
[@akinwale] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@CortneyOfstad / @muttmuure] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
[@akinwale] The PR that introduced the bug has been identified. Link to the PR:
[@akinwale] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@akinwale] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@akinwale] Determine if we should create a regression test for this bug.
[@akinwale] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Regression Test Steps
Launch Expensify
Open a workspace chat report
Submit two similar expenses (same amount, currency and merchant)
Click on the expense preview in the main chat report
Click on the first expense
Go offline
Click Review duplicates
Click Keep this one on the second expense
Click Confirm on the confirmation page
Navigate back to the expense report
Verify that the total amount is the same as the selected expense amount
Navigate back to the main chat report
Verify that the report preview amount is the same as the selected expense amount
Navigate back to LHN (on mobile)
Verify that the total amount in the LHN for the last message is the same as the selected expense amount
Activity
melvin-bot commentedon Jul 29, 2024
Triggered auto assignment to @roryabraham (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Jul 29, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
lanitochka17 commentedon Jul 29, 2024
We think that this bug might be related to #wave-collect - Release 2
roryabraham commentedon Jul 29, 2024
definitely front-end since it's only for optimistic state
roryabraham commentedon Jul 29, 2024
confirmed that dupe detection is still behind a beta so demoting this.
31 remaining items
[-][$250] Dupe detect-Incorrect total amount in the expense report, preview & LHN after deleting offline[/-][+][HOLD for payment 2024-08-14] [$250] Dupe detect-Incorrect total amount in the expense report, preview & LHN after deleting offline[/+]melvin-bot commentedon Aug 7, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Aug 7, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.17-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-08-14. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Aug 7, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
akinwale commentedon Aug 14, 2024
This was a regression from #42503. Comment.
Regression Test Steps
Do we agree 👍 or 👎?
CortneyOfstad commentedon Aug 14, 2024
Payment Summary
@bernhardoj -- to be paid $250 via NewDot
@akinwale -- paid $250 via Upwork
Regression test here
bernhardoj commentedon Aug 15, 2024
Requested in ND.
JmillsExpensify commentedon Aug 21, 2024
$250 approved for @bernhardoj