Skip to content

[HOLD for payment 2024-08-14] [$250] Dupe detect-Incorrect total amount in the expense report, preview & LHN after deleting offline #46449

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.14-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat
  3. Submit two same expenses
  4. Click on the expense preview in main chat
  5. Click on the first expense (important)
  6. Go offline
  7. Click Review duplicates
  8. Click Keep this one on the second expense (important)
  9. Click Confirm on the confirmation page
  10. Check the total amount in the expense report and also the expense preview in the main chat and LHN

Expected Result:

The total amount in the expense report, and expense preview in the main chat and LHN will update correctly

Actual Result:

In the expense report, the total is 0.00
In the main chat, the expense preview is the sum of two expenses, including the deleted one
In the LHN, the preview for the main chat is 0.00

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6556635_1722284178448.20240730_040603.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01bae72e20bb144f65
  • Upwork Job ID: 1818041683906527046
  • Last Price Increase: 2024-07-29
  • Automatic offers:
    • akinwale | Reviewer | 103331326
Issue OwnerCurrent Issue Owner: @CortneyOfstad / @muttmuure

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    DeployBlockerIndicates it should block deploying the API
    on Jul 29, 2024
  2. melvin-bot commented on Jul 29, 2024

    @melvin-bot

    Triggered auto assignment to @roryabraham (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. github-actions commented on Jul 29, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. lanitochka17 commented on Jul 29, 2024

    @lanitochka17
    Author

    We think that this bug might be related to #wave-collect - Release 2

  5. roryabraham commented on Jul 29, 2024

    @roryabraham
    Contributor

    definitely front-end since it's only for optimistic state

  6. roryabraham commented on Jul 29, 2024

    @roryabraham
    Contributor

    confirmed that dupe detection is still behind a beta so demoting this.

  7. added
    BugSomething is broken. Auto assigns a BugZero manager.
    and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Jul 29, 2024
  8. 31 remaining items

  9. changed the title [-][$250] Dupe detect-Incorrect total amount in the expense report, preview & LHN after deleting offline[/-] [+][HOLD for payment 2024-08-14] [$250] Dupe detect-Incorrect total amount in the expense report, preview & LHN after deleting offline[/+] on Aug 7, 2024
  10. melvin-bot commented on Aug 7, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  11. melvin-bot commented on Aug 7, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.17-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-08-14. 🎊

    For reference, here are some details about the assignees on this issue:

  12. melvin-bot commented on Aug 7, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@akinwale] The PR that introduced the bug has been identified. Link to the PR:
    • [@akinwale] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@akinwale] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@akinwale] Determine if we should create a regression test for this bug.
    • [@akinwale] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@CortneyOfstad / @muttmuure] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  13. akinwale commented on Aug 14, 2024

    @akinwale
    Contributor
    • [@akinwale] The PR that introduced the bug has been identified. Link to the PR:
    • [@akinwale] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@akinwale] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

    This was a regression from #42503. Comment.

    • [@akinwale] Determine if we should create a regression test for this bug.
    • [@akinwale] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    Regression Test Steps

    • Launch Expensify
    • Open a workspace chat report
    • Submit two similar expenses (same amount, currency and merchant)
    • Click on the expense preview in the main chat report
    • Click on the first expense
    • Go offline
    • Click Review duplicates
    • Click Keep this one on the second expense
    • Click Confirm on the confirmation page
    • Navigate back to the expense report
    • Verify that the total amount is the same as the selected expense amount
    • Navigate back to the main chat report
    • Verify that the report preview amount is the same as the selected expense amount
    • Navigate back to LHN (on mobile)
    • Verify that the total amount in the LHN for the last message is the same as the selected expense amount

    Do we agree 👍 or 👎?

  14. CortneyOfstad commented on Aug 14, 2024

    @CortneyOfstad
    Contributor

    Payment Summary

    @bernhardoj -- to be paid $250 via NewDot
    @akinwale -- paid $250 via Upwork

    Regression test here

  15. bernhardoj commented on Aug 15, 2024

    @bernhardoj
    Contributor

    Requested in ND.

  16. JmillsExpensify commented on Aug 21, 2024

    @JmillsExpensify
    Contributor

    $250 approved for @bernhardoj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions