Skip to content

[GETUSHA - WAITING ON CHECKLIST] [$250] [New feature] Add loading indicator when ReconnectApp is running #46611

Closed

Description

@slafortune

Original post -

Version Number: v1.4.77-11
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): NA
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL: https://github.com/Expensify/Expensify/issues/350373
Issue reported by: @flodnv
Slack conversation: Original proposal here
: https://expensify.slack.com/archives/C01GTK53T8Q/p1699972596342559

Sometimes, the app is loading something for a little while; as an end user, you have no clue what's happening. Then, when loading finishes, sometimes several seconds later, all of a sudden, new data pops up and takes you by surprise, resulting in a very unpleasant UX that almost feels broken.

Coming from this we've landed on showing the thin bar loader at the top of the screen when ReconnectApp is running.

image

@dubielzyk-expensify created a CodePen and it's the animation called Rubber Band or #loading1 in code.

My code isn't the best so I'd urge us to optimize it rather than copy paste 😅

Much discussion took place here

Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021836556152855644897
  • Upwork Job ID: 1836556152855644897
  • Last Price Increase: 2024-09-19
  • Automatic offers:
    • shubham1206agra | Contributor | 104442782
Issue OwnerCurrent Issue Owner: @jliexpensify

Activity

  1. melvin-bot commented on Jul 31, 2024

    @melvin-bot

    Triggered auto assignment to @jliexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

  2. melvin-bot commented on Jul 31, 2024

    @melvin-bot

    ⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

  3. melvin-bot commented on Jul 31, 2024

    @melvin-bot

    Triggered auto assignment to Design team member for new feature review - @dubielzyk-expensify (NewFeature)

  4. getusha commented on Jul 31, 2024

    @getusha
    Contributor

    @slafortune could you assign me here too? thanks :)

  5. jliexpensify commented on Jul 31, 2024

    @jliexpensify
    Contributor

    Assigned you @getusha

  6. dubielzyk-expensify commented on Aug 1, 2024

    @dubielzyk-expensify
    Contributor

    Excited about this one. Let me know when there's something to look and test 😄

  7. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Aug 1, 2024
  8. melvin-bot commented on Aug 1, 2024

    @melvin-bot

    Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

  9. 190 remaining items

  10. jliexpensify commented on Feb 11, 2025

    @jliexpensify
    Contributor

    Bumping @getusha once again for a checklist

    Image

  11. jliexpensify commented on Feb 12, 2025

    @jliexpensify
    Contributor

    @getusha checklist plzzzzz:

    Image

  12. nkdengineer commented on Feb 12, 2025

    @nkdengineer
    Contributor

    @jliexpensify I think you can ping him in Slack 😅 .

  13. jliexpensify commented on Feb 12, 2025

    @jliexpensify
    Contributor

    Image

  14. jliexpensify commented on Feb 12, 2025

    @jliexpensify
    Contributor

    🤷 a meme a day until I see a checklist

  15. s77rt commented on Feb 12, 2025

    @s77rt
    Member

    @getusha Do not do the checklist, those memes are funny

  16. getusha commented on Feb 12, 2025

    @getusha
    Contributor

    Oh my gosh!
    I mostly try to complete multiple checklists at once when submitting ND request. Can't believe i missed all this😄 sorry!

  17. getusha commented on Feb 12, 2025

    @getusha
    Contributor

    ANDDD this is a new feature we don't need a checklist. here is a regression test proposal.

    Regression Test Proposal

    Test:

    1. Open the app
    2. Force offline
    3. Navigate to Settings > Troubleshoot
    4. Clear cache and restart
    5. Navigate to Inbox
    6. Verify that there is a loading indicator bar on top of the LHN

    Do we agree 👍 or 👎

  18. getusha commented on Feb 12, 2025

    @getusha
    Contributor

    Me when it's time to fill out the checklist:

  19. jliexpensify commented on Feb 12, 2025

    @jliexpensify
    Contributor

    @getusha I was wondering if you were OOO or just ignoring me 😅

    Image

    ^ Final meme, thanks everyone for participating

  20. jliexpensify commented on Feb 12, 2025

    @jliexpensify
    Contributor
  21. garrettmknight commented on Mar 11, 2025

    @garrettmknight
    Contributor

    $250 approved for @getusha after almost an entire year.

  22. moved this from Release 2.5: SuiteWorld (Sept 9th) to Done in [#whatsnext] #wave-collecton Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2ExternalAdded to denote the issue can be worked on by a contributorNewFeatureSomething to build that is a new item.

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions