You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-08-19] [$250] Track - Self-DM chat appears briefly when track expense from FAB #46674
Version Number: 9.0.15-1 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail:N/A Issue reported by: Applause - Internal Team
Action Performed:
Go to FAB> Track expense> Finish the flow
Go to self-DM chat> Select Do nothing from actionable whispers
Open any other chat
Go back to FAB> Track Expense
Expected Result:
Self-DM chat should not appears when select option to track expense
Actual Result:
Self-DM chat appears briefly when track expense from FAB even other chat was open before this action
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
@OfstadC FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
What changes do you think we should make in order to solve the problem?
We can include the money request screen in RHP_SCREENS_OPENED_FROM_LHN list so it won't be added to the stack when navigating to the money request page, including track expense.
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.18-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@c3024] The PR that introduced the bug has been identified. Link to the PR:
[@c3024] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@c3024] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@c3024] Determine if we should create a regression test for this bug.
[@c3024] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@c3024] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: I don't think this bug could not have been identified earlier so no discussion was started.
[@c3024] Determine if we should create a regression test for this bug. Yes
[@c3024] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Activity
melvin-bot commentedon Aug 1, 2024
Triggered auto assignment to @OfstadC (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.lanitochka17 commentedon Aug 1, 2024
We think that this bug might be related to #vip-vsp
lanitochka17 commentedon Aug 1, 2024
@OfstadC FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
OfstadC commentedon Aug 1, 2024
Didn't get to this today. Reassigning as i'm out tomorrow and Monday. Happy to take back on Tuesday if no forward movement before then
melvin-bot commentedon Aug 1, 2024
Triggered auto assignment to @isabelastisser (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.bernhardoj commentedon Aug 2, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
The self DM shows briefly when open track expense.
What is the root cause of that problem?
The self DM shows because the matching route here for the track expense page is the self DM report.
App/src/libs/Navigation/linkingConfig/getAdaptedStateFromPath.ts
Line 188 in 5005f59
It checks the screen params and if reportID is found and valid, then the report is returned.
App/src/libs/Navigation/linkingConfig/getAdaptedStateFromPath.ts
Lines 153 to 156 in 5005f59
Track expense page reportID params is the self DM reportID. Because the matching route is found, we push it to the adapted routes,
App/src/libs/Navigation/linkingConfig/getAdaptedStateFromPath.ts
Lines 207 to 209 in 5005f59
which will be later used if isCentralPaneAndBottomTabMandatory or isFullScreenNavigatorMandatory is true, which is true in our case.
App/src/libs/Navigation/linkTo/index.ts
Lines 135 to 142 in 5005f59
What changes do you think we should make in order to solve the problem?
We can include the money request screen in
RHP_SCREENS_OPENED_FROM_LHNlist so it won't be added to the stack when navigating to the money request page, including track expense.App/src/libs/Navigation/linkingConfig/getAdaptedStateFromPath.ts
Lines 189 to 193 in 5005f59
App/src/libs/Navigation/linkingConfig/getAdaptedStateFromPath.ts
Lines 207 to 209 in 5005f59
github-actions commentedon Aug 2, 2024
true
isabelastisser commentedon Aug 2, 2024
#vip-vsb status.
21 remaining items
melvin-bot commentedon Aug 12, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Aug 12, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.18-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-08-19. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Aug 12, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
c3024 commentedon Aug 19, 2024
Regression Test Proposal
isabelastisser commentedon Aug 19, 2024
@puneetlath do you agree with the regression test proposal?
bernhardoj commentedon Aug 20, 2024
Requested in ND.
isabelastisser commentedon Aug 20, 2024
Payment summary:
$250 to @c3024 for C+ review. Paid in Upwork.
$250 to @bernhardoj for proposal. Requested in ND,
PENDING.isabelastisser commentedon Aug 20, 2024
All set!
JmillsExpensify commentedon Aug 21, 2024
$250 approved for @bernhardoj