You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2021-12-06] [HOLD for payment 2021-11-25] Update "Be the first person to comment!" screen when you start a new DM #4678
Sent DM message to someone I hadn't messaged before
Expected Result:
The blank screen should have avatars, a message for "This is the beginning of your chat history with XXXX (pronouns), as well as showing the timezone above the message input when messaging someone 1:1.
Actual Result:
Only see "Be the first person to comment!"
Solution
Let's update this state/area to include the users icon, name, preferred pronouns and the time in their time zone (only if 1:1 DM).
Great point @Santhosh-Sellavel ! I addressed your question in an old internal issue we had been working on, I instructed folks to post comments/feedback to this issue. We have two choices
Address group chats in this GH and figure out what we want before posting the job.
Only focus on the single DM usecase for now and address groups later.
It will very likely be external @Santhosh-Sellavel , @michaelhaxhiu needs to triage the issue first, part of that is figuring out what we want to do about group messages. My hunch is it's best to fix this issue specifically for the 1:1 DM usecase now then create a new issue in the future to address both group messages and possibly rooms.
@michaelhaxhiu, this shouldn't require a designer, an engineer should be able to take care of everything
Great question about the group. I want to say lets work on how the 1:1 looks like and then probably handle the group in a new GH to keep things neat and tidy. I'd love to say whatever we use for 1:1 will work for the group but ard to say that as of now :)
@megankelso@michelle-thompson I vaguely recall that we explored what this screen would look like for various use cases... actually I think it was @michelle-thompson that did it for Concierge Travel.
So basically we could do something like this?
And maybe before we have those features ready to go, we could just use a generic message for the group situation like so:
And then in terms of scalability, looks like Michelle had mocked up something like this for when a group has lots of participants:
Sweet, so I think maybe we want to make the avatars in my mockup a bit smaller like your original mocks (the one at the bottom) for scalability purposes. Otherwise, then I think we just need to decide if we're going to add Group chats to the exported Upwork issue?
@michaelhaxhiu let me correct, the 250 that was paid, was not of n6-hold bonus it was half of $500 from jobs. Thanks
that's why i added a milestone for n6-hold
changed the title [-]Update "Be the first person to comment!" screen when you start a new DM [/-][+][HOLD for payment 2021-11-25] Update "Be the first person to comment!" screen when you start a new DM [/+]on Nov 18, 2021
changed the title [-][HOLD for payment 2021-11-25] Update "Be the first person to comment!" screen when you start a new DM [/-][+][HOLD for payment 2021-12-06] [HOLD for payment 2021-11-25] Update "Be the first person to comment!" screen when you start a new DM [/+]on Nov 29, 2021
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.16-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
Activity
MelvinBot commentedon Aug 16, 2021
Triggered auto assignment to @michaelhaxhiu (
AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.Santhosh-Sellavel commentedon Aug 16, 2021
@mallenexpensify
What's it gonna be for the new group chat?
mallenexpensify commentedon Aug 16, 2021
Great point @Santhosh-Sellavel ! I addressed your question in an old internal issue we had been working on, I instructed folks to post comments/feedback to this issue. We have two choices
Santhosh-Sellavel commentedon Aug 16, 2021
Is this going to be external? @mallenexpensify
If it's I'm interest then.
An overview of implementation details,
ReportActionsView.jsmallenexpensify commentedon Aug 16, 2021
It will very likely be external @Santhosh-Sellavel , @michaelhaxhiu needs to triage the issue first, part of that is figuring out what we want to do about group messages. My hunch is it's best to fix this issue specifically for the 1:1 DM usecase now then create a new issue in the future to address both group messages and possibly rooms.
@michaelhaxhiu, this shouldn't require a designer, an engineer should be able to take care of everything
rosegrech commentedon Aug 16, 2021
Great question about the group. I want to say lets work on how the 1:1 looks like and then probably handle the group in a new GH to keep things neat and tidy. I'd love to say whatever we use for 1:1 will work for the group but ard to say that as of now :)
shawnborton commentedon Aug 17, 2021
@megankelso @michelle-thompson I vaguely recall that we explored what this screen would look like for various use cases... actually I think it was @michelle-thompson that did it for Concierge Travel.
So basically we could do something like this?

And maybe before we have those features ready to go, we could just use a generic message for the group situation like so:

And then in terms of scalability, looks like Michelle had mocked up something like this for when a group has lots of participants:

michelle-thompson commentedon Aug 17, 2021
Cool, happy to move forward with the generic messaging you've mocked up above!
shawnborton commentedon Aug 17, 2021
Sweet, so I think maybe we want to make the avatars in my mockup a bit smaller like your original mocks (the one at the bottom) for scalability purposes. Otherwise, then I think we just need to decide if we're going to add Group chats to the exported Upwork issue?
michelle-thompson commentedon Aug 17, 2021
Ahh, you mean so the size of the avatar never has to change? And I figure might as well add group chats to this issue.
shawnborton commentedon Aug 17, 2021
Yeah, I think I like the size you had here:

...better than the larger size I used. So that gives us something like this:

141 remaining items
MirFahad58 commentedon Nov 18, 2021
@michaelhaxhiu let me correct, the 250 that was paid, was not of n6-hold bonus it was half of $500 from jobs. Thanks
that's why i added a milestone for n6-hold
michaelhaxhiu commentedon Nov 18, 2021
Ok so it sounds like you are saying:
Is that right?
MirFahad58 commentedon Nov 18, 2021
right
michaelhaxhiu commentedon Nov 18, 2021
Ok got it. I think that is fine, I'll issue the $250 payment now.
Then, you'll receive the remaining $250 on November 25.
Note: our milestones aren't named correctly, but thats ok because they are in $250 incraments.
MirFahad58 commentedon Nov 18, 2021
yup thanks
[-]Update "Be the first person to comment!" screen when you start a new DM [/-][+][HOLD for payment 2021-11-25] Update "Be the first person to comment!" screen when you start a new DM [/+]mallenexpensify commentedon Nov 25, 2021
Paid final $250 to @MirFahad58 , thanks for the help and patience.
[-][HOLD for payment 2021-11-25] Update "Be the first person to comment!" screen when you start a new DM [/-][+][HOLD for payment 2021-12-06] [HOLD for payment 2021-11-25] Update "Be the first person to comment!" screen when you start a new DM [/+]botify commentedon Nov 29, 2021
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.16-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2021-12-06. 🎊
melvin-bot commentedon Aug 25, 2022
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
melvin-bot commentedon Sep 2, 2022
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.