Skip to content

[HOLD for payment 2021-12-06] [HOLD for payment 2021-11-25] Update "Be the first person to comment!" screen when you start a new DM  #4678

Closed

Description

@mallenexpensify

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

Sent DM message to someone I hadn't messaged before

Expected Result:

The blank screen should have avatars, a message for "This is the beginning of your chat history with XXXX (pronouns), as well as showing the timezone above the message input when messaging someone 1:1.

Actual Result:

Only see "Be the first person to comment!"

Solution

Let's update this state/area to include the users icon, name, preferred pronouns and the time in their time zone (only if 1:1 DM).
image

Design files are here in Figma

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Expensify/Expensify Issue URL: link

View all open jobs on Upwork

Upwork job: https://www.upwork.com/jobs/~0159561fdd76ccd036

Activity

  1. MelvinBot commented on Aug 16, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @michaelhaxhiu (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

  2. removed
    AutoAssignerTriageAuto assign issues for triage to an available triage team member
    on Aug 16, 2021
  3. Santhosh-Sellavel commented on Aug 16, 2021

    @Santhosh-Sellavel
    Collaborator

    @mallenexpensify

    What's it gonna be for the new group chat?

    Screenshot 2021-08-17 at 12 37 42 AM

  4. mallenexpensify commented on Aug 16, 2021

    @mallenexpensify
    ContributorAuthor

    Great point @Santhosh-Sellavel ! I addressed your question in an old internal issue we had been working on, I instructed folks to post comments/feedback to this issue. We have two choices

    1. Address group chats in this GH and figure out what we want before posting the job.
    2. Only focus on the single DM usecase for now and address groups later.
  5. Santhosh-Sellavel commented on Aug 16, 2021

    @Santhosh-Sellavel
    Collaborator

    Is this going to be external? @mallenexpensify
    If it's I'm interest then.

    An overview of implementation details,

    • Will create a new component to show the required details.
    • Will use component instead of current textview, which shows 'be first to comment' in ReportActionsView.js
    • And add relevant styles or reuse available styles.
    • Also change placeholder text in chat input.
  6. mallenexpensify commented on Aug 16, 2021

    @mallenexpensify
    ContributorAuthor

    It will very likely be external @Santhosh-Sellavel , @michaelhaxhiu needs to triage the issue first, part of that is figuring out what we want to do about group messages. My hunch is it's best to fix this issue specifically for the 1:1 DM usecase now then create a new issue in the future to address both group messages and possibly rooms.

    @michaelhaxhiu, this shouldn't require a designer, an engineer should be able to take care of everything

  7. rosegrech commented on Aug 16, 2021

    @rosegrech

    Great question about the group. I want to say lets work on how the 1:1 looks like and then probably handle the group in a new GH to keep things neat and tidy. I'd love to say whatever we use for 1:1 will work for the group but ard to say that as of now :)

  8. shawnborton commented on Aug 17, 2021

    @shawnborton
    Contributor

    @megankelso @michelle-thompson I vaguely recall that we explored what this screen would look like for various use cases... actually I think it was @michelle-thompson that did it for Concierge Travel.

    So basically we could do something like this?
    image

    And maybe before we have those features ready to go, we could just use a generic message for the group situation like so:
    image

    And then in terms of scalability, looks like Michelle had mocked up something like this for when a group has lots of participants:
    image

  9. michelle-thompson commented on Aug 17, 2021

    @michelle-thompson
    Contributor

    Cool, happy to move forward with the generic messaging you've mocked up above!

  10. shawnborton commented on Aug 17, 2021

    @shawnborton
    Contributor

    Sweet, so I think maybe we want to make the avatars in my mockup a bit smaller like your original mocks (the one at the bottom) for scalability purposes. Otherwise, then I think we just need to decide if we're going to add Group chats to the exported Upwork issue?

  11. michelle-thompson commented on Aug 17, 2021

    @michelle-thompson
    Contributor

    Ahh, you mean so the size of the avatar never has to change? And I figure might as well add group chats to this issue.

  12. shawnborton commented on Aug 17, 2021

    @shawnborton
    Contributor

    Yeah, I think I like the size you had here:
    image

    ...better than the larger size I used. So that gives us something like this:
    image

  13. 141 remaining items

  14. MirFahad58 commented on Nov 18, 2021

    @MirFahad58
    Contributor

    @michaelhaxhiu let me correct, the 250 that was paid, was not of n6-hold bonus it was half of $500 from jobs. Thanks
    that's why i added a milestone for n6-hold

    Screenshot 2021-11-18 at 11 21 01 PM

  15. michaelhaxhiu commented on Nov 18, 2021

    @michaelhaxhiu
    Contributor

    Ok so it sounds like you are saying:

    1. The $250 that was already paid was for your initial work ✅
    2. The $250 n6 hold bonus hasn't been sent yet, and you are requesting that be sent today
    3. Finally, we owe $250 for the increased scope of work, which will be paid in 6 days.

    Is that right?

  16. MirFahad58 commented on Nov 18, 2021

    @MirFahad58
    Contributor

    right

  17. michaelhaxhiu commented on Nov 18, 2021

    @michaelhaxhiu
    Contributor

    Ok got it. I think that is fine, I'll issue the $250 payment now.

    Then, you'll receive the remaining $250 on November 25.

    Note: our milestones aren't named correctly, but thats ok because they are in $250 incraments.

  18. MirFahad58 commented on Nov 18, 2021

    @MirFahad58
    Contributor

    yup thanks

  19. changed the title [-]Update "Be the first person to comment!" screen when you start a new DM [/-] [+][HOLD for payment 2021-11-25] Update "Be the first person to comment!" screen when you start a new DM [/+] on Nov 18, 2021
  20. mallenexpensify commented on Nov 25, 2021

    @mallenexpensify
    ContributorAuthor

    Paid final $250 to @MirFahad58 , thanks for the help and patience.

  21. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Nov 29, 2021
  22. changed the title [-][HOLD for payment 2021-11-25] Update "Be the first person to comment!" screen when you start a new DM [/-] [+][HOLD for payment 2021-12-06] [HOLD for payment 2021-11-25] Update "Be the first person to comment!" screen when you start a new DM [/+] on Nov 29, 2021
  23. botify commented on Nov 29, 2021

    @botify

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.16-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2021-12-06. 🎊

  24. melvin-bot commented on Aug 25, 2022

    @melvin-bot

    ⚠️ Looks like this issue was linked to a possible regression on PRODUCTION here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  25. melvin-bot commented on Sep 2, 2022

    @melvin-bot

    ⚠️ Looks like this issue was linked to a possible regression on PRODUCTION here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions