You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-08-19] [HOLD for payment 2024-08-14] Distance - App crashes when submitting distance expense and editing distance offline #46874
Version Number: 9.0.17-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers):applausetester+kh05081@applause.expensifail.com Issue reported by: Applause - Internal Team
Action Performed:
Go to staging.new.expensify.com
Go to workspace chat
Go offline
Submit a distance expense
Go to transaction thread
Click Distance
Change the waypoints (by exchanging position)
Save it
Expected Result:
App will not crash
Actual Result:
App crashes when submitting distance expense and editing distance offline
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
convertToDisplayString() seems to be receiving 'Pending...' as a currency, which probably happens after editing the expense offline. I can dig deeper into it if that's ok.
That's probably unrelated to this particular bug, but I'm also getting double workspaces after creating a new one 🤔
changed the title [-][HOLD for payment 2024-08-14] Distance - App crashes when submitting distance expense and editing distance offline[/-][+][HOLD for payment 2024-08-19] [HOLD for payment 2024-08-14] Distance - App crashes when submitting distance expense and editing distance offline[/+]on Aug 12, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.18-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
Issue is ready for payment but no BZ is assigned. @stephanieelliott you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!
Activity
melvin-bot commentedon Aug 6, 2024
Triggered auto assignment to @grgia (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Aug 6, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
BrtqKr commentedon Aug 6, 2024
convertToDisplayString()seems to be receiving 'Pending...' as a currency, which probably happens after editing the expense offline. I can dig deeper into it if that's ok.That's probably unrelated to this particular bug, but I'm also getting double workspaces after creating a new one 🤔
grgia commentedon Aug 6, 2024
#46165
#40021
could be related. It does seem like ^ is the issue
grgia commentedon Aug 6, 2024
@BrtqKr maybe https://github.com/Expensify/App/blob/main/src/components/ReportActionItem/MoneyRequestPreview/MoneyRequestPreviewContent.tsx#L255-L257
paultsimura commentedon Aug 6, 2024
Ohh, this is a regression from my PR. Will spin up a fix now.
grgia commentedon Aug 6, 2024
Assigning @paultsimura!
12 remaining items
[-][HOLD for payment 2024-08-14] Distance - App crashes when submitting distance expense and editing distance offline[/-][+][HOLD for payment 2024-08-19] [HOLD for payment 2024-08-14] Distance - App crashes when submitting distance expense and editing distance offline[/+]melvin-bot commentedon Aug 12, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.18-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-08-19. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Aug 19, 2024
Issue is ready for payment but no BZ is assigned. @stephanieelliott you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!
melvin-bot commentedon Aug 19, 2024
Payment Summary
Upwork Job
BugZero Checklist (@stephanieelliott)
paultsimura commentedon Aug 19, 2024
No payment here - it was a regression fix.