Skip to content

[HOLD for payment 2024-08-19] [HOLD for payment 2024-08-14] Distance - App crashes when submitting distance expense and editing distance offline #46874

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.17-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+kh05081@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat
  3. Go offline
  4. Submit a distance expense
  5. Go to transaction thread
  6. Click Distance
  7. Change the waypoints (by exchanging position)
  8. Save it

Expected Result:

App will not crash

Actual Result:

App crashes when submitting distance expense and editing distance offline

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6563090_1722927597481.20240806_145640.mp4

logs (2).txt

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    DeployBlockerIndicates it should block deploying the API
    on Aug 6, 2024
  2. melvin-bot commented on Aug 6, 2024

    @melvin-bot

    Triggered auto assignment to @grgia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. github-actions commented on Aug 6, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. BrtqKr commented on Aug 6, 2024

    @BrtqKr
    Contributor

    convertToDisplayString() seems to be receiving 'Pending...' as a currency, which probably happens after editing the expense offline. I can dig deeper into it if that's ok.

    That's probably unrelated to this particular bug, but I'm also getting double workspaces after creating a new one 🤔

  5. grgia commented on Aug 6, 2024

    @grgia
    Contributor

    #46165
    #40021

    could be related. It does seem like ^ is the issue

  6. paultsimura commented on Aug 6, 2024

    @paultsimura
    Contributor

    Ohh, this is a regression from my PR. Will spin up a fix now.

  7. grgia commented on Aug 6, 2024

    @grgia
    Contributor

    Assigning @paultsimura!

  8. removed
    DeployBlockerIndicates it should block deploying the API
    on Aug 6, 2024
  9. 12 remaining items

  10. changed the title [-][HOLD for payment 2024-08-14] Distance - App crashes when submitting distance expense and editing distance offline[/-] [+][HOLD for payment 2024-08-19] [HOLD for payment 2024-08-14] Distance - App crashes when submitting distance expense and editing distance offline[/+] on Aug 12, 2024
  11. melvin-bot commented on Aug 12, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.18-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-08-19. 🎊

    For reference, here are some details about the assignees on this issue:

    • @mananjadhav requires payment through NewDot Manual Requests
    • @paultsimura requires payment (Needs manual offer from BZ)
  12. melvin-bot commented on Aug 19, 2024

    @melvin-bot

    Issue is ready for payment but no BZ is assigned. @stephanieelliott you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

  13. melvin-bot commented on Aug 19, 2024

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@stephanieelliott)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  14. paultsimura commented on Aug 19, 2024

    @paultsimura
    Contributor

    No payment here - it was a regression fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions