You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] Search - Esc key does not close the search dialog after navigating to search filters #46915
Version Number: 9.0.17-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers):dave0123seife@gmail.com Issue reported by: Applause - Internal Team
@muttmuure FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
Please re-state the problem that we are trying to solve in this issue.
Pressing ESC doesn't close the search filter RHP page.
What is the root cause of that problem?
This issue happens to every RHP in search or settings page IF the user refresh while on the search/settings page or directly access the page through url.
The reason is that the ESC key shortcut to close RHP is subscribed in SidebarLinks component.
When we directly access search/settings page or refresh, the SidebarLinks component (HOME screen) is not mounted yet (not in the nav stack yet). So, the ESC key shortcut is not available.
What changes do you think we should make in order to solve the problem?
Moves the subscription from SidebarLinks to AuthScreen, just like the other shortcuts we put there.
changed the title [-]Search - Esc key does not close the search dialog after navigating to search filters[/-][+][$250] Search - Esc key does not close the search dialog after navigating to search filters[/+]on Aug 19, 2024
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
Activity
melvin-bot commentedon Aug 6, 2024
Triggered auto assignment to @muttmuure (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.lanitochka17 commentedon Aug 6, 2024
@muttmuure FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
bernhardoj commentedon Aug 7, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Pressing ESC doesn't close the search filter RHP page.
What is the root cause of that problem?
This issue happens to every RHP in search or settings page IF the user refresh while on the search/settings page or directly access the page through url.
The reason is that the ESC key shortcut to close RHP is subscribed in SidebarLinks component.
App/src/pages/home/sidebar/SidebarLinks.tsx
Lines 74 to 92 in de89479
When we directly access search/settings page or refresh, the SidebarLinks component (HOME screen) is not mounted yet (not in the nav stack yet). So, the ESC key shortcut is not available.
What changes do you think we should make in order to solve the problem?
Moves the subscription from SidebarLinks to AuthScreen, just like the other shortcuts we put there.
App/src/libs/Navigation/AppNavigator/AuthScreens.tsx
Lines 275 to 321 in de89479
melvin-bot commentedon Aug 12, 2024
@muttmuure Huh... This is 4 days overdue. Who can take care of this?
melvin-bot commentedon Aug 14, 2024
@muttmuure Still overdue 6 days?! Let's take care of this!
melvin-bot commentedon Aug 16, 2024
@muttmuure 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!
[-]Search - Esc key does not close the search dialog after navigating to search filters[/-][+][$250] Search - Esc key does not close the search dialog after navigating to search filters[/+]melvin-bot commentedon Aug 19, 2024
Job added to Upwork: https://www.upwork.com/jobs/~0101567775c1fa8061
20 remaining items
JmillsExpensify commentedon Sep 16, 2024
$250 approved for @bernhardoj
melvin-bot commentedon Sep 26, 2024
@AndrewGable, @akinwale, @muttmuure, @bernhardoj Whoops! This issue is 2 days overdue. Let's get this updated quick!
melvin-bot commentedon Sep 30, 2024
@AndrewGable, @akinwale, @muttmuure, @bernhardoj 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
melvin-bot commentedon Oct 2, 2024
@AndrewGable, @akinwale, @muttmuure, @bernhardoj Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!
melvin-bot commentedon Oct 4, 2024
@AndrewGable, @akinwale, @muttmuure, @bernhardoj 10 days overdue. Is anyone even seeing these? Hello?
melvin-bot commentedon Oct 9, 2024
This issue has not been updated in over 14 days. @AndrewGable, @akinwale, @muttmuure, @bernhardoj eroding to Weekly issue.
melvin-bot commentedon Nov 1, 2024
This issue has not been updated in over 15 days. @AndrewGable, @akinwale, @muttmuure, @bernhardoj eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
akinwale commentedon Dec 11, 2024
@muttmuure I believe this can be closed.