You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[PAY AUG 22ND][$250] Search-Skeleton during loading & in empty state are aligned differently compared to production #46949
Version Number: 9.0.17-1 Reproducible in staging?: Y Reproducible in production?: N Email or phone of affected tester (no customers):applausetester+kh050806@applause.expensifail.com Issue reported by: Applause Internal Team
Action Performed:
Go to staging.new.expensify.com
Create a new workspace.
Go back to Inbox.
Open workspace switcher and select the new workspace.
Go to Search.
Navigate through the empty Search sections to check how the skeleton during loading and the skeleton in empty state are aligned differently on staging and production.
Expected Result:
The skeleton during loading and the skeleton in empty state should have similar alignment (only slight deviation on production).
Actual Result:
The skeleton during loading and the skeleton in empty state has larger deviation in alignment compared to production.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-][$250] Search-Skeleton during loading & in empty state are aligned differently compared to production[/-][+][PAY AUG 22ND][$250] Search-Skeleton during loading & in empty state are aligned differently compared to production[/+]on Aug 19, 2024
@luacmartins@jliexpensify@rayane-djouah@Guccio163 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Author and reviewers are already aware: Empty State Component for Search #44137 (comment)
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug. Yes
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Regression Test Proposal
Create a new workspace
Submit an expense in your workspace report
Go to settings > troubleshoot > clear cache and restart
Use a slow internet connection
Open the search page
Verify that the loading view skeleton has a 20px horizontal padding
When the results load, Verify that the results view has a 20px horizontal padding
Change the search filter to get an empty state view
Verify that the loading empty state view skeleton has a 20px horizontal padding
The horizontal padding should be consistent across the three views
Activity
melvin-bot commentedon Aug 7, 2024
Triggered auto assignment to @luacmartins (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Aug 7, 2024
Triggered auto assignment to @jliexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.IuliiaHerets commentedon Aug 7, 2024
We think that this bug might be related to #vip-vsb
github-actions commentedon Aug 7, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
nyomanjyotisa commentedon Aug 7, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Skeleton during loading & in empty state are aligned differently compared to production
What is the root cause of that problem?
The margin of the skeleton view not properly set
What changes do you think we should make in order to solve the problem?
Add proper margin here to make it consistent to the empty state
OR
RESULT
New-Expensify.27.mp4
What alternative solutions did you explore? (Optional)
trjExpensify commentedon Aug 7, 2024
@shawnborton confirming with you the correct expectation here so we can move this forward.
46 remaining items
rayane-d commentedon Aug 15, 2024
PR on staging
rayane-d commentedon Aug 16, 2024
PR deployed to production yesterday #47164 (comment)
[-][$250] Search-Skeleton during loading & in empty state are aligned differently compared to production[/-][+][PAY AUG 22ND][$250] Search-Skeleton during loading & in empty state are aligned differently compared to production[/+]jliexpensify commentedon Aug 19, 2024
Thanks for the heads up!
Payment Summary:
https://www.upwork.com/jobs/~011af2fbb0ab06fc24
melvin-bot commentedon Aug 21, 2024
@luacmartins @jliexpensify @rayane-djouah @Guccio163 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
jliexpensify commentedon Aug 21, 2024
@rayane-djouah is a checklist needed for this?
rayane-d commentedon Aug 22, 2024
Checklist
Regression Test Proposal
Do we agree 👍 or 👎
cc @jliexpensify
jliexpensify commentedon Aug 23, 2024
Paid and job closed