Skip to content

[PAY AUG 22ND][$250] Search-Skeleton during loading & in empty state are aligned differently compared to production #46949

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.17-1
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Create a new workspace.
  3. Go back to Inbox.
  4. Open workspace switcher and select the new workspace.
  5. Go to Search.
  6. Navigate through the empty Search sections to check how the skeleton during loading and the skeleton in empty state are aligned differently on staging and production.

Expected Result:

The skeleton during loading and the skeleton in empty state should have similar alignment (only slight deviation on production).

Actual Result:

The skeleton during loading and the skeleton in empty state has larger deviation in alignment compared to production.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6564170_1723020514064.20240807_164018.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~011af2fbb0ab06fc24
  • Upwork Job ID: 1821143733082880779
  • Last Price Increase: 2024-08-07
  • Automatic offers:
    • rayane-djouah | Contributor | 103432889
Issue OwnerCurrent Issue Owner: @jayeshmangwani

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Aug 7, 2024
  2. melvin-bot commented on Aug 7, 2024

    @melvin-bot

    Triggered auto assignment to @luacmartins (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Aug 7, 2024

    @melvin-bot

    Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. IuliiaHerets commented on Aug 7, 2024

    @IuliiaHerets
    Author

    We think that this bug might be related to #vip-vsb

  5. github-actions commented on Aug 7, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. nyomanjyotisa commented on Aug 7, 2024

    @nyomanjyotisa
    Member

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Skeleton during loading & in empty state are aligned differently compared to production

    What is the root cause of that problem?

    The margin of the skeleton view not properly set

    What changes do you think we should make in order to solve the problem?

    Add proper margin here to make it consistent to the empty state

    style={[themeStyles.flex1, themeStyles.overflowHidden, themeStyles.m2, themeStyles.mt3]}
    

    OR

    style={[themeStyles.flex1, themeStyles.overflowHidden, themeStyles.mt3, themeStyles.mb2, themeStyles.mr2, themeStyles.ml2]}
    

    RESULT

    New-Expensify.27.mp4

    What alternative solutions did you explore? (Optional)

  7. trjExpensify commented on Aug 7, 2024

    @trjExpensify
    Contributor

    @shawnborton confirming with you the correct expectation here so we can move this forward.

  8. 46 remaining items

  9. rayane-d commented on Aug 15, 2024

    @rayane-d
    Contributor

    PR on staging

  10. rayane-d commented on Aug 16, 2024

    @rayane-d
    Contributor

    PR deployed to production yesterday #47164 (comment)

  11. changed the title [-][$250] Search-Skeleton during loading & in empty state are aligned differently compared to production[/-] [+][PAY AUG 22ND][$250] Search-Skeleton during loading & in empty state are aligned differently compared to production[/+] on Aug 19, 2024
  12. jliexpensify commented on Aug 19, 2024

    @jliexpensify
    Contributor

    Thanks for the heads up!

    Payment Summary:

    https://www.upwork.com/jobs/~011af2fbb0ab06fc24

  13. melvin-bot commented on Aug 21, 2024

    @melvin-bot

    @luacmartins @jliexpensify @rayane-djouah @Guccio163 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  14. jliexpensify commented on Aug 21, 2024

    @jliexpensify
    Contributor

    @rayane-djouah is a checklist needed for this?

  15. rayane-d commented on Aug 22, 2024

    @rayane-d
    Contributor

    Checklist

    • The PR that introduced the bug has been identified. Link to the PR: Empty State Component for Search #44137
    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Author and reviewers are already aware: Empty State Component for Search #44137 (comment)
    • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
    • Determine if we should create a regression test for this bug. Yes
    • If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    Regression Test Proposal

    1. Create a new workspace
    2. Submit an expense in your workspace report
    3. Go to settings > troubleshoot > clear cache and restart
    4. Use a slow internet connection
    5. Open the search page
    6. Verify that the loading view skeleton has a 20px horizontal padding
    7. When the results load, Verify that the results view has a 20px horizontal padding
    8. Change the search filter to get an empty state view
    9. Verify that the loading empty state view skeleton has a 20px horizontal padding
    10. The horizontal padding should be consistent across the three views

    Do we agree 👍 or 👎

    cc @jliexpensify

  16. jliexpensify commented on Aug 23, 2024

    @jliexpensify
    Contributor

    Paid and job closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions