You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Awaiting payment] [$125] [P2P Distance] Dupe detection - Distance rate is editable on the confirmation page #46954
Version Number: v9.0.17-1 Reproducible in staging?: Y Reproducible in production?: N Email or phone of affected tester (no customers):applausetester+kh050806@applause.expensifail.com Issue reported by: Applause Internal Team
Action Performed:
Go to staging.new.expensify.com
Go to workspace chat.
Submit two same distance expenses.
Go to transaction thread of any submitted expense.
Click Review duplicates.
Click Keep this one (any).
Proceed to confirmation page.
Click Rate.
Expected Result:
Distance rate should not be editable on the confirmation page (like other fields).
Actual Result:
Distance rate is editable on the confirmation page.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-][$125] [P2P Distance] Dupe detection - Distance rate is editable on the confirmation page[/-][+][Awaiting payment] [$125] [P2P Distance] Dupe detection - Distance rate is editable on the confirmation page[/+]on Sep 3, 2024
Activity
melvin-bot commentedon Aug 7, 2024
Triggered auto assignment to @sakluger (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Aug 7, 2024
Triggered auto assignment to @pecanoro (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Aug 7, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
IuliiaHerets commentedon Aug 7, 2024
We think that this bug might be related to #wave-collect - Release 2
etCoderDysto commentedon Aug 7, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Distance rate is editable on the confirmation page
What is the root cause of that problem?
In
MoneyRequestviewwe are only checkingcanEditDistanceRateprop before we are making the button interactive and displaying right iconApp/src/components/ReportActionItem/MoneyRequestView.tsx
Lines 349 to 353 in 2c60fc9
What changes do you think we should make in order to solve the problem?
We should check for readonly prop too
Note: We can check other menuItems on MoneyRequestView and apply the change to prevent this issue happening on other menu items
What alternative solutions did you explore? (Optional)
etCoderDysto commentedon Aug 7, 2024
I can raise a quick PR if needed.
38 remaining items
ishpaul777 commentedon Sep 3, 2024
Ready for payment 🎉
[-][$125] [P2P Distance] Dupe detection - Distance rate is editable on the confirmation page[/-][+][Awaiting payment] [$125] [P2P Distance] Dupe detection - Distance rate is editable on the confirmation page[/+]sakluger commentedon Sep 3, 2024
Summarizing payment on this issue:
Contributor: @dominictb $125, paid via Upwork
Contributor+: @ishpaul777 $125, paid via Upwork
@ishpaul777 do we need regression steps or are we good as is?
melvin-bot commentedon Sep 4, 2024
@sakluger @pecanoro @ishpaul777 @dominictb this issue is now 4 weeks old, please consider:
Thanks!
sakluger commentedon Sep 4, 2024
Friendly bump @ishpaul777 I think we may need a regression test for this one.
ishpaul777 commentedon Sep 4, 2024
Regression Test proposal
Expected Result:
There should not be any field that is editable. All fields should be read only
Do we agree 👍 or 👎
sakluger commentedon Sep 4, 2024
Looks great, thanks!