Skip to content

[Awaiting payment] [$125] [P2P Distance] Dupe detection - Distance rate is editable on the confirmation page #46954

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.0.17-1
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Submit two same distance expenses.
  4. Go to transaction thread of any submitted expense.
  5. Click Review duplicates.
  6. Click Keep this one (any).
  7. Proceed to confirmation page.
  8. Click Rate.

Expected Result:

Distance rate should not be editable on the confirmation page (like other fields).

Actual Result:

Distance rate is editable on the confirmation page.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6564241_1723024220501.20240807_174747.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01aa94659fe7b3028a
  • Upwork Job ID: 1821151696845785168
  • Last Price Increase: 2024-08-07
  • Automatic offers:
    • ishpaul777 | Reviewer | 103588098
    • dominictb | Contributor | 103588104

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Aug 7, 2024
  2. melvin-bot commented on Aug 7, 2024

    @melvin-bot

    Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Aug 7, 2024

    @melvin-bot

    Triggered auto assignment to @pecanoro (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. github-actions commented on Aug 7, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. IuliiaHerets commented on Aug 7, 2024

    @IuliiaHerets
    Author

    We think that this bug might be related to #wave-collect - Release 2

  6. etCoderDysto commented on Aug 7, 2024

    @etCoderDysto
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Distance rate is editable on the confirmation page

    What is the root cause of that problem?

    In MoneyRequestview we are only checking canEditDistanceRate prop before we are making the button interactive and displaying right icon

    <MenuItemWithTopDescription
    description={translate('common.rate')}
    title={rateToDisplay}
    interactive={canEditDistanceRate}
    shouldShowRightIcon={canEditDistanceRate}

    What changes do you think we should make in order to solve the problem?

    We should check for readonly prop too

    interactive={canEditDistanceRate && !readonly}
    shouldShowRightIcon={canEditDistanceRate && !readonly}

    Note: We can check other menuItems on MoneyRequestView and apply the change to prevent this issue happening on other menu items

    What alternative solutions did you explore? (Optional)

  7. etCoderDysto commented on Aug 7, 2024

    @etCoderDysto
    Contributor

    I can raise a quick PR if needed.

  8. 38 remaining items

  9. ishpaul777 commented on Sep 3, 2024

    @ishpaul777
    Contributor

    Ready for payment 🎉

  10. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed
    ReviewingHas a PR in review
    on Sep 3, 2024
  11. changed the title [-][$125] [P2P Distance] Dupe detection - Distance rate is editable on the confirmation page[/-] [+][Awaiting payment] [$125] [P2P Distance] Dupe detection - Distance rate is editable on the confirmation page[/+] on Sep 3, 2024
  12. sakluger commented on Sep 3, 2024

    @sakluger
    Contributor

    Summarizing payment on this issue:

    Contributor: @dominictb $125, paid via Upwork
    Contributor+: @ishpaul777 $125, paid via Upwork

    @ishpaul777 do we need regression steps or are we good as is?

  13. melvin-bot commented on Sep 4, 2024

    @melvin-bot

    @sakluger @pecanoro @ishpaul777 @dominictb this issue is now 4 weeks old, please consider:

    • Finding a contributor to fix the bug
    • Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
    • If you have any questions, don't hesitate to start a discussion in #expensify-open-source

    Thanks!

  14. sakluger commented on Sep 4, 2024

    @sakluger
    Contributor

    Friendly bump @ishpaul777 I think we may need a regression test for this one.

  15. ishpaul777 commented on Sep 4, 2024

    @ishpaul777
    Contributor

    Regression Test proposal

    1. Go to newdot
    2. Go to workspace chat.
    3. Submit two same distance expenses.
    4. Go to transaction thread of any submitted expense.
    5. Click Review duplicates.
    6. Click Keep this one (any).
    7. Proceed to confirmation page.

    Expected Result:
    There should not be any field that is editable. All fields should be read only

    Do we agree 👍 or 👎

  16. sakluger commented on Sep 4, 2024

    @sakluger
    Contributor

    Looks great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions