You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[payment due 8-27][$250] Expense - Mark as cash button only appears in combined report after refreshing the page #47084
Click on the expense preview in the main chat to go to expense report
Right click on the expense submitted in Step 4 > Delete expense
Delete the expense in Step 4
Note that the combined report shows payment button instead of Mark as cash button
Refresh the page
Expected Result:
In Step 8, the combined report should display Mark as cash button after the other expense is deleted
Actual Result:
In Step 8, the combined report still displays payment button after the other expense is deleted
Mark as cash button only appears in the combined report after the report is refreshed (Step 9)
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
@Christinadobrzyn FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
Please re-state the problem that we are trying to solve in this issue.
In Step 8, the combined report still displays payment button after the other expense is deleted
Mark as cash button only appears in the combined report after the report is refreshed (Step 9)
What is the root cause of that problem?
The Mask as cash button is displayed if all transactions have RTER Violation.
changed the title [-][$250] Expense - Mark as cash button only appears in combined report after refreshing the page[/-][+][payment due 8-27][$250] Expense - Mark as cash button only appears in combined report after refreshing the page[/+]on Aug 27, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
[@parasharrajat] Determine if we should create a regression test for this bug. Yes
[@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Regression Test Steps
Go to the report has Mark as cash button
Submit another expense
Click on the expense preview in the main chat to go to expense report
Right click on the expense submitted in Step 2 > Delete expense
Delete the expense in Step 2
Verify that: the combined report should display Mark as cash button after the other expense is deleted
Activity
melvin-bot commentedon Aug 8, 2024
Triggered auto assignment to @Christinadobrzyn (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.lanitochka17 commentedon Aug 8, 2024
@Christinadobrzyn FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
lanitochka17 commentedon Aug 8, 2024
We think that this bug might be related to #wave-collect - Release 1
nkdengineer commentedon Aug 8, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
In Step 8, the combined report still displays payment button after the other expense is deleted
Mark as cash button only appears in the combined report after the report is refreshed (Step 9)
What is the root cause of that problem?
The
Mask as cashbutton is displayed if all transactions have RTER Violation.App/src/components/MoneyReportHeader.tsx
Line 306 in e748661
App/src/components/MoneyReportHeader.tsx
Line 109 in e748661
When we delete a transaction,
allTransactionsisn't updated because the dependency is onlymoneyRequestReport?.reportIDApp/src/components/MoneyReportHeader.tsx
Line 101 in e748661
Then
allHavePendingRTERViolationisfalseandMask as cashbutton doesn't appear until we refresh the pageWhat changes do you think we should make in order to solve the problem?
We should add
transactionshere as a dependency of theuseMemohere as we do forReportPreviewhereApp/src/components/MoneyReportHeader.tsx
Line 101 in e748661
What alternative solutions did you explore? (Optional)
trjExpensify commentedon Aug 9, 2024
wave-control project for pending card receipts. CC: @yuwenmemon @JmillsExpensify
Christinadobrzyn commentedon Aug 12, 2024
I assume this needs to be internal but we'll add a C+ to see what they think is best.
15 remaining items
Christinadobrzyn commentedon Aug 20, 2024
PR is in staging so getting close!
[-][$250] Expense - Mark as cash button only appears in combined report after refreshing the page[/-][+][payment due 8-27][$250] Expense - Mark as cash button only appears in combined report after refreshing the page[/+]Christinadobrzyn commentedon Aug 27, 2024
Payment didn't trigger for this one. Looks like this can be paid today.
Payouts due:
Do we need a regression test for this?
code update
parasharrajat commentedon Aug 27, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
Regression Test Steps
Do you agree 👍 or 👎 ?
Christinadobrzyn commentedon Aug 28, 2024
Regression test - https://github.com/Expensify/Expensify/issues/424176
Paid out based on this payment summary . Closing!
parasharrajat commentedon Aug 30, 2024
Payment requested as per #47084 (comment)
JmillsExpensify commentedon Sep 2, 2024
$250 approved for @parasharrajat