You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Android - Left half of the new message badge is unresponsive #4716
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
I see that there is a limitation on the Android where the touch area never extends beyond the parent View. I am looking into ways to redesign it so that it receives the touch.
OK. then I think we have to change the design for Android.
I have an initial draft of what can be done for android but I look more to see what is best. The main motive of this design strategy was to allow the badge to grow as much as it needs while keeping the side areas of it to be available to underneath messages. So that click can activate the menu over messages.
I can calculate the left position based on the badge but that will create a delay as we have to calculate it before rendering it. Let's see what is best.
Activity
MelvinBot commentedon Aug 17, 2021
Triggered auto assignment to @madmax330 (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.isagoico commentedon Aug 17, 2021
Issue is not reproducible in iOS, button is fully responsive.
OSBotify commentedon Aug 17, 2021
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:parasharrajat commentedon Aug 18, 2021
I see that there is a limitation on the Android where the touch area never extends beyond the parent View. I am looking into ways to redesign it so that it receives the touch.
parasharrajat commentedon Aug 18, 2021
@isagoico Could you please confirm that this is only occurring on Android?
isagoico commentedon Aug 18, 2021
Just retested in iOS and the button is fully responsive there. Only reproducible in Android.
parasharrajat commentedon Aug 18, 2021
OK. then I think we have to change the design for Android.
I have an initial draft of what can be done for android but I look more to see what is best. The main motive of this design strategy was to allow the badge to grow as much as it needs while keeping the side areas of it to be available to underneath messages. So that click can activate the menu over messages.
I can calculate the left position based on the badge but that will create a delay as we have to calculate it before rendering it. Let's see what is best.
parasharrajat commentedon Aug 19, 2021
Let me know guys, if you want me to fix this. The solution is ready.
parasharrajat commentedon Aug 21, 2021
I have gone ahead pushed a PR to fix this deploy blocker. Is this issue going to be exported?
Consent taken https://expensify.slack.com/archives/C01GTK53T8Q/p1629494267085300.
17 remaining items
jliexpensify commentedon Aug 25, 2021
Correct, haven't paid Rajat yet :)
Beamanator commentedon Aug 26, 2021
Ok cool thanks for confirming :)
Beamanator commentedon Aug 30, 2021
Assigning Rajat since he should have been assigned earlier :D
Exportedsince we have an Upwork job for thisjliexpensify commentedon Sep 2, 2021
Paying Rajat now and closing, cheers!