Skip to content

Android - Left half of the new message badge is unresponsive  #4716

Closed

Description

@isagoico

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue is failing #4603 on Android

Action Performed:

  1. Navigate to a conversation with user A
  2. Scroll up the conversation
  3. As user A send some messages
  4. Tap on the left area of the new message badge
    image

Expected Result:

Whole badge area should be tappable.

Actual Result:

Left half of the new message badge is unresponsive.

Workaround:

User has to tap the middle or the right area to trigger the button.

Platform:

Where is this issue occurring?

  • Android

Version Number: 1.0.86-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

WhatsApp.Video.2021-08-17.at.7.25.10.PM.mp4

Expensify/Expensify Issue URL:

View all open jobs on GitHub

Activity

  1. MelvinBot commented on Aug 17, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @madmax330 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  2. isagoico commented on Aug 17, 2021

    @isagoico
    Author

    Issue is not reproducible in iOS, button is fully responsive.

  3. OSBotify commented on Aug 17, 2021

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. parasharrajat commented on Aug 18, 2021

    @parasharrajat
    Member

    I see that there is a limitation on the Android where the touch area never extends beyond the parent View. I am looking into ways to redesign it so that it receives the touch.

  5. parasharrajat commented on Aug 18, 2021

    @parasharrajat
    Member

    @isagoico Could you please confirm that this is only occurring on Android?

  6. isagoico commented on Aug 18, 2021

    @isagoico
    Author

    Just retested in iOS and the button is fully responsive there. Only reproducible in Android.

  7. parasharrajat commented on Aug 18, 2021

    @parasharrajat
    Member

    OK. then I think we have to change the design for Android.
    I have an initial draft of what can be done for android but I look more to see what is best. The main motive of this design strategy was to allow the badge to grow as much as it needs while keeping the side areas of it to be available to underneath messages. So that click can activate the menu over messages.

    I can calculate the left position based on the badge but that will create a delay as we have to calculate it before rendering it. Let's see what is best.

  8. parasharrajat commented on Aug 19, 2021

    @parasharrajat
    Member

    Let me know guys, if you want me to fix this. The solution is ready.

  9. parasharrajat commented on Aug 21, 2021

    @parasharrajat
    Member

    I have gone ahead pushed a PR to fix this deploy blocker. Is this issue going to be exported?
    Consent taken https://expensify.slack.com/archives/C01GTK53T8Q/p1629494267085300.

  10. 17 remaining items

  11. jliexpensify commented on Aug 25, 2021

    @jliexpensify
    Contributor

    Correct, haven't paid Rajat yet :)

  12. Beamanator commented on Aug 26, 2021

    @Beamanator
    Contributor

    Ok cool thanks for confirming :)

  13. Beamanator commented on Aug 30, 2021

    @Beamanator
    Contributor

    Assigning Rajat since he should have been assigned earlier :D

    • Also adding Exported since we have an Upwork job for this
  14. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Aug 30, 2021
  15. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Aug 30, 2021
  16. jliexpensify commented on Sep 2, 2021

    @jliexpensify
    Contributor

    Paying Rajat now and closing, cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions