You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for Payment 2024-09-06] [$250] Android - Room - Anyone can find this room dialog box is shown briefly after tapping Yes #47262
@garrettmknight FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
In visibility Page we will set a ref navigateToDetails to true after calling updateRoomVisibility then in onModalHide we will call the navigation (if the ref is true) ReportUtils.goBackToDetailsPage(report) we are now calling in updateRoomVisibility and if the ref is false we only call dismissModal
changed the title [-]Android - Room - Anyone can find this room dialog box is shown briefly after tapping `Yes`[/-][+][$250] Android - Room - Anyone can find this room dialog box is shown briefly after tapping `Yes`[/+]on Aug 14, 2024
📣 @FitseTLT 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖
changed the title [-][$250] Android - Room - Anyone can find this room dialog box is shown briefly after tapping `Yes`[/-][+][HOLD for Payment 2024-09-06] [$250] Android - Room - Anyone can find this room dialog box is shown briefly after tapping `Yes`[/+]on Sep 3, 2024
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug. Yes
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Regression Test Proposal
Open any room that is not "Public".
Tap header > Settings > Visibility > select "Public".
On the confirm modal Tap "Yes".
Verify that the modal is closed and you are navigated to the settings page and the confirm modal doesn't appear briefly on the settings page.
Activity
melvin-bot commentedon Aug 12, 2024
Triggered auto assignment to @garrettmknight (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.IuliiaHerets commentedon Aug 12, 2024
We think that this bug might be related to #vip-vsb
IuliiaHerets commentedon Aug 12, 2024
@garrettmknight FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
FitseTLT commentedon Aug 12, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Android - Room - Anyone can find this room dialog box is shown briefly after tapping Yes
What is the root cause of that problem?
After change visibility we are navigating back to details page here
App/src/libs/actions/Report.ts
Lines 1752 to 1753 in cc2efc6
But the navigation happens to soon before the modal is dismissed so the modal reappears after the navigation
What changes do you think we should make in order to solve the problem?
Just the same as we fixed similar bug here
App/src/pages/ReportDetailsPage.tsx
Lines 796 to 800 in cc2efc6
In visibility Page we will set a ref
navigateToDetailsto true after callingupdateRoomVisibilitythen in onModalHide we will call the navigation (if the ref is true)ReportUtils.goBackToDetailsPage(report)we are now calling in updateRoomVisibility and if the ref is false we only call dismissModalWhat alternative solutions did you explore? (Optional)
daledah commentedon Aug 13, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Anyone can find this room dialog box is shown briefly after tapping yes.
What is the root cause of that problem?
When click on
Yesin step 7, we call:App/src/libs/actions/Report.ts
Line 1752 in cc2efc6
then
App/src/pages/settings/Report/VisibilityPage.tsx
Line 86 in 86da342
So if the navigate progress is too fast, the modal is still displayed briefly.
What changes do you think we should make in order to solve the problem?
App/src/pages/settings/Report/VisibilityPage.tsx
Lines 84 to 87 in 86da342
will be:
[-]Android - Room - Anyone can find this room dialog box is shown briefly after tapping `Yes`[/-][+][$250] Android - Room - Anyone can find this room dialog box is shown briefly after tapping `Yes`[/+]melvin-bot commentedon Aug 14, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01a6ad1425f84b08d6
melvin-bot commentedon Aug 14, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (
External)rayane-d commentedon Aug 15, 2024
Thank you for your proposals everyone
@FitseTLT a
refwas used in https://github.com/Expensify/App/pull/44777/files to determine to which page we navigate, but I think that using a ref for our case is more complex than necessary.@daledah I tested switching the order of
hideModalandchangeVisibilityand I'm still able to reproduce the bug.7 remaining items
melvin-bot commentedon Aug 20, 2024
📣 @rayane-djouah 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!
Offer link
Upwork job
melvin-bot commentedon Aug 20, 2024
📣 @FitseTLT 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖
rayane-d commentedon Aug 31, 2024
Given the context above, this issue should be on [HOLD for Payment 2024-09-6] according to production deploy from Deploy Checklist: New Expensify 2024-08-28.
cc @garrettmknight
[-][$250] Android - Room - Anyone can find this room dialog box is shown briefly after tapping `Yes`[/-][+][HOLD for Payment 2024-09-06] [$250] Android - Room - Anyone can find this room dialog box is shown briefly after tapping `Yes`[/+]garrettmknight commentedon Sep 10, 2024
Payment Summary:
garrettmknight commentedon Sep 10, 2024
@FitseTLT can you complete the checklist when you get a chance?
rayane-d commentedon Sep 10, 2024
Checklist
Regression Test Proposal
Do we agree 👍 or 👎
cc @garrettmknight
garrettmknight commentedon Sep 10, 2024
Done!