Skip to content

[HOLD for Payment 2024-09-06] [$250] Android - Room - Anyone can find this room dialog box is shown briefly after tapping Yes #47262

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.19
Reproducible in staging?: Y
Reproducible in production?: Y
Issue reported by: Applause Internal Team

Action Performed:

  1. Launch app
  2. Login with new expensifail account
  3. Tap fab -- nee workspace
  4. Tap fab -- start chat
  5. Create a new room
  6. Tap header -- settings--visibility -- public
  7. Tap yes

Expected Result:

Anyone can find this room dialog box must not be shown briefly after tapping yes.

Actual Result:

Anyone can find this room dialog box is shown briefly after tapping yes.

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6570051_1723475967133.Screenrecorder-2024-08-12-20-43-21-442_compress_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01a6ad1425f84b08d6
  • Upwork Job ID: 1823807191851235765
  • Last Price Increase: 2024-08-14
  • Automatic offers:
    • rayane-djouah | Reviewer | 103606492
    • FitseTLT | Contributor | 103606496
Issue OwnerCurrent Issue Owner: @garrettmknight

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 12, 2024
  2. melvin-bot commented on Aug 12, 2024

    @melvin-bot

    Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. IuliiaHerets commented on Aug 12, 2024

    @IuliiaHerets
    Author

    We think that this bug might be related to #vip-vsb

  4. IuliiaHerets commented on Aug 12, 2024

    @IuliiaHerets
    Author

    @garrettmknight FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  5. FitseTLT commented on Aug 12, 2024

    @FitseTLT
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Android - Room - Anyone can find this room dialog box is shown briefly after tapping Yes

    What is the root cause of that problem?

    After change visibility we are navigating back to details page here

    App/src/libs/actions/Report.ts

    Lines 1752 to 1753 in cc2efc6

    ReportUtils.goBackToDetailsPage(report);
    }

    But the navigation happens to soon before the modal is dismissed so the modal reappears after the navigation

    What changes do you think we should make in order to solve the problem?

    Just the same as we fixed similar bug here

    if (!navigateBackToAfterDelete.current) {
    Navigation.dismissModal();
    } else {
    ReportUtils.navigateBackAfterDeleteTransaction(navigateBackToAfterDelete.current, true);
    }

    In visibility Page we will set a ref navigateToDetails to true after calling updateRoomVisibility then in onModalHide we will call the navigation (if the ref is true) ReportUtils.goBackToDetailsPage(report) we are now calling in updateRoomVisibility and if the ref is false we only call dismissModal

    if (navigateToDetails.current && !isEmptyObject(report) && report.reportID) {
                ReportUtils.goBackToDetailsPage(report);
            } else {
     Navigation.dismissModal();
    }
    

    What alternative solutions did you explore? (Optional)

  6. daledah commented on Aug 13, 2024

    @daledah
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Anyone can find this room dialog box is shown briefly after tapping yes.

    What is the root cause of that problem?

    What changes do you think we should make in order to solve the problem?

    • We can hide the modal before navigating back to report setting screen. So:

    onConfirm={() => {
    changeVisibility(CONST.REPORT.VISIBILITY.PUBLIC);
    hideModal();
    }}

    will be:

                        onConfirm={() => {
                            hideModal();
                            changeVisibility(CONST.REPORT.VISIBILITY.PUBLIC);
                        }}
  7. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Aug 14, 2024
  8. changed the title [-]Android - Room - Anyone can find this room dialog box is shown briefly after tapping `Yes`[/-] [+][$250] Android - Room - Anyone can find this room dialog box is shown briefly after tapping `Yes`[/+] on Aug 14, 2024
  9. melvin-bot commented on Aug 14, 2024

    @melvin-bot
  10. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Aug 14, 2024
  11. melvin-bot commented on Aug 14, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External)

  12. rayane-d commented on Aug 15, 2024

    @rayane-d
    Contributor

    Thank you for your proposals everyone

    @FitseTLT a ref was used in https://github.com/Expensify/App/pull/44777/files to determine to which page we navigate, but I think that using a ref for our case is more complex than necessary.

    @daledah I tested switching the order of hideModal and changeVisibility and I'm still able to reproduce the bug.

  13. 7 remaining items

  14. melvin-bot commented on Aug 20, 2024

    @melvin-bot

    📣 @rayane-djouah 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

    Offer link
    Upwork job

  15. melvin-bot commented on Aug 20, 2024

    @melvin-bot

    📣 @FitseTLT 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

    Offer link
    Upwork job
    Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
    Keep in mind: Code of Conduct | Contributing 📖

  16. rayane-d commented on Aug 31, 2024

    @rayane-d
    Contributor

    ⚠️ We just got confirmation on Slack that the Deploy Checklist: New Expensify 2024-08-26 which includes the PR of this issue was only deployed to production in Deploy Checklist: New Expensify 2024-08-28. More context on why this happened can be found in this Slack thread and this Slack comment.

    Given the context above, this issue should be on [HOLD for Payment 2024-09-6] according to production deploy from Deploy Checklist: New Expensify 2024-08-28.

    cc @garrettmknight

  17. changed the title [-][$250] Android - Room - Anyone can find this room dialog box is shown briefly after tapping `Yes`[/-] [+][HOLD for Payment 2024-09-06] [$250] Android - Room - Anyone can find this room dialog box is shown briefly after tapping `Yes`[/+] on Sep 3, 2024
  18. garrettmknight commented on Sep 10, 2024

    @garrettmknight
    Contributor

    Payment Summary:

  19. garrettmknight commented on Sep 10, 2024

    @garrettmknight
    Contributor

    @FitseTLT can you complete the checklist when you get a chance?

  20. rayane-d commented on Sep 10, 2024

    @rayane-d
    Contributor

    Checklist

    Regression Test Proposal

    1. Open any room that is not "Public".
    2. Tap header > Settings > Visibility > select "Public".
    3. On the confirm modal Tap "Yes".
    4. Verify that the modal is closed and you are navigated to the settings page and the confirm modal doesn't appear briefly on the settings page.

    Do we agree 👍 or 👎

    cc @garrettmknight

  21. garrettmknight commented on Sep 10, 2024

    @garrettmknight
    Contributor

    Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions