Skip to content

[$250] Joined thread stuck in LHN with a 🔴 and it shows up twice in LHN. #47708

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number:
Reproducible in staging?: Needs Reproduction
Reproducible in production?: Needs Reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @AndrewGable
Slack conversation: https://expensify.slack.com/archives/C05LX9D6E07/p1724077993452629

Action Performed:

  1. Create a room that userA, userB, and userC are in
  2. Post a comment as userA
  3. As userB go offline
  4. Have userC create a thread on userA's comment, while online
  5. Have userB create a thread on userA's comment, while offline
  6. Have userB come back online

Expected Result:

Thread displayed one time without any error

Actual Result:

RBR displayed with error and thread displayed twice in LHN

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Google Chrome 2024-08-19 at 10 32 13
Google Chrome 2024-08-19 at 10 32 29

Onyx Data:

{
    "reportName": "Hey folks! I've reserved a \"Chef's Table\" style dinner for 6 (can maybe expand to as much as 8) at Brochu's Family Tradition Sunday night at 5:30pm! Early dinner because I'm sure we'll all be knackered from our journeys over. Give a ✋ if you're interested in joining!",
    "isOptimisticReport": true,
    "type": "chat",
    "chatType": "policyRoom",
    "isOwnPolicyExpenseChat": false,
    "isPinned": false,
    "lastActorAccountID": 0,
    "lastMessageTranslationKey": "",
    "lastMessageHtml": "",
    "lastReadTime": "2024-08-15 22:13:10.187",
    "lastVisibleActionCreated": "2024-08-15 22:13:10.187",
    "notificationPreference": "hidden",
    "oldPolicyName": "Expensify Chat",
    "ownerAccountID": 0,
    "parentReportActionID": "1849499882279174199",
    "parentReportID": "4569022691530677",
    "participants": {
        "3064822": {
            "hidden": false,
            "role": "admin"
        },
        "3079111": {
            "hidden": false,
            "role": "member"
        }
    },
    "policyID": "063B20AF6F45E248",
    "reportID": "8214043543876468",
    "stateNum": 0,
    "statusNum": 0,
    "description": "",
    "avatarUrl": "",
    "pendingFields": {
        "createChat": "add"
    },
    "errorFields": {
        "createChat": {
            "1723759990438375": "Auth OpenReport returned an error"
        }
    }
}

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01ad3492834b7f724d
  • Upwork Job ID: 1827073269001925896
  • Last Price Increase: 2024-11-29

Activity

  1. melvin-bot commented on Aug 20, 2024

    @melvin-bot

    Current assignee @AndrewGable is eligible for the AutoAssignerNewDotQuality assigner, not assigning anyone new.

  2. melvin-bot commented on Aug 20, 2024

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. MelvinBot commented on Aug 20, 2024

    @MelvinBot
    Contributor

    This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

  4. AndrewGable commented on Aug 20, 2024

    @AndrewGable
    Contributor

    @mallenexpensify - Can you try to reproduce based on those steps?

  5. mallenexpensify commented on Aug 21, 2024

    @mallenexpensify
    Contributor

    Was partially able to reproduce, which I think is the core bug. ie. After coming back online as User B, I see RBR in the thread and in LHN (I don't see it shown as twice in LHN though)

    I was thinking of adding External and asking a C+ to attempt reproduction too, whatcha think?

    image
  6. AndrewGable commented on Aug 21, 2024

    @AndrewGable
    Contributor

    Sounds great!

  7. 111 remaining items

  8. brunovjk commented on Dec 2, 2024

    @brunovjk
    Contributor

    @mallenexpensify,

    Given that this issue seems primarily backend-related but impacts the frontend, I suggest closing it for now with the option to reopen if necessary.

    To ensure regressions don't occur, I propose adding a Jest unit test to simulate the following scenario:

    • Users interact with a thread while some are offline, and data syncs upon reconnection.
      The test would validate proper thread display and prevent message duplications or errors.

    Please let me know if you need more details or would prefer a different approach.

    Thanks!

  9. mallenexpensify commented on Dec 2, 2024

    @mallenexpensify
    Contributor

    Thanks @brunovjk. Can you add 🎀 👀 🎀 C+ reviewed to a comment to assign an internal engineer to get 👀 before I close? Unsure if it's backend-related if we want to close or try to find someone internal to work on. Thx

    Created a test case GH

    image
  10. brunovjk commented on Dec 2, 2024

    @brunovjk
    Contributor

    Thanks @brunovjk. Can you add 🎀 👀 🎀 C+ reviewed to a comment to assign an internal engineer to get 👀 before I close? Unsure if it's backend-related if we want to close or try to find someone internal to work on.

    Thank you @mallenexpensify

    🎀 👀 🎀

  11. melvin-bot commented on Dec 2, 2024

    @melvin-bot

    Current assignee @AndrewGable is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

  12. brunovjk commented on Dec 3, 2024

    @brunovjk
    Contributor

    Update: Initially, the issue seemed tied to the ... LHN, but the symptoms changed over time. Two weeks ago, user C's message disappeared when they came online—no errors, just no trace. This suggests the bug occurs when users interact with a thread while some are offline, and data syncs upon reconnection.

    I believe it's a backend issue. We opened an "internal issue", but closed it as it seems fixed now. However, new FE symptoms may reappear, so we propose creating a test for this scenario.

    Scenario Recap:

    • Create a room with userA, userB, and userC
    • Post a comment as userA
    • Have userB go offline
    • Have userC create a thread on userA’s comment, while online
    • Have userB create a thread on userA’s comment, while offline
    • Have userB come back online
    • Verify the thread displays only once without any errors

    Thoughts, @AndrewGable?

  13. AndrewGable commented on Dec 5, 2024

    @AndrewGable
    Contributor

    Looks good to me! 👍

  14. mallenexpensify commented on Dec 6, 2024

    @mallenexpensify
    Contributor

    Thanks @brunovjk , it sounds like....

    • We want a test case with the steps above, I created one here
    • The bug should be fixed so we can close this
    • Compensation might be due to @brunovjk based on time you invested here. If you believe so, follow the below from the C+ process doc

    Provide brief, yet detailed, reasoning for compensation
    State the amount they feel they’re due. Standard percentages are 25, 50 and 100% of the job price.

  15. brunovjk commented on Dec 6, 2024

    @brunovjk
    Contributor

    Exactly, I care about the Tests, so that the issue doesn't occur, and closing it. We hadn't discussed compensation, I don't mind receiving it, since we've been tracking and testing this issue for months, but I agree with any decision, what I want most is to close this old issue hehe

  16. mallenexpensify commented on Dec 7, 2024

    @mallenexpensify
    Contributor

    @brunovjk how about 25%, $75, since you spent time on the issue and produced the test case steps (but, we didn't have an accepted solution so I don't think 50% is best (based on our process for payments and percentages).

  17. brunovjk commented on Dec 7, 2024

    @brunovjk
    Contributor

    Perfect :D

  18. mallenexpensify commented on Dec 7, 2024

    @mallenexpensify
    Contributor

    @brunovjk can you please accept the job and reply here once you have?
    https://www.upwork.com/jobs/~021865204166194804492

  19. brunovjk commented on Dec 7, 2024

    @brunovjk
    Contributor

    @brunovjk can you please accept the job and reply here once you have? https://www.upwork.com/jobs/~021865204166194804492

    Done @mallenexpensify

  20. mallenexpensify commented on Dec 7, 2024

    @mallenexpensify
    Contributor

    Contributor+: @brunovjk paid $75 via Upwork

    Thx!

  21. moved this from Bugs and Follow Up Issues to Done in #expensify-bugson Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

AutoAssignerNewDotQualityUsed to assign quality issues to engineersBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions