Skip to content

[$500] [POLISH][Search v2.1] Amount filter - Native - The digit exceeding the max allowed decimal places is briefly inserted into the input #47875

Closed

Description

@rayane-d

This is a follow-up issue.
Coming from: #47343 (comment) and #47343 (comment)

Bug in iOS and Android native apps: When entering a number, the digit exceeding the maximum allowed decimal places is briefly inserted into the input field before being deleted. They should not be inserted at all.

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-08-15.at.15.52.28.mp4

cc @luacmartins @289Adam289

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~017b65a6e5c7b77ba2
  • Upwork Job ID: 1827006416140957560
  • Last Price Increase: 2025-01-08
  • Automatic offers:
    • brunovjk | Reviewer | 104524279
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @luacmartins
Issue OwnerCurrent Issue Owner: @luacmartins

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 22, 2024
  2. melvin-bot commented on Aug 22, 2024

    @melvin-bot

    Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. self-assigned this
    on Aug 22, 2024
  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Aug 23, 2024
  5. changed the title [-][Search v2.1] Amount filter - Native - The digit exceeding the max allowed decimal places is briefly inserted into the input[/-] [+][$250] [Search v2.1] Amount filter - Native - The digit exceeding the max allowed decimal places is briefly inserted into the input[/+] on Aug 23, 2024
  6. melvin-bot commented on Aug 23, 2024

    @melvin-bot
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Aug 23, 2024
  8. melvin-bot commented on Aug 23, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @brunovjk (External)

  9. changed the title [-][$250] [Search v2.1] Amount filter - Native - The digit exceeding the max allowed decimal places is briefly inserted into the input[/-] [+][$250] [POLISH][Search v2.1] Amount filter - Native - The digit exceeding the max allowed decimal places is briefly inserted into the input[/+] on Aug 23, 2024
  10. eyobai commented on Aug 23, 2024

    @eyobai

    Validation Function: Create a function to check if the input exceeds the allowed decimal places.
    Event Listener: Use the input event to validate each change to the input field.
    Immediate Correction: If the input is invalid, immediately revert to the last valid state.

  11. melvin-bot commented on Aug 23, 2024

    @melvin-bot

    📣 @eyobai! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Make sure you've read and understood the contributing guidelines.
    2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
    
  12. 237 remaining items

  13. melvin-bot commented on Feb 19, 2025

    @melvin-bot

    @luacmartins, @kirillzyusko, @isabelastisser, @brunovjk Still overdue 6 days?! Let's take care of this!

  14. brunovjk commented on Feb 19, 2025

    @brunovjk
    Contributor

    PR on staging

  15. luacmartins commented on Feb 19, 2025

    @luacmartins
    Contributor

    PR on staging

  16. luacmartins commented on Feb 19, 2025

    @luacmartins
    Contributor

    not overdue, PR in staging

  17. luacmartins commented on Feb 20, 2025

    @luacmartins
    Contributor

    PR deployed to production

  18. luacmartins commented on Feb 20, 2025

    @luacmartins
    Contributor

    Payment is being handled in #56330, so I'm closing this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions