You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-12-07] [$250] [Dupe detection] Tax field does not show the "Default" label on the confirmation page #47975
Version Number: v9.0.24-1 Reproducible in staging?: Y Reproducible in production?: Y Email or phone of affected tester (no customers):applausetester+kh050806@applause.expensifail.com Issue reported by: Applause Internal Team
Action Performed:
Precondition:
Track tax is enabled in Workspace settings > Distance rates > Settings.
Distance rate has Tax rate and Tax reclaimable fields populated.
Go to staging.new.expensify.com
Go to workspace chat.
Submit two same distance expenses with the same distance rate that has tax rate and tax reclaimable on.
Go to transaction thread of any submitted expense.
Note that Tax field has the "Default" label.
Click Review duplicates.
Click Keep this on (any).
Proceed to confirmation page.
Expected Result:
Tax field will show the "Default" label on the confirmation page.
Actual Result:
Tax field does not show the "Default" label on the confirmation page and instead shows "None"
@stephanieelliott FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
But when we call buildNewTransactionAfterReviewingDuplicates on confirmation page the comment object is only left with a comment property, all other properties are removed.
NOTE: We also need to make changes in few other files. The changes are bit similar to solution above. Please checkout the text branch below for a better understanding.
changed the title [-]Dupe detect - Tax field does not show the "Default" label on the confirmation page[/-][+][$250] Dupe detect - Tax field does not show the "Default" label on the confirmation page[/+]on Aug 28, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.68-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@alitoshmatov@stephanieelliott@alitoshmatov The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: No discussion started
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Activity
melvin-bot commentedon Aug 24, 2024
Triggered auto assignment to @stephanieelliott (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.IuliiaHerets commentedon Aug 24, 2024
We think that this bug might be related to #wave-control
IuliiaHerets commentedon Aug 24, 2024
@stephanieelliott FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
Krishna2323 commentedon Aug 25, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Dupe detect - Tax field does not show the "Default" label on the confirmation page
What is the root cause of that problem?
To get the default tax rate we need
comment?.customUnit?.customUnitRateID?.toString();in thetransactionID.App/src/libs/TransactionUtils.ts
Lines 748 to 769 in 73f97c9
But when we call
buildNewTransactionAfterReviewingDuplicateson confirmation page the comment object is only left with a comment property, all other properties are removed.App/src/libs/TransactionUtils.ts
Lines 952 to 963 in 73f97c9
What changes do you think we should make in order to solve the problem?
When we modify the transaction, we need to store the remaining properties of the comment object. To do this we need to make few changes.
App/src/libs/TransactionUtils/index.ts
Lines 991 to 993 in 0c84552
buildNewTransactionAfterReviewingDuplicates, we need to merge the remaining properties of the comment object.App/src/libs/TransactionUtils/index.ts
Line 1030 in 0c84552
ReviewDescription, we need to find the correct comment object and update it in theREVIEW_DUPLICATESONYX object.App/src/pages/TransactionDuplicate/ReviewDescription.tsx
Lines 34 to 39 in 0c84552
Test Branch
What alternative solutions did you explore? (Optional)
Alternatively we can store the comment object with updated comment instead of description text:
App/src/libs/TransactionUtils/index.ts
Lines 987 to 992 in 0c84552
NOTE: We also need to make changes in few other files. The changes are bit similar to solution above. Please checkout the text branch below for a better understanding.
Test Branch - Alternative Solution
Result
Monosnap.screencast.2024-08-25.06-52-08.mp4
stephanieelliott commentedon Aug 28, 2024
updated the repro steps slightly -- actual result shows
Noneinstead of the expected default rate.[-]Dupe detect - Tax field does not show the "Default" label on the confirmation page[/-][+][$250] Dupe detect - Tax field does not show the "Default" label on the confirmation page[/+]melvin-bot commentedon Aug 28, 2024
Job added to Upwork: https://www.upwork.com/jobs/~017284a9effe70faa8
76 remaining items
melvin-bot commentedon Nov 30, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Nov 30, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.68-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-12-07. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Nov 30, 2024
@alitoshmatov @stephanieelliott @alitoshmatov The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
alitoshmatov commentedon Dec 10, 2024
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/42571/files#r1878801476
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: No discussion started
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
I don't think regression test is needed
stephanieelliott commentedon Dec 11, 2024
Summarizing payment on this issue:
Upwork job is here: https://www.upwork.com/jobs/~017284a9effe70faa8
JmillsExpensify commentedon Dec 11, 2024
$250 approved for @alitoshmatov