Skip to content

[Payment due 08-23]Emphasize completed payments with animation #48036

Closed

Description

@roryabraham

slack discussion: https://expensify.slack.com/archives/CC7NECV4L/p1724447142877389

Strategy

Expensify is a financial collaboration app, and in any financial conversation, money moving hands from one person to another tends to be the most critical part. That critical moment needs to be clear, unambiguous, and confidence-inspiring.

Problem

When you receive a money request in NewDot, you’ll see a big green Pay button, and one tap instantly pays the request and changes and a checkmark appears saying that it’s paid. It’s such a crucial moment, but it’s unclear whether the payment was sent or not. As a user, I always find I have to double-take and make sure that the request was actually paid.

Solution

Update the payment flow slightly to draw more attention to it and celebrate the transfer of funds. To do this, update NewDot such that when you tap the Pay button:

  1. the button animates into a Payment Complete text, which collapses a few moments later
  2. (iOS/Android) we trigger some strong haptic feedback to give a tactile confirmation of the completion of the payment.
  3. Once the Payment Complete text finishes collapsing:
    1. a checkmark appears (as today)
    2. Play the assets/sounds/success.mp3 sound, instead of assets/sounds/done.mp3 like we do today

Example:

image

Issue OwnerCurrent Issue Owner: @ZhenjaHorbach

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    NewFeatureSomething to build that is a new item.
    on Aug 26, 2024
  2. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Aug 26, 2024
  3. melvin-bot commented on Aug 26, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @ZhenjaHorbach (External)

  4. melvin-bot commented on Aug 26, 2024

    @melvin-bot

    Triggered auto assignment to @Christinadobrzyn (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

  5. melvin-bot commented on Aug 26, 2024

    @melvin-bot

    ⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

  6. melvin-bot commented on Aug 26, 2024

    @melvin-bot

    Current assignee @dubielzyk-expensify is eligible for the NewFeature assigner, not assigning anyone new.

  7. roryabraham commented on Aug 26, 2024

    @roryabraham
    ContributorAuthor

    @dubielzyk-expensify has volunteered to help finalize the design here.

  8. 58 remaining items

  9. bernhardoj commented on Sep 25, 2024

    @bernhardoj
    Contributor

    #49331 happens because of this suggestion, @roryabraham does that count as a regression?

  10. shubham1206agra commented on Sep 25, 2024

    @shubham1206agra
    Contributor

    @bernhardoj Yes, since checking code implementation for bugs is your area. @roryabraham is just suggesting something.

  11. bernhardoj commented on Sep 25, 2024

    @bernhardoj
    Contributor

    If that's true, then I'll keep in mind ignoring any suggestion unrelated to the issue in the future since that doesn't benefit me at all and becomes a punishment to me if there is an issue arising from that suggestion.

  12. shubham1206agra commented on Sep 25, 2024

    @shubham1206agra
    Contributor

    If that's true, then I'll keep in mind ignoring any suggestion unrelated to the issue in the future since that doesn't benefit me at all and becomes a punishment to me if there is an issue arising from that suggestion.

    Hmmm. What's the problem if you test the code where you made the change? Why should there be immunity here?

  13. Christinadobrzyn commented on Sep 25, 2024

    @Christinadobrzyn
    Contributor

    Asking @roryabraham about the regression discussion - #48036 (comment)

    Payment summary here - #48036 (comment)

  14. roryabraham commented on Sep 28, 2024

    @roryabraham
    ContributorAuthor

    Well regarding the regression, I don't think it was this suggestion per-se so much as by the migration from withOnyx -> useOnyx. I say that because it looks like the root cause was lastPaymentMethod being not loaded from Onyx yet when the component mounts, which wasn't possible with withOnyx.

    I don't think @shubham1206agra is wrong here either though - the useOnyx migration is a requirement, and any time you are making code changes, you are responsible for testing that code and accountable for either fixing it or getting a regression penalty.

    That said, I think we can waive any regression penalty in this case for a few reasons:

    • @ZhenjaHorbach was the C+ reviewer for this issue and took care of fixing it in Fix bug with Payment option is not selected #49345
    • @bernhardoj didn't hesitate to open second PR to implement a design improvement we missed the first time around. This demonstrates a commitment and work ethic that I think should be rewarded
    • Frankly, it's pretty hard to spot when the render-blocking behavior of withOnyx actually matters.

    I understand that doing this incremental useOnyx migration as part of PRs that might be otherwise unrelated is different from how we've operated in the past, but except in special circumstances, that's the expectation when working on PRs for now. We should try to be vigilant and do a bit of extra testing for more obscure keys, because they're less likely to be in the cache already than something like a report or session. For what it's worth though, as time goes on it will become decreasingly common that we have to do it, and the code will be simpler as a result.

  15. Christinadobrzyn commented on Sep 30, 2024

    @Christinadobrzyn
    Contributor

    Thank you for the thorough review, @roryabraham!

    Paying out based on payment summary where the regression penalty isn't included.

    @bernhardoj can you please request payment through NewDot or let me know if you'd like me to pay you through Upwork. TY!

  16. bernhardoj commented on Sep 30, 2024

    @bernhardoj
    Contributor

    Thank you! Requested in ND.

  17. Christinadobrzyn commented on Sep 30, 2024

    @Christinadobrzyn
    Contributor

    Thanks! @bernhardoj. I forgot to ask, do we need a regression test for this?

  18. ZhenjaHorbach commented on Sep 30, 2024

    @ZhenjaHorbach
    Contributor

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@ZhenjaHorbach] The PR that introduced the bug has been identified. Link to the PR:

    New feature

    • [ @ZhenjaHorbach] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

    New feature

    • [@ZhenjaHorbach] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

    NA

    • [@ZhenjaHorbach] Determine if we should create a regression test for this bug.
    • [@ZhenjaHorbach] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    Regression Test Proposal

    Do we agree 👍 or 👎

  19. ZhenjaHorbach commented on Sep 30, 2024

    @ZhenjaHorbach
    Contributor

    Thanks! @bernhardoj. I forgot to ask, do we need a regression test for this?

    @Christinadobrzyn
    Done !

  20. Christinadobrzyn commented on Sep 30, 2024

    @Christinadobrzyn
    Contributor

    Thanks @ZhenjaHorbach - regression test here - https://github.com/Expensify/Expensify/issues/431955

    Payment summary here - #48036 (comment)

    Gonna close this out since the last step is @bernhardoj being paid via ND but they've requested the payment so nothing else to wait on.

  21. JmillsExpensify commented on Sep 30, 2024

    @JmillsExpensify
    Contributor

    $250 approved for @bernhardoj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorNewFeatureSomething to build that is a new item.ReviewingHas a PR in review

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions