Repository navigation
Description
slack discussion: https://expensify.slack.com/archives/CC7NECV4L/p1724447142877389
Strategy
Expensify is a financial collaboration app, and in any financial conversation, money moving hands from one person to another tends to be the most critical part. That critical moment needs to be clear, unambiguous, and confidence-inspiring.
Problem
When you receive a money request in NewDot, you’ll see a big green Pay button, and one tap instantly pays the request and changes and a checkmark appears saying that it’s paid. It’s such a crucial moment, but it’s unclear whether the payment was sent or not. As a user, I always find I have to double-take and make sure that the request was actually paid.
Solution
Update the payment flow slightly to draw more attention to it and celebrate the transfer of funds. To do this, update NewDot such that when you tap the Pay button:
- the button animates into a
Payment Completetext, which collapses a few moments later - (iOS/Android) we trigger some strong haptic feedback to give a tactile confirmation of the completion of the payment.
- Once the
Payment Completetext finishes collapsing:- a checkmark appears (as today)
- Play the
assets/sounds/success.mp3sound, instead ofassets/sounds/done.mp3like we do today
Example:
Issue Owner
Current Issue Owner: @ZhenjaHorbachMetadata
Metadata
Labels
Type
Projects
- StatusShow more project fieldsDone

Activity
melvin-bot commentedon Aug 26, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ZhenjaHorbach (
External)melvin-bot commentedon Aug 26, 2024
Triggered auto assignment to @Christinadobrzyn (
NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.melvin-bot commentedon Aug 26, 2024
melvin-bot commentedon Aug 26, 2024
Current assignee @dubielzyk-expensify is eligible for the NewFeature assigner, not assigning anyone new.
roryabraham commentedon Aug 26, 2024
@dubielzyk-expensify has volunteered to help finalize the design here.
58 remaining items
bernhardoj commentedon Sep 25, 2024
#49331 happens because of this suggestion, @roryabraham does that count as a regression?
shubham1206agra commentedon Sep 25, 2024
@bernhardoj Yes, since checking code implementation for bugs is your area. @roryabraham is just suggesting something.
bernhardoj commentedon Sep 25, 2024
If that's true, then I'll keep in mind ignoring any suggestion unrelated to the issue in the future since that doesn't benefit me at all and becomes a punishment to me if there is an issue arising from that suggestion.
shubham1206agra commentedon Sep 25, 2024
Hmmm. What's the problem if you test the code where you made the change? Why should there be immunity here?
Christinadobrzyn commentedon Sep 25, 2024
Asking @roryabraham about the regression discussion - #48036 (comment)
Payment summary here - #48036 (comment)
roryabraham commentedon Sep 28, 2024
Well regarding the regression, I don't think it was this suggestion per-se so much as by the migration from
withOnyx->useOnyx. I say that because it looks like the root cause waslastPaymentMethodbeing not loaded from Onyx yet when the component mounts, which wasn't possible withwithOnyx.I don't think @shubham1206agra is wrong here either though - the
useOnyxmigration is a requirement, and any time you are making code changes, you are responsible for testing that code and accountable for either fixing it or getting a regression penalty.That said, I think we can waive any regression penalty in this case for a few reasons:
withOnyxactually matters.I understand that doing this incremental
useOnyxmigration as part of PRs that might be otherwise unrelated is different from how we've operated in the past, but except in special circumstances, that's the expectation when working on PRs for now. We should try to be vigilant and do a bit of extra testing for more obscure keys, because they're less likely to be in the cache already than something like a report or session. For what it's worth though, as time goes on it will become decreasingly common that we have to do it, and the code will be simpler as a result.Christinadobrzyn commentedon Sep 30, 2024
Thank you for the thorough review, @roryabraham!
Paying out based on payment summary where the regression penalty isn't included.
@bernhardoj can you please request payment through NewDot or let me know if you'd like me to pay you through Upwork. TY!
bernhardoj commentedon Sep 30, 2024
Thank you! Requested in ND.
Christinadobrzyn commentedon Sep 30, 2024
Thanks! @bernhardoj. I forgot to ask, do we need a regression test for this?
ZhenjaHorbach commentedon Sep 30, 2024
New feature
New feature
NA
Regression Test Proposal
Do we agree 👍 or 👎
ZhenjaHorbach commentedon Sep 30, 2024
@Christinadobrzyn
Done !
Christinadobrzyn commentedon Sep 30, 2024
Thanks @ZhenjaHorbach - regression test here - https://github.com/Expensify/Expensify/issues/431955
Payment summary here - #48036 (comment)
Gonna close this out since the last step is @bernhardoj being paid via ND but they've requested the payment so nothing else to wait on.
JmillsExpensify commentedon Sep 30, 2024
$250 approved for @bernhardoj