Skip to content

[HOLD for payment 2024-10-29] [$250] Submit Expense - Contacts section is missing participants #48114

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.25-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4890824&group_by=cases:section_id&group_order=asc&group_id=229066
Issue reported by: Applause - Internal Team

Action Performed:

  1. Sign up for a new account on staging.new.expensify.com
  2. Create DMs with 7 new contacts
  3. Go to Global Create > Submit Expense
  4. Enter an amount and click Next
  5. Observe the missing participants from the Contacts section.

Expected Result:

During the expense submitting or splitting process, the search list, should be divided in "Recents" and "Contacts"

All of your DM contacts should be in the contacts section.

Actual Result:

Some contacts are missing.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Screenshot 2024-10-16 at 9 33 01 PM
Bug6584155_1724766273965.Contacts-Recents.mp4

ontacts-Recent (1)

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~016d2f5d8be09bffb6
  • Upwork Job ID: 1829406098502441268
  • Last Price Increase: 2024-10-04
  • Automatic offers:
    • c3024 | Contributor | 104318599
Issue OwnerCurrent Issue Owner: @RachCHopkins

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 27, 2024
  2. melvin-bot commented on Aug 27, 2024

    @melvin-bot

    Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. lanitochka17 commented on Aug 27, 2024

    @lanitochka17
    Author

    @kadiealexander FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  4. tsa321 commented on Aug 28, 2024

    @tsa321
    Contributor

    Edited by proposal-police: This proposal was edited at 2024-08-28 06:51:06 UTC.

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Search list when submitting expense, doesn't display contacts section

    What is the root cause of that problem?

    When submitting an expense, if there is no chat history with a contact in the contact list, it will be included in the Contacts section. However, if there is chat history, it will be included in recentReports or just Chats. The issue is that recentReports is limited to a maximum of 5 recent reports (because of the slice and splice in below code), causing the remaining reports to be discarded:

    if (searchInputValue.trim() === '' && maxRecentReportsToShow > 0) {
    return {...options, recentReports: options.recentReports.slice(0, maxRecentReportsToShow)};
    }

    and here:

    if (maxRecentReportsToShow > 0 && recentReports.length > maxRecentReportsToShow) {
    recentReports.splice(maxRecentReportsToShow);
    }

    As a result, it seems that some contacts are missing, and many reports are not displayed due to this filtering (slice / splice).

    What changes do you think we should make in order to solve the problem?

    We could store the remaining reports from recentReports into a separate olderReports (or another name) data and return it to the caller in MoneyRequestParticipantsSelector (must check other caller if necessary).

    When generating section data:

    newSections.push(formatResults.section);
    newSections.push({
    title: translate('common.recents'),
    data: chatOptions.recentReports,
    shouldShow: chatOptions.recentReports.length > 0,
    });
    newSections.push({
    title: translate('common.contacts'),
    data: chatOptions.personalDetails,
    shouldShow: chatOptions.personalDetails.length > 0,
    });

    include the olderReports data. The sketch code changes could be something like this. We must also check other usage of filterOptions and adjust the code accordingly. and If we want to re-order the olderReports by other criteria (other than date), we can adjust it there.

    What alternative solutions did you explore? (Optional)

    The alternative solution is to retrieve DM reports from older or discarded reports and include them in the contact list.

  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Aug 30, 2024
  6. melvin-bot commented on Aug 30, 2024

    @melvin-bot
  7. changed the title [-]Submit Expense - Search list when submitting expense, doesn´t display the contacts section[/-] [+][$250] Submit Expense - Search list when submitting expense, doesn´t display the contacts section[/+] on Aug 30, 2024
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Aug 30, 2024
  9. melvin-bot commented on Aug 30, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @eh2077 (External)

  10. 105 remaining items

  11. RachCHopkins commented on Nov 4, 2024

    @RachCHopkins
    Contributor

    @c3024 @eh2077 I would really love to pay you. Can someone please complete the checklist?

  12. eh2077 commented on Nov 4, 2024

    @eh2077
    Contributor

    @RachCHopkins Sorry for the late response! I put it on my list and will complete it by EOD.

  13. eh2077 commented on Nov 4, 2024

    @eh2077
    Contributor

    Checklist

    Regression test

    1. Sign up for a new account on staging.new.expensify.com
    2. Create DMs with 7 new contacts
    3. Go to Global Create > Submit Expense
    4. Enter an amount and click Next
    5. Verify that all participants can be found in the Contacts section or the Recents section.
  14. RachCHopkins commented on Nov 8, 2024

    @RachCHopkins
    Contributor

    Thank you - I will get this sorted out on my Monday!

  15. MonilBhavsar commented on Nov 8, 2024

    @MonilBhavsar
    Contributor

    Thank you!

  16. RachCHopkins commented on Nov 10, 2024

    @RachCHopkins
    Contributor

    Payment Summary:

    • Contributor: @c3024 paid $250 via Upwork
    • Contributor+: @eh2077 to be paid $250 via NewDot manual requests

    Upwork job here

  17. RachCHopkins commented on Nov 10, 2024

    @RachCHopkins
    Contributor

    Contributor has been paid, the contract has been completed, and the Upwork post has been closed.

  18. eh2077 commented on Nov 11, 2024

    @eh2077
    Contributor

    Requested payment in NewDot

  19. JmillsExpensify commented on Nov 11, 2024

    @JmillsExpensify
    Contributor

    $250 approved for @eh2077

  20. moved this from Release 2.5: SuiteWorld (Sept 9th) to Done in [#whatsnext] #wave-collecton Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions