Skip to content

[$250] Card - Double RHP animation gets shown when clicking on Issue New Card #48204

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.25-10
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+nl466@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

  1. Navigate to staging.new.expensify.com
  2. Sign in with a new Expensifail account
  3. Create a workspace
  4. Make the default currency of the workspace "USD"
  5. Go to more features and enable expensify cards
  6. Go to Expensify Card and click on Issue card
  7. Click outside the RHP to close the RHP
  8. Click on Issue New Card again and observe the RHP

Expected Result:

One RHP opening animation is displayed

Actual Result:

Double RHP opening animation is displayed. It seems like two RHP opened with a small delay from each other

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6585108_1724840589161.bandicam_2024-08-28_13-20-42-842.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01639b582438af2409
  • Upwork Job ID: 1829560063821054093
  • Last Price Increase: 2024-08-30
  • Automatic offers:
    • dukenv0307 | Reviewer | 103782679
    • dominictb | Contributor | 103782680
Issue OwnerCurrent Issue Owner: @dukenv0307

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 28, 2024
  2. melvin-bot commented on Aug 28, 2024

    @melvin-bot

    Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. lanitochka17 commented on Aug 28, 2024

    @lanitochka17
    Author

    @CortneyOfstad FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  4. lanitochka17 commented on Aug 28, 2024

    @lanitochka17
    Author

    We think that this bug might be related to #wave-collect - Release 2

  5. dominictb commented on Aug 29, 2024

    @dominictb
    Contributor

    Edited by proposal-police: This proposal was edited at 2024-08-29 04:47:44 UTC.

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Double RHP opening animation is displayed. It seems like two RHP opened with a small delay from each other

    What is the root cause of that problem?

    When users press Issue new card, we trigger the following logic with stepToOpen is empty string

    Navigation.navigate(ROUTES.BANK_ACCOUNT_WITH_STEP_TO_OPEN.getRoute('', policy?.id, ROUTES.WORKSPACE_EXPENSIFY_CARD.getRoute(policy?.id ?? '-1')));

    -> the url is bank-account?backTo....

    In ReimbursementAccountPage page, we will navigate to the actual step

    Navigation.navigate(ROUTES.BANK_ACCOUNT_WITH_STEP_TO_OPEN.getRoute(getRouteForCurrentStep(currentStep), policyID, backTo));

    -> the url is bank-account/new?backTo....

    So we can see the flicker

    What changes do you think we should make in order to solve the problem?

    We should use new for stepToOpen params same as what we already did in here since we want to start the flow, so the step should be new

                Navigation.navigate(ROUTES.BANK_ACCOUNT_WITH_STEP_TO_OPEN.getRoute('new', policy?.id, ROUTES.WORKSPACE_EXPENSIFY_CARD.getRoute(policy?.id ?? '-1')));
    

    What alternative solutions did you explore? (Optional)

    We should check other places too

  6. CortneyOfstad commented on Aug 30, 2024

    @CortneyOfstad
    Contributor

    Attempted to recreate, but experiencing another bug within my expensifail.com account. That is linked here

    In the meantime, going to get eyes on this.

  7. added
    ExternalAdded to denote the issue can be worked on by a contributor
    retest-weeklyApply this label if you want this issue tested on a Weekly basis by Applause
    on Aug 30, 2024
  8. melvin-bot commented on Aug 30, 2024

    @melvin-bot
  9. changed the title [-]Card - Double RHP animation gets shown when clicking on Issue New Card[/-] [+][$250] Card - Double RHP animation gets shown when clicking on Issue New Card[/+] on Aug 30, 2024
  10. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Aug 30, 2024
  11. 12 remaining items

  12. CortneyOfstad commented on Sep 11, 2024

    @CortneyOfstad
    Contributor

    PR has not been deployed to staging yet, so will continue to keep an eye on things!

  13. CortneyOfstad commented on Sep 18, 2024

    @CortneyOfstad
    Contributor

    QA is still on-going!

  14. mvtglobally commented on Sep 21, 2024

    @mvtglobally

    Issue not reproducible during KI retests. (First week)

  15. dominictb commented on Sep 30, 2024

    @dominictb
    Contributor

    @CortneyOfstad PR deployed to production 3 weeks ago. Should be ready for payment now. Please add [HOLD for payment] to the title.

  16. melvin-bot commented on Sep 30, 2024

    @melvin-bot

    This issue has not been updated in over 15 days. @tgolen, @CortneyOfstad, @dukenv0307, @dominictb eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  17. mvtglobally commented on Oct 5, 2024

    @mvtglobally

    Issue not reproducible during KI retests. (Second week)

  18. dominictb commented on Oct 10, 2024

    @dominictb
    Contributor

    @CortneyOfstad Please handle payment for this.

  19. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed
    ReviewingHas a PR in review
    on Oct 14, 2024
  20. CortneyOfstad commented on Oct 14, 2024

    @CortneyOfstad
    Contributor

    Payment Summary

    @dominictb — paid $250 via Upwork
    @dukenv0307 — paid $250 via Upwork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorMonthlyKSv2Needs ReproductionReproducible steps neededretest-weeklyApply this label if you want this issue tested on a Weekly basis by Applause

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions