You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] Card - Double RHP animation gets shown when clicking on Issue New Card #48204
Version Number: 9.0.25-10 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers):applausetester+nl466@applause.expensifail.com Issue reported by: Applause - Internal Team
Action Performed:
Navigate to staging.new.expensify.com
Sign in with a new Expensifail account
Create a workspace
Make the default currency of the workspace "USD"
Go to more features and enable expensify cards
Go to Expensify Card and click on Issue card
Click outside the RHP to close the RHP
Click on Issue New Card again and observe the RHP
Expected Result:
One RHP opening animation is displayed
Actual Result:
Double RHP opening animation is displayed. It seems like two RHP opened with a small delay from each other
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
@CortneyOfstad FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
changed the title [-]Card - Double RHP animation gets shown when clicking on Issue New Card[/-][+][$250] Card - Double RHP animation gets shown when clicking on Issue New Card[/+]on Aug 30, 2024
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
Activity
melvin-bot commentedon Aug 28, 2024
Triggered auto assignment to @CortneyOfstad (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.lanitochka17 commentedon Aug 28, 2024
@CortneyOfstad FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
lanitochka17 commentedon Aug 28, 2024
We think that this bug might be related to #wave-collect - Release 2
dominictb commentedon Aug 29, 2024
Edited by proposal-police: This proposal was edited at 2024-08-29 04:47:44 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Double RHP opening animation is displayed. It seems like two RHP opened with a small delay from each other
What is the root cause of that problem?
When users press
Issue new card, we trigger the following logic withstepToOpenis empty stringApp/src/pages/workspace/expensifyCard/WorkspaceExpensifyCardPageEmptyState.tsx
Line 57 in fbc6720
-> the url is
bank-account?backTo....In
ReimbursementAccountPagepage, we will navigate to the actual stepApp/src/pages/ReimbursementAccount/ReimbursementAccountPage.tsx
Line 322 in fbc6720
-> the url is
bank-account/new?backTo....So we can see the flicker
What changes do you think we should make in order to solve the problem?
We should use
newfor stepToOpen params same as what we already did in here since we want to start the flow, so the step should benewWhat alternative solutions did you explore? (Optional)
We should check other places too
CortneyOfstad commentedon Aug 30, 2024
Attempted to recreate, but experiencing another bug within my expensifail.com account. That is linked here
In the meantime, going to get eyes on this.
melvin-bot commentedon Aug 30, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01639b582438af2409
[-]Card - Double RHP animation gets shown when clicking on Issue New Card[/-][+][$250] Card - Double RHP animation gets shown when clicking on Issue New Card[/+]12 remaining items
CortneyOfstad commentedon Sep 11, 2024
PR has not been deployed to staging yet, so will continue to keep an eye on things!
CortneyOfstad commentedon Sep 18, 2024
QA is still on-going!
mvtglobally commentedon Sep 21, 2024
Issue not reproducible during KI retests. (First week)
dominictb commentedon Sep 30, 2024
@CortneyOfstad PR deployed to production 3 weeks ago. Should be ready for payment now. Please add [HOLD for payment] to the title.
melvin-bot commentedon Sep 30, 2024
This issue has not been updated in over 15 days. @tgolen, @CortneyOfstad, @dukenv0307, @dominictb eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
mvtglobally commentedon Oct 5, 2024
Issue not reproducible during KI retests. (Second week)
dominictb commentedon Oct 10, 2024
@CortneyOfstad Please handle payment for this.
CortneyOfstad commentedon Oct 14, 2024
Payment Summary
@dominictb — paid $250 via Upwork
@dukenv0307 — paid $250 via Upwork