Skip to content

Xero - App crashes when xero connected account disable 2FA and relog #48262

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.26-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4901080&group_by=cases:section_id&group_id=309134&group_order=asc&group_by=cases:section_id&group_id=309134&group_order=asc
Email or phone of affected tester (no customers): applausetester+gm103061@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Preconditions:
User have 2FA enabled and Xero connected

Steps:

  1. Go to Security> Deactivate 2-FA
  2. Log out
  3. Enter same email address> Continue
  4. Enter the magic code

Expected Result:

App crashes when xero connected account disable 2FA and relog

Actual Result:

User logged without problem

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

2908_2.txt

Bug6586392_1724927647934.Recording__3840.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Aug 29, 2024
  2. melvin-bot commented on Aug 29, 2024

    @melvin-bot

    Triggered auto assignment to @MonilBhavsar (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Aug 29, 2024

    @melvin-bot

    Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. github-actions commented on Aug 29, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. changed the title [-]Web - Xero - App crashes when xero connected account disable 2FA and relog[/-] [+]Xero - App crashes when xero connected account disable 2FA and relog[/+] on Aug 29, 2024
  6. MonilBhavsar commented on Aug 29, 2024

    @MonilBhavsar
    Contributor

    Testing some reverts. The crash is probably because we're ending up in bad navigation state

  7. MonilBhavsar commented on Aug 29, 2024

    @MonilBhavsar
    Contributor

    Tested on staging and it worked!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions