You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-02-18] [$250] Book Travel - Unable to continue setting up travel, error appears #48305
Version Number: v9.0.26-4 Reproducible in staging?: Y Reproducible in production?: Y
Issue was found when executing this PR: #47809 Issue reported by: Applause Internal Team
Action Performed:
Go to https://staging.new.expensify.com/
Create a brand new account.
Green + > Book Travel
Enter a company address -> Press Save
Press Book Travel -> Accept the terms of service -> Press Continue
@joekaufmanexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
@IuliiaHerets I got the applause.expensifail.com domain added to the beta. Going to close this for now as I don't think there is a bug here, but please reopen if you're still experiencing an issue after retesting!
@joekaufmanexpensify I think this is more of a feature request. This started as a backend bug and ended up becoming a feature request. Adding the checklist nevertheless and I think we should add a regression test for the same.
BugZero Checklist:
[Contributor] Classify the bug:
Bug classification
Source of bug:
1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:
Where bug was reported:
2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:
Who reported the bug:
3a. Expensify user
3b. Expensify employee
3c. Contributor
3d. QA
3z. Other:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: NA
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: NA
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Have a new account with spotnanaTravel beta enabled and no workspace created.
Activity
IuliiaHerets commentedon Aug 29, 2024
We think that this bug might be related to #vip-travel
melvin-bot commentedon Aug 29, 2024
Triggered auto assignment to @joekaufmanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.IuliiaHerets commentedon Aug 29, 2024
@joekaufmanexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
Nodebrute commentedon Aug 29, 2024
It's a backend error
User is not on Travel Betajoekaufmanexpensify commentedon Aug 30, 2024
Can't reproduce, works totally fine for me. Seems like the issue was @IuliiaHerets account is not on the beta.
joekaufmanexpensify commentedon Aug 30, 2024
Discussing more here
joekaufmanexpensify commentedon Aug 30, 2024
@IuliiaHerets I got the
applause.expensifail.comdomain added to the beta. Going to close this for now as I don't think there is a bug here, but please reopen if you're still experiencing an issue after retesting!IuliiaHerets commentedon Aug 30, 2024
@joekaufmanexpensify Issue still reproducible. Build - v9.0.26-4, account - applausetester+ihchat4_3008_appa@applause.expensifail.com
bandicam.2024-08-30.17-28-29-312.mp4
joekaufmanexpensify commentedon Aug 30, 2024
@IuliiaHerets can you try again in ~30 minutes? It can sometimes take an hour+ for the beta to take effect.
IuliiaHerets commentedon Aug 30, 2024
@joekaufmanexpensify QA team noticed that the issue can be reproduced with fresh accounts, after refreshing the page it works well. Build - v9.0.26-5, account - applausetester+ihchat4_3008_123@applause.expensifail.com.
bandicam.2024-08-30.20-34-03-405.mp4
148 remaining items
mananjadhav commentedon Feb 17, 2025
Not overdue. This will be paid out tomorrow.
joekaufmanexpensify commentedon Feb 17, 2025
@mananjadhav can you handle checklist as part of prepping for payment?
mananjadhav commentedon Feb 17, 2025
@joekaufmanexpensify I think this is more of a feature request. This started as a backend bug and ended up becoming a feature request. Adding the checklist nevertheless and I think we should add a regression test for the same.
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: NA
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: NA
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
spotnanaTravelbeta enabled and no workspace created.Test:
Do we agree 👍 or 👎
joekaufmanexpensify commentedon Feb 18, 2025
Regression test issue here. Checklist complete.
joekaufmanexpensify commentedon Feb 18, 2025
All set to issue payment. We need to pay:
joekaufmanexpensify commentedon Feb 18, 2025
@shubham1206agra your original offer expired, so I created a new upwork job and sent you an offer. Please accept it so we can pay you.
joekaufmanexpensify commentedon Feb 18, 2025
@mananjadhav please request payment at your earliest convenience.
mananjadhav commentedon Feb 18, 2025
I just did. Thanks.
garrettmknight commentedon Feb 19, 2025
$250 approved for @mananjadhav
joekaufmanexpensify commentedon Feb 19, 2025
@shubham1206agra $250 sent and contract ended!
joekaufmanexpensify commentedon Feb 19, 2025
Upwork job closed.
joekaufmanexpensify commentedon Feb 19, 2025
All set, thanks everyone!