Skip to content

[Due for payment 2025-02-18] [$250] Book Travel - Unable to continue setting up travel, error appears #48305

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.0.26-4
Reproducible in staging?: Y
Reproducible in production?: Y
Issue was found when executing this PR: #47809
Issue reported by: Applause Internal Team

Action Performed:

Go to https://staging.new.expensify.com/
Create a brand new account.
Green + > Book Travel
Enter a company address -> Press Save
Press Book Travel -> Accept the terms of service -> Press Continue

Expected Result:

Expensify Travel page opens

Actual Result:

Error appears and Unable to continue setting

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

bandicam.2024-08-30.01-44-20-821.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01d6db9f1e6d7f6503
  • Upwork Job ID: 1829616128762264680
  • Last Price Increase: 2024-08-30
  • Automatic offers:
    • shubham1206agra | Contributor | 105189846
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @joekaufmanexpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 29, 2024
  2. IuliiaHerets commented on Aug 29, 2024

    @IuliiaHerets
    Author

    We think that this bug might be related to #vip-travel

  3. melvin-bot commented on Aug 29, 2024

    @melvin-bot

    Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. IuliiaHerets commented on Aug 29, 2024

    @IuliiaHerets
    Author

    @joekaufmanexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  5. Nodebrute commented on Aug 29, 2024

    @Nodebrute
    Contributor

    It's a backend error User is not on Travel Beta

  6. joekaufmanexpensify commented on Aug 30, 2024

    @joekaufmanexpensify
    Contributor

    Can't reproduce, works totally fine for me. Seems like the issue was @IuliiaHerets account is not on the beta.

  7. joekaufmanexpensify commented on Aug 30, 2024

    @joekaufmanexpensify
    Contributor

    Discussing more here

  8. joekaufmanexpensify commented on Aug 30, 2024

    @joekaufmanexpensify
    Contributor

    @IuliiaHerets I got the applause.expensifail.com domain added to the beta. Going to close this for now as I don't think there is a bug here, but please reopen if you're still experiencing an issue after retesting!

  9. IuliiaHerets commented on Aug 30, 2024

    @IuliiaHerets
    Author

    @joekaufmanexpensify Issue still reproducible. Build - v9.0.26-4, account - applausetester+ihchat4_3008_appa@applause.expensifail.com

    bandicam.2024-08-30.17-28-29-312.mp4
  10. joekaufmanexpensify commented on Aug 30, 2024

    @joekaufmanexpensify
    Contributor

    @IuliiaHerets can you try again in ~30 minutes? It can sometimes take an hour+ for the beta to take effect.

  11. IuliiaHerets commented on Aug 30, 2024

    @IuliiaHerets
    Author

    @joekaufmanexpensify QA team noticed that the issue can be reproduced with fresh accounts, after refreshing the page it works well. Build - v9.0.26-5, account - applausetester+ihchat4_3008_123@applause.expensifail.com.

    bandicam.2024-08-30.20-34-03-405.mp4
  12. 148 remaining items

  13. mananjadhav commented on Feb 17, 2025

    @mananjadhav
    Collaborator

    Not overdue. This will be paid out tomorrow.

  14. joekaufmanexpensify commented on Feb 17, 2025

    @joekaufmanexpensify
    Contributor

    @mananjadhav can you handle checklist as part of prepping for payment?

  15. mananjadhav commented on Feb 17, 2025

    @mananjadhav
    Collaborator

    @joekaufmanexpensify I think this is more of a feature request. This started as a backend bug and ended up becoming a feature request. Adding the checklist nevertheless and I think we should add a regression test for the same.

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: NA

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: NA

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    • Have a new account with spotnanaTravel beta enabled and no workspace created.

    Test:

    1. Click on FAB Book Travel.
    2. Click on Book travel.
    3. Verify that upgrade flow has started.
    4. Click on Upgrade.
    5. Verify that workspace confirmation page appears.
    6. Fill all the information
    7. Click on Confirm.
    8. Verify that upgrade confirmation screen appears.

    Do we agree 👍 or 👎

  16. joekaufmanexpensify commented on Feb 18, 2025

    @joekaufmanexpensify
    Contributor

    Regression test issue here. Checklist complete.

  17. joekaufmanexpensify commented on Feb 18, 2025

    @joekaufmanexpensify
    Contributor

    All set to issue payment. We need to pay:

  18. joekaufmanexpensify commented on Feb 18, 2025

    @joekaufmanexpensify
    Contributor

    @shubham1206agra your original offer expired, so I created a new upwork job and sent you an offer. Please accept it so we can pay you.

  19. joekaufmanexpensify commented on Feb 18, 2025

    @joekaufmanexpensify
    Contributor

    @mananjadhav please request payment at your earliest convenience.

  20. mananjadhav commented on Feb 18, 2025

    @mananjadhav
    Collaborator

    I just did. Thanks.

  21. garrettmknight commented on Feb 19, 2025

    @garrettmknight
    Contributor

    $250 approved for @mananjadhav

  22. joekaufmanexpensify commented on Feb 19, 2025

    @joekaufmanexpensify
    Contributor

    @shubham1206agra $250 sent and contract ended!

  23. joekaufmanexpensify commented on Feb 19, 2025

    @joekaufmanexpensify
    Contributor

    Upwork job closed.

  24. joekaufmanexpensify commented on Feb 19, 2025

    @joekaufmanexpensify
    Contributor

    All set, thanks everyone!

  25. moved this from Medium - NewDot MVP - Feb '25 to Done in [#whatsnext] #Travelon Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions