You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
iOS - Import spreadsheet - Offline modal does not show up on iOS app only #48580
Version Number: 9.0.29-0 Reproducible in staging?: Y Reproducible in production?: N Email or phone of affected tester (no customers):applausetester+kh010901@applause.expensifail.com Issue reported by: Applause Internal Team
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
Activity
melvin-bot commentedon Sep 4, 2024
Triggered auto assignment to @MonilBhavsar (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Sep 4, 2024
Triggered auto assignment to @kadiealexander (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Sep 4, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Nodebrute commentedon Sep 4, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Import spreadsheet - Offline modal does not show up on iOS app only
What is the root cause of that problem?
We are not using Modal.close here
App/src/pages/workspace/categories/WorkspaceCategoriesPage.tsx
Line 306 in 7aae842
What changes do you think we should make in order to solve the problem?
We can do something like this here .This is the same way we do it here
Optionally we can also add
What alternative solutions did you explore? (Optional)
ishpaul777 commentedon Sep 4, 2024
Edited by proposal-police: This proposal was edited at {current_timestamp}.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Import spreadsheet - Offline modal does not show up on iOS app only
What is the root cause of that problem?
The general pattern is when a new modal is opened we first need to close all other modals in App using
Modal.closewhich is not followed here.
App/src/pages/workspace/categories/WorkspaceCategoriesPage.tsx
Lines 305 to 311 in 7aae842
What changes do you think we should make in order to solve the problem?
We should add a prop
shouldCallAfterModalHidetoisOfflineto this menuitemApp/src/pages/workspace/categories/WorkspaceCategoriesPage.tsx
Lines 302 to 310 in 7aae842
MonilBhavsar commentedon Sep 4, 2024
New feature, and only happening on iOS for offline flow. Not a blocker
MonilBhavsar commentedon Sep 4, 2024
Coming from #47827 cc @filip-solecki @rushatgabhane
If you could please make a follow up
filip-solecki commentedon Sep 5, 2024
Hi! I am Filip from SWM and I'd like to work on this as it comes from my PR
hoangzinh commentedon Sep 12, 2024
Hi @MonilBhavsar, because it ran over regression period, should @rushatgabhane continue to take this issue as a C+ or can I proceed with the PR above?
melvin-bot commentedon Sep 30, 2024
This issue has not been updated in over 15 days. @MonilBhavsar, @kadiealexander, @filip-solecki eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!