Skip to content

Room - Error instructs to invite users to #announce when users cannot be invited to #announce #48831

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.31-5
Reproducible in staging?: Y
Reproducible in production?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp https://expensify.testrail.io/index.php?/tests/view/4938531
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace settings > Members.
  3. Invite more than 8 members.
  4. Go to #announce.
  5. Click on the room header > Members.
  6. On the search field, enter term that will not return result.

Expected Result:

The error message for invalid search term will not show the prompt to invite member using the invite button because users cannot be invited manually in #announce room.

Actual Result:

The error message is "Member not found. To invite a new member to the room, please use the invite button above." when there is no invite button as users cannot be invited manually in #announce room.

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6597926_1725910348020.20240910_032728.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 9, 2024
  2. melvin-bot commented on Sep 9, 2024

    @melvin-bot

    Triggered auto assignment to @yuwenmemon (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Sep 9, 2024

    @melvin-bot

    Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. github-actions commented on Sep 9, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. rayane-d commented on Sep 9, 2024

    @rayane-d
    Contributor

    @Expensify/design What do you think about this bug? Do we need to use a different copy for this case?

  6. rayane-d commented on Sep 9, 2024

    @rayane-d
    Contributor

    cc @paultsimura for visibility

  7. yuwenmemon commented on Sep 9, 2024

    @yuwenmemon
    Contributor

    This is coming from: #47201

  8. 5 remaining items

  9. melvin-bot commented on Sep 9, 2024

    @melvin-bot

    Triggered auto assignment to @shmaxey (Waiting for copy), see https://stackoverflow.com/c/expensify/questions/7025/ for more details.

  10. yuwenmemon commented on Sep 9, 2024

    @yuwenmemon
    Contributor
  11. jamesdeanexpensify commented on Sep 9, 2024

    @jamesdeanexpensify
    Contributor

    (handling in Slack)

  12. dubielzyk-expensify commented on Sep 9, 2024

    @dubielzyk-expensify
    Contributor

    Agree that a simple copy change is enough here

  13. shawnborton commented on Sep 10, 2024

    @shawnborton
    Contributor

    Good catch and I agree with the copy change.

  14. joekaufmanexpensify commented on Sep 17, 2024

    @joekaufmanexpensify
    Contributor

    Payment for the PR from this issue is being handled in: #46838 , so no need to handle any payment here!

  15. melvin-bot commented on Sep 17, 2024

    @melvin-bot

    @yuwenmemon, @jamesdeanexpensify, @kevinksullivan Whoops! This issue is 2 days overdue. Let's get this updated quick!

  16. paultsimura commented on Sep 17, 2024

    @paultsimura
    Contributor

    This one can be closed

  17. joekaufmanexpensify commented on Sep 17, 2024

    @joekaufmanexpensify
    Contributor

    Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringReviewingHas a PR in reviewWaiting for copyUser facing verbiage needs polishing

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions