You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Workspace Feeds] extra digit shown on card limit #48905
Activity
melvin-bot commentedon Sep 10, 2024
Triggered auto assignment to @stephanieelliott (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.cretadn22 commentedon Sep 10, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
extra digit shown on card limit
What is the root cause of that problem?
We use CurrencyUtils.convertAmountToDisplayString function in WorkspaceMemberDetailsPage
App/src/pages/workspace/members/WorkspaceMemberDetailsPage.tsx
Line 280 in fda4e1b
We use CurrencyUtils.convertToDisplayString function in WorkspaceCardListRow
App/src/pages/workspace/expensifyCard/WorkspaceCardListRow.tsx
Line 70 in c4c46fe
What changes do you think we should make in order to solve the problem?
Update to use convertToDisplayString
App/src/pages/workspace/members/WorkspaceMemberDetailsPage.tsx
Line 280 in fda4e1b
What alternative solutions did you explore? (Optional)
Using convertAmountToDisplayString in both places
mountiny commentedon Sep 10, 2024
@allgandalf will handle the PR for this as they work as dedicated C+ for this feature project
mountiny commentedon Sep 10, 2024
PR Merged
allgandalf commentedon Sep 11, 2024
Lets close this issue, the PR was deployed to production