Skip to content

[Workspace Feeds] extra digit shown on card limit #48905

Closed

Description

@kevinksullivan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Reproducible in staging?: Y
Email or phone of affected tester (no customers):

Issue reported by: @kevinksullivan
Slack conversation: https://expensify.slack.com/archives/C036QM0SLJK/p1725978148730949

Action Performed:

  1. Add account to workspaceFeeds beta
  2. Sign in with test account
  3. Select Manage my team’s expenses
  4. Enter any business name / personal name
  5. Navigate to the workspace editor of the newly created workspace
  6. Navigate to More features tab
  7. Toggle on the feature
  8. Navigate to the Expensify Card page
  9. Select Issue new card, give the user a $2 limit
  10. Follow the steps for an OPEN bank account (option 3) of this SO
  11. Finish the setup process
  12. Navigate to members page
  13. Select the member that was assigned a card

Expected Result:

Limit badge should be $2.00

Actual Result:

Limit badge is $2.000

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

image

View all open jobs on GitHub

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 10, 2024
  2. melvin-bot commented on Sep 10, 2024

    @melvin-bot

    Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. cretadn22 commented on Sep 10, 2024

    @cretadn22
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    extra digit shown on card limit

    What is the root cause of that problem?

    We use CurrencyUtils.convertAmountToDisplayString function in WorkspaceMemberDetailsPage

    badgeText={CurrencyUtils.convertAmountToDisplayString(card.nameValuePairs?.unapprovedExpenseLimit)}

    We use CurrencyUtils.convertToDisplayString function in WorkspaceCardListRow
    <Badge text={CurrencyUtils.convertToDisplayString(limit, currency)} />

    What changes do you think we should make in order to solve the problem?

    Update to use convertToDisplayString

    badgeText={CurrencyUtils.convertAmountToDisplayString(card.nameValuePairs?.unapprovedExpenseLimit)}

    What alternative solutions did you explore? (Optional)

    Using convertAmountToDisplayString in both places

  4. mountiny commented on Sep 10, 2024

    @mountiny
    Contributor

    @allgandalf will handle the PR for this as they work as dedicated C+ for this feature project

  5. mountiny commented on Sep 10, 2024

    @mountiny
    Contributor

    PR Merged

  6. allgandalf commented on Sep 11, 2024

    @allgandalf
    Contributor

    Lets close this issue, the PR was deployed to production

  7. removed their assignment
    on Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.ReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions