You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Expense - Green checkmark is shown on the right end of Amount row and not next to Amount #48969
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Yeahhhhhh, I think we can't fix this one with anything else than setting that flex: 0. That brings the question: shouldn't we just try to add flex: 1 specifically to filters' MenuItem? This would solve all the issues that were just raised
Activity
melvin-bot commentedon Sep 11, 2024
Triggered auto assignment to @puneetlath (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Sep 11, 2024
Triggered auto assignment to @lakchote (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Sep 11, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Nodebrute commentedon Sep 11, 2024
Regression from #48456
Nodebrute commentedon Sep 11, 2024
@Guccio163 @rayane-djouah
rayane-d commentedon Sep 11, 2024
Thanks @Nodebrute
rayane-d commentedon Sep 11, 2024
@Guccio163 does this have the same root cause with #48964?
Guccio163 commentedon Sep 11, 2024
Yeahhhhhh, I think we can't fix this one with anything else than setting that
flex: 0. That brings the question: shouldn't we just try to addflex: 1specifically to filters' MenuItem? This would solve all the issues that were just raisedrayane-d commentedon Sep 11, 2024
I agree, let's do it!
Guccio163 commentedon Sep 11, 2024
Great, I moved
flex: 1directly to Advanced Filters file, is this the result that satisfies us @rayane-djouah?If yes, I'll quickly add a PR 😉
rayane-d commentedon Sep 11, 2024
@Guccio163 looks good!
Guccio163 commentedon Sep 11, 2024
PR above solves this issue once it's merged, because it reverts previous interference on MenuItem and hence this section, result is right:
Screen.Recording.2024-09-11.at.13.47.15.mov
Guccio163 commentedon Sep 11, 2024
PR is merged, this issue can be closed