Skip to content

Expense - Green checkmark is shown on the right end of Amount row and not next to Amount #48969

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.32-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp https://expensify.testrail.io/index.php?/tests/view/4945103
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. [User A] Submit an expense to User B.
  3. [User B] Pay the expense.
  4. [User A & User B] Go to the transaction thread.

Expected Result:

Green checkmark will be shown next to the paid amount in the transaction thread (production behavior).

Actual Result:

Green checkmark is shown on the right end of Amount row in the transaction thread.

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6599560_1726029695641.20240911_123854.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 11, 2024
  2. melvin-bot commented on Sep 11, 2024

    @melvin-bot

    Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Sep 11, 2024

    @melvin-bot

    Triggered auto assignment to @lakchote (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. github-actions commented on Sep 11, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. Nodebrute commented on Sep 11, 2024

    @Nodebrute
    Contributor

    Regression from #48456

  6. Nodebrute commented on Sep 11, 2024

    @Nodebrute
    Contributor
  7. rayane-d commented on Sep 11, 2024

    @rayane-d
    Contributor

    Thanks @Nodebrute

  8. rayane-d commented on Sep 11, 2024

    @rayane-d
    Contributor

    @Guccio163 does this have the same root cause with #48964?

  9. Guccio163 commented on Sep 11, 2024

    @Guccio163
    Contributor

    Yeahhhhhh, I think we can't fix this one with anything else than setting that flex: 0. That brings the question: shouldn't we just try to add flex: 1 specifically to filters' MenuItem? This would solve all the issues that were just raised

  10. rayane-d commented on Sep 11, 2024

    @rayane-d
    Contributor

    shouldn't we just try to add flex: 1 specifically to filters' MenuItem? This would solve all the issues that were just raised

    I agree, let's do it!

  11. Guccio163 commented on Sep 11, 2024

    @Guccio163
    Contributor

    Great, I moved flex: 1 directly to Advanced Filters file, is this the result that satisfies us @rayane-djouah?

    Screenshot 2024-09-11 at 13 07 09

    If yes, I'll quickly add a PR 😉

  12. rayane-d commented on Sep 11, 2024

    @rayane-d
    Contributor

    @Guccio163 looks good!

  13. Guccio163 commented on Sep 11, 2024

    @Guccio163
    Contributor

    PR above solves this issue once it's merged, because it reverts previous interference on MenuItem and hence this section, result is right:

    Screen.Recording.2024-09-11.at.13.47.15.mov
  14. Guccio163 commented on Sep 11, 2024

    @Guccio163
    Contributor

    PR is merged, this issue can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions