You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
iOS Copilot - Big empty space next to Full and Access row #48971
Version Number: 9.0.32-0 Reproducible in staging?: Y Reproducible in production?: N/A Email or phone of affected tester (no customers):applausetester+kh010901@applause.expensifail.com Issue reported by: Applause Internal Team
Action Performed:
Launch New Expensify app.
Go to Account settings > Security.
Tap Add copilot.
Select a user > Next.
Expected Result:
There should not be big empty space next to Full and Access row.
Actual Result:
There is big empty space next to Full and Access row.
The device used is iPhone 15 Pro Max.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@rushatgabhane@fedirjh It seems this PR caused this small bug #47353. I was checking the videos and noticed both were posted before we added the description. Don't forget next time to retest everything if changes have been made!
I'm tempted to say we should leave room for the checkmark even when it's not selected, but I don't know that I want to make this a special one-off treatment. Definitely curious for other designers' thoughts on this one. I can see it going either way, but I think leaving room for the checkmark always would probably make it feel a little smoother to switch between options.
Not a bug. In SelectionList, the maxWidth was intentionally added here - #45601 (comment)
I agree that we added this space on purpose to leave room for the checkmark/to prevent the UI from jumping around when you make a selection. But this select list doesn't feel quite right to me for some reason. Should we not have one option pre-selected? Also, it looks like when I do have an option selected, the selected option is missing its background color. cc @Expensify/design for a gut check on all this. We can totally close if this is all expected.
I agree with all of the points Danny is making above! Totally should have a BG color, and totally should have one already selected when you access the list view.
Hmm actually looking at the original design doc mocks, maybe I was wrong and there shouldn't be one selected initially.
We might just be able to close this one. Though I will note that the when you do view the list with a selection, the selected item is still missing a background.
Activity
melvin-bot commentedon Sep 11, 2024
Triggered auto assignment to @OfstadC (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Sep 11, 2024
Triggered auto assignment to @pecanoro (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Sep 11, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
pecanoro commentedon Sep 11, 2024
This is pretty minor, just small styling issue, so removing the blocker label
pecanoro commentedon Sep 11, 2024
@rushatgabhane @fedirjh It seems this PR caused this small bug #47353. I was checking the videos and noticed both were posted before we added the description. Don't forget next time to retest everything if changes have been made!
4 remaining items
pecanoro commentedon Sep 13, 2024
@rushatgabhane Any updates?
rushatgabhane commentedon Sep 16, 2024
Not a bug. In
SelectionList, themaxWidthwas intentionally added here - #45601 (comment)rushatgabhane commentedon Sep 16, 2024
Please close this issue if you agree.
cc: @dannymcclain
dannymcclain commentedon Sep 16, 2024
I agree that we added this space on purpose to leave room for the checkmark/to prevent the UI from jumping around when you make a selection. But this select list doesn't feel quite right to me for some reason. Should we not have one option pre-selected? Also, it looks like when I do have an option selected, the selected option is missing its background color. cc @Expensify/design for a gut check on all this. We can totally close if this is all expected.
CleanShot.2024-09-16.at.08.17.57.mp4
shawnborton commentedon Sep 16, 2024
I agree with all of the points Danny is making above! Totally should have a BG color, and totally should have one already selected when you access the list view.
rushatgabhane commentedon Sep 16, 2024
which option should be selected by default?
dannymcclain commentedon Sep 16, 2024
Hmm actually looking at the original design doc mocks, maybe I was wrong and there shouldn't be one selected initially.

We might just be able to close this one. Though I will note that the when you do view the list with a selection, the selected item is still missing a background.
rushatgabhane commentedon Sep 16, 2024
that has been fixed ✅ will take a few days for deployment
dannymcclain commentedon Sep 16, 2024
Ok in that case I think we should just go ahead and close this one. @shawnborton you good with that?
shawnborton commentedon Sep 16, 2024
Works for me!