Skip to content

iOS Copilot - Big empty space next to Full and Access row #48971

Closed as not planned

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.32-0
Reproducible in staging?: Y
Reproducible in production?: N/A
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

  1. Launch New Expensify app.
  2. Go to Account settings > Security.
  3. Tap Add copilot.
  4. Select a user > Next.

Expected Result:

There should not be big empty space next to Full and Access row.

Actual Result:

There is big empty space next to Full and Access row.
The device used is iPhone 15 Pro Max.

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6599565_1726030208559.ScreenRecording_09-11-2024_12-43-45_1.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 11, 2024
  2. melvin-bot commented on Sep 11, 2024

    @melvin-bot

    Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Sep 11, 2024

    @melvin-bot

    Triggered auto assignment to @pecanoro (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. github-actions commented on Sep 11, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. pecanoro commented on Sep 11, 2024

    @pecanoro
    Contributor

    This is pretty minor, just small styling issue, so removing the blocker label

  6. pecanoro commented on Sep 11, 2024

    @pecanoro
    Contributor

    @rushatgabhane @fedirjh It seems this PR caused this small bug #47353. I was checking the videos and noticed both were posted before we added the description. Don't forget next time to retest everything if changes have been made!

  7. 4 remaining items

  8. pecanoro commented on Sep 13, 2024

    @pecanoro
    Contributor

    @rushatgabhane Any updates?

  9. rushatgabhane commented on Sep 16, 2024

    @rushatgabhane
    Member

    I'm tempted to say we should leave room for the checkmark even when it's not selected, but I don't know that I want to make this a special one-off treatment. Definitely curious for other designers' thoughts on this one. I can see it going either way, but I think leaving room for the checkmark always would probably make it feel a little smoother to switch between options.

    Not a bug. In SelectionList, the maxWidth was intentionally added here - #45601 (comment)

  10. rushatgabhane commented on Sep 16, 2024

    @rushatgabhane
    Member

    Please close this issue if you agree.
    cc: @dannymcclain

  11. dannymcclain commented on Sep 16, 2024

    @dannymcclain
    Contributor

    I agree that we added this space on purpose to leave room for the checkmark/to prevent the UI from jumping around when you make a selection. But this select list doesn't feel quite right to me for some reason. Should we not have one option pre-selected? Also, it looks like when I do have an option selected, the selected option is missing its background color. cc @Expensify/design for a gut check on all this. We can totally close if this is all expected.

    CleanShot.2024-09-16.at.08.17.57.mp4
  12. shawnborton commented on Sep 16, 2024

    @shawnborton
    Contributor

    I agree with all of the points Danny is making above! Totally should have a BG color, and totally should have one already selected when you access the list view.

  13. rushatgabhane commented on Sep 16, 2024

    @rushatgabhane
    Member

    which option should be selected by default?

  14. dannymcclain commented on Sep 16, 2024

    @dannymcclain
    Contributor

    Hmm actually looking at the original design doc mocks, maybe I was wrong and there shouldn't be one selected initially.
    CleanShot 2024-09-16 at 08 36 51@2x

    We might just be able to close this one. Though I will note that the when you do view the list with a selection, the selected item is still missing a background.

  15. rushatgabhane commented on Sep 16, 2024

    @rushatgabhane
    Member

    Though I will note that the when you do view the list with a selection, the selected item is still missing a background.

    that has been fixed ✅ will take a few days for deployment

  16. dannymcclain commented on Sep 16, 2024

    @dannymcclain
    Contributor

    Ok in that case I think we should just go ahead and close this one. @shawnborton you good with that?

  17. shawnborton commented on Sep 16, 2024

    @shawnborton
    Contributor

    Works for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions