You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Login - Get Started tooltip shows again when existing users log in #48985
Version Number: 9.0.32-1 Reproducible in staging?: Y Reproducible in production?: N/A - new feature, doesn't exist in prod (Green tooltip not seen in the production) Issue was found when executing this PR:#48963 Email or phone of affected tester (no customers):biruknew45+4375@gmail.com Issue reported by: Applause Internal Team
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
The "Get Started" tooltip should only appear when logging in for the first time.
Ah hmm I sort of disagree that this should be the expectation. The feature is intended to work like this:
New user signs up
Next time they re-authenticate we will set the nvp to false (which takes a couple of hours)
Is that so bad? It's not a normal experience to immediately sign out after you sign in so I don't feel strongly that we should optimize for this. I can't think of a great reason why it should work that way since this is only used to show a tool tip and it's probably "fine" to treat the user as "new" until some time passes and they re-auth.
I agree with @marcaaron here; it's not going to be the normal flow for a user to sign up and then immediately log back out - and even if they do, it's not very intrusive to just see the tooltips again.
I don't feel it's something we need to spend time modifying right now — though if we do end up wanting to change this, we can update the isFirstTimeNewExpensifyUser NVP to be set to false when the user logs out since that's an explicit action they'll take that stops them from being "new."
Let's close for now and re-visit if/when this comes up again.
Activity
melvin-bot commentedon Sep 11, 2024
Triggered auto assignment to @NikkiWines (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Sep 11, 2024
Triggered auto assignment to @zanyrenney (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Sep 11, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
andriivitiv commentedon Sep 11, 2024
This also happens on desktop Chrome and sometimes appears multiple times (no repro steps)
tienifr commentedon Sep 11, 2024
@IuliiaHerets @NikkiWines It's BE bug. The second login still return
nvp_isFirstTimeNewExpensifyUseras trueweb-resize.mp4
luacmartins commentedon Sep 11, 2024
I'm gonna demote it from being an App blocker since the fix seems to be in Auth and the bug is minor.
zanyrenney commentedon Sep 11, 2024
does it need to stay hourly then @luacmartins ?
NikkiWines commentedon Sep 11, 2024
I think this can probably be a daily, I'm looking into it today
marcaaron commentedon Sep 11, 2024
Ah hmm I sort of disagree that this should be the expectation. The feature is intended to work like this:
Is that so bad? It's not a normal experience to immediately sign out after you sign in so I don't feel strongly that we should optimize for this. I can't think of a great reason why it should work that way since this is only used to show a tool tip and it's probably "fine" to treat the user as "new" until some time passes and they re-auth.
marcaaron commentedon Sep 11, 2024
The larger issue here might be that neither myself or @NikkiWines could get this tooltip to show up at all 😄
NikkiWines commentedon Sep 11, 2024
I agree with @marcaaron here; it's not going to be the normal flow for a user to sign up and then immediately log back out - and even if they do, it's not very intrusive to just see the tooltips again.
I don't feel it's something we need to spend time modifying right now — though if we do end up wanting to change this, we can update the
isFirstTimeNewExpensifyUserNVP to be set tofalsewhen the user logs out since that's an explicit action they'll take that stops them from being "new."Let's close for now and re-visit if/when this comes up again.