Skip to content

Login - Get Started tooltip shows again when existing users log in #48985

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.32-1
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod (Green tooltip not seen in the production)
Issue was found when executing this PR: #48963
Email or phone of affected tester (no customers): biruknew45+4375@gmail.com
Issue reported by: Applause Internal Team

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Log in with a new account.
  3. The "Get Started" tooltip appears. Tap on it and read the Concierge chat.
  4. Create a workspace.
  5. Log out.
  6. Log back in with the same account.

Expected Result:

The "Get Started" tooltip should only appear when logging in for the first time.

Actual Result:

The Get Started tooltip appears even when the existing user logs in during step 6.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6599925_1726059708744!1

Bug6599925_1726059708716.1.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Sep 11, 2024
  2. melvin-bot commented on Sep 11, 2024

    @melvin-bot

    Triggered auto assignment to @NikkiWines (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Sep 11, 2024

    @melvin-bot

    Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. github-actions commented on Sep 11, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. andriivitiv commented on Sep 11, 2024

    @andriivitiv
    Contributor

    This also happens on desktop Chrome and sometimes appears multiple times (no repro steps)

    Screenshot 2024-09-11 at 16 42 59
  6. tienifr commented on Sep 11, 2024

    @tienifr
    Contributor

    @IuliiaHerets @NikkiWines It's BE bug. The second login still return nvp_isFirstTimeNewExpensifyUser as true

    web-resize.mp4
  7. luacmartins commented on Sep 11, 2024

    @luacmartins
    Contributor

    I'm gonna demote it from being an App blocker since the fix seems to be in Auth and the bug is minor.

  8. zanyrenney commented on Sep 11, 2024

    @zanyrenney
    Contributor

    does it need to stay hourly then @luacmartins ?

  9. NikkiWines commented on Sep 11, 2024

    @NikkiWines
    Contributor

    I think this can probably be a daily, I'm looking into it today

  10. added
    InternalRequires API changes or must be handled by Expensify staff
    and removed on Sep 11, 2024
  11. marcaaron commented on Sep 11, 2024

    @marcaaron
    Contributor

    The "Get Started" tooltip should only appear when logging in for the first time.

    Ah hmm I sort of disagree that this should be the expectation. The feature is intended to work like this:

    • New user signs up
    • Next time they re-authenticate we will set the nvp to false (which takes a couple of hours)

    Is that so bad? It's not a normal experience to immediately sign out after you sign in so I don't feel strongly that we should optimize for this. I can't think of a great reason why it should work that way since this is only used to show a tool tip and it's probably "fine" to treat the user as "new" until some time passes and they re-auth.

  12. marcaaron commented on Sep 11, 2024

    @marcaaron
    Contributor

    The larger issue here might be that neither myself or @NikkiWines could get this tooltip to show up at all 😄

  13. NikkiWines commented on Sep 11, 2024

    @NikkiWines
    Contributor

    I agree with @marcaaron here; it's not going to be the normal flow for a user to sign up and then immediately log back out - and even if they do, it's not very intrusive to just see the tooltips again.

    I don't feel it's something we need to spend time modifying right now — though if we do end up wanting to change this, we can update the isFirstTimeNewExpensifyUser NVP to be set to false when the user logs out since that's an explicit action they'll take that stops them from being "new."

    Let's close for now and re-visit if/when this comes up again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringInternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions