Skip to content

[HOLD for payment 2025-01-15] [$125] [Pending / Scanning] If multiple receipts are scanning in a report, update the copy of the preview component to be plural (i.e. "receipts scanning") #49054

Closed

Description

@kevinksullivan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue reported by: @kevinksullivan
Slack conversation: https://expensify.slack.com/archives/C036QM0SLJK/p1726065881464109

Action Performed:

  1. Create a workspace
  2. Scan a receipt and submit it to that workspace
  3. Immediately scan another receipt and submit it to that workspace

Expected Result:

The report preview component should say "Receipts scanning" as there are multiple on the report

Actual Result:

The report preview says "Receipt scanning"

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

image

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021834189848594534997
  • Upwork Job ID: 1834189848594534997
  • Last Price Increase: 2024-12-10
  • Automatic offers:
    • nyomanjyotisa | Contributor | 105368332
Issue OwnerCurrent Issue Owner: @isabelastisser

Activity

  1. added
    NewFeatureSomething to build that is a new item.
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 12, 2024
  2. melvin-bot commented on Sep 12, 2024

    @melvin-bot

    Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Sep 12, 2024

    @melvin-bot

    Triggered auto assignment to @kadiealexander (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

  4. changed the title [-][Pending / Scanning] If multiple receipts are scanning in a report, update the copy of the preview component to be plural (i.e. "receipts scanning")[/-] [+][$125] [Pending / Scanning] If multiple receipts are scanning in a report, update the copy of the preview component to be plural (i.e. "receipts scanning")[/+] on Sep 12, 2024
  5. melvin-bot commented on Sep 12, 2024

    @melvin-bot

    ⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

  6. trjExpensify commented on Sep 12, 2024

    @trjExpensify
    Contributor

    Should be a simple task.

  7. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Sep 12, 2024
  8. 108 remaining items

  9. MariaHCD commented on Jan 14, 2025

    @MariaHCD
    Contributor

    Not overdue - we just need the BZ checklist to move forward here

  10. isabelastisser commented on Jan 14, 2025

    @isabelastisser
    Contributor

    BugZero Checklist:

    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [@eh2077] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment:

    • [@eh2077 ] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [@eh2077 ] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal Template
    • [@isabelastisser ] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    Test:

    Do we agree 👍 or 👎

  11. isabelastisser commented on Jan 14, 2025

    @isabelastisser
    Contributor

    @eh2077, please complete the checklist before the payment can be processed. Thanks!

  12. isabelastisser commented on Jan 15, 2025

    @isabelastisser
    Contributor

    Bump @eh2077 to complete the checklist. Thanks!

  13. eh2077 commented on Jan 16, 2025

    @eh2077
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/App/pull/24235/files#r1918697408

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    No, we don't need to add regression test here because the fix is straightforward.

  14. eh2077 commented on Jan 16, 2025

    @eh2077
    Contributor

    @isabelastisser Done, thanks for the ping!

  15. isabelastisser commented on Jan 16, 2025

    @isabelastisser
    Contributor

    Payment summary:

    @nyomanjyotisa automatic offer (Contributor) $125 - paid in Upwork.
    @eh2077 requires payment through NewDot Manual Requests C+ $125 pending

  16. shubham1206agra commented on Jan 16, 2025

    @shubham1206agra
    Contributor

    @isabelastisser The issue is marked for $125. Can you double-check the payment summary?

  17. isabelastisser commented on Jan 17, 2025

    @isabelastisser
    Contributor

    @shubham1206agra, my confusion, sorry! updated!

  18. JmillsExpensify commented on Jan 22, 2025

    @JmillsExpensify
    Contributor

    $125 approved for @eh2077

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorretest-weeklyApply this label if you want this issue tested on a Weekly basis by Applause

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions