Skip to content

[HOLD for payment 2021-12-13] URL link is mangled up with the rest of the text #4911

Closed

Description

@sketchydroide

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Wrote Chronos 10am update on desktop
  2. Added GH links to the update
  3. submitted
  4. opened conversation on mobile iOS
  5. Links are on top of the other text

Expected Result:

The links should take their own space

Actual Result:

Link is on top of the normal text

Workaround:

N/A

Platform:

Where is this issue occurring?

  • iOS
  • Android (not sure, I haven't checked)

Version Number:
V1.0.86-4
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
IMG_3582
Expensify/Expensify Issue URL:

View all open jobs on GitHub

Activity

  1. MelvinBot commented on Aug 30, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @michaelhaxhiu (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

  2. added and removed
    AutoAssignerTriageAuto assign issues for triage to an available triage team member
    on Aug 30, 2021
  3. michaelhaxhiu commented on Sep 1, 2021

    @michaelhaxhiu
    Contributor

    @mallenexpensify I have searched titles with various naming conventions, but can't find another GH that looks like this one. Before I push this through, I'd love a buddy check from you 🙏 . Have you come across this before? I feel like I've seen it once before but can't tell if I'm crazy or not.

  4. sketchydroide commented on Sep 1, 2021

    @sketchydroide
    ContributorAuthor

    This happened when I added a url to my 10ams

  5. mallenexpensify commented on Sep 1, 2021

    @mallenexpensify
    Contributor

    @michaelhaxhiu yup! Saw for the first time last night or this morn. iOS v1.0.90-4
    image
    I'll move it along since you're likely already off Hax

  6. MelvinBot commented on Sep 1, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @johnmlee101 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  7. michaelhaxhiu commented on Sep 2, 2021

    @michaelhaxhiu
    Contributor

    @sketchydroide sorry for the confusion, I agree this is a real problem (I reproduced it myself 😄) but was trying to make sure it wasn't a duplicate. We are all set, thanks Matt!

  8. 94 remaining items

  9. jboniface commented on Nov 22, 2021

    @jboniface

    Considering you're hired on both jobs, you'd get paid for both jobs, right? We wouldn't invalidate one just because the same PR solved both issues (although we might not have filed both jobs if we knew this ahead of time). Do you think we should pay out more than the reward for both the jobs? In my opinion, the other issue was on n6-hold and you had a solution during the hold, so that one should be 500. This one would be 250. So 750 for one PR -- that seems like a fair deal. What do you think?

  10. mountiny commented on Nov 22, 2021

    @mountiny
    Contributor

    @parasharrajat I will make sure you are also hired for the other issue as well. Then just make sure to link both of the issues in the PR 🙌

  11. parasharrajat commented on Nov 22, 2021

    @parasharrajat
    Member

    If I am hired for other as well. Then it's fine.

    Thanks @mountiny.

  12. mountiny commented on Nov 22, 2021

    @mountiny
    Contributor

    Perfect! No worries and thank you for digging into this and the related issue 🙌

  13. jboniface commented on Nov 30, 2021

    @jboniface

    on staging

  14. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Dec 6, 2021
  15. changed the title [-]URL link is mangled up with the rest of the text[/-] [+][HOLD for payment 2021-12-13] URL link is mangled up with the rest of the text[/+] on Dec 6, 2021
  16. botify commented on Dec 6, 2021

    @botify

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.17-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2021-12-13. 🎊

  17. jboniface commented on Dec 13, 2021

    @jboniface

    @parasharrajat will pay when you accept, sorry I missed the proposal earlier

  18. jboniface commented on Dec 13, 2021

    @jboniface

    paid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionEngineeringExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions