Skip to content

[UX Reliability] Improve the bottom modal animations quality and reliability on native and mWeb platforms #49354

Closed

Description

@mountiny

Problem

Coming from this thread to bring the NewDot on par with other chat platforms, we need to make sure the modal experience feels fast and the animations are smooth without any lags. Right now the most noticeable lag is happening on the bottom drawers that are often used:

  • composer action modal to add attachments or to submit expenses in a chat
  • opening or closing the emoji keyboard
  • Opening and closing the keyboard - this is not that bad but it also could be improved
  • Opening FAB on the main page - the animation is relatively smooth here but its something to monitor too
  • Opening more options modal on a comment with long press and then going to edit a message. Saving the edit later. In this flow the modal is opening and closing multiple times with keyboard popping up and down in not smooth fashion

Solution

Let's ask the @Expensify/design team if we want to explore some non-linear animation easing for these modals. Later (I would say not in the scope of this project), we could explore the bounce effect too for some of these animations.

  1. Pick a medium range ios and android device on which we would test
  2. Analyse the existing animations, measure its fps and set the baseline of measurements of where we at
  3. Research options on what will be the best way to improve this and get us to smooth 60fps animations all the time on the device picked in 1.
  4. Discuss the solutions to pick the best one that will work on native and mWeb as well (in the narrow mode where we use the same modal)
  5. Implement it and make sure we are able to keep the good animation performance in real world use.

cc @BartoszGrajdek

Issue OwnerCurrent Issue Owner: @NicMendonca

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 17, 2024
  2. self-assigned this
    on Sep 17, 2024
  3. melvin-bot commented on Sep 17, 2024

    @melvin-bot

    Current assignee @mountiny is eligible for the AutoAssignerNewDotQuality assigner, not assigning anyone new.

  4. melvin-bot commented on Sep 17, 2024

    @melvin-bot

    Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. melvin-bot commented on Sep 17, 2024

    @melvin-bot

    Triggered auto assignment to @shawnborton (Design), see these Stack Overflow questions for more details.

  6. BartoszGrajdek commented on Sep 17, 2024

    @BartoszGrajdek
    Contributor

    Hi! I'm Bartosz from SWM and I'll be working on this issue! 😄

  7. shawnborton commented on Sep 18, 2024

    @shawnborton
    Contributor

    Let's ask the @Expensify/design team if we want to explore some non-linear animation easing for these modals.

    Big fan of that! I think the answer is yes, we do want to explore that.

  8. 319 remaining items

  9. ZhenjaHorbach commented on Jun 19, 2025

    @ZhenjaHorbach
    Contributor

    @ZhenjaHorbach Can you please confirm if any of the PRs been to fix the regressions listed?

    I did't add regression PRs to the list which I reviewed

  10. ZhenjaHorbach commented on Jun 19, 2025

    @ZhenjaHorbach
    Contributor

    But wait
    Maybe only this
    #62397
    We made global changes in this PR
    But after this regression we decided to revert a part of changes and make updated changes in a separate PR

    But otherwise I did't add regression fixes to the list of PRs which I reviewed

  11. mountiny commented on Jun 19, 2025

    @mountiny
    ContributorAuthor

    Alright, thank you! This was a long issue that lasted many months, so it seems like we have 18PRs—18250 = 4500 now minus 7 regressions ($125 each), which is 7125 = 875, so the total is 4500-875=$3625.

    The payment total for @ZhenjaHorbach for this entire initiative would be $3625. This seems reasonable, given that the project took 8-9 months to complete.

    @NicMendonca, could you help us with the payout, please?

  12. ZhenjaHorbach commented on Jun 19, 2025

    @ZhenjaHorbach
    Contributor

    Alright, thank you! This was a long issue that lasted many months, so it seems like we have 18PRs—18_250 = 4500 now minus 7 regressions ($125 each), which is 7_125 = 875, so the total is 4500-875=$3625.

    The payment total for @ZhenjaHorbach for this entire initiative would be $3625. This seems reasonable, given that the project took 8-9 months to complete.

    @NicMendonca, could you help us with the payout, please?

    Sounds good !
    Thanks a lot !

  13. ZhenjaHorbach commented on Jul 2, 2025

    @ZhenjaHorbach
    Contributor

    @NicMendonca
    We are ready to payment here !

  14. changed the title [-][Payment on hold] [UX Reliability] Improve the bottom modal animations quality and reliability on native and mWeb platforms[/-] [+][UX Reliability] Improve the bottom modal animations quality and reliability on native and mWeb platforms[/+] on Jul 4, 2025
  15. NicMendonca commented on Jul 4, 2025

    @NicMendonca
    Contributor

    Payment summary

    Contributor+: @ZhenjaHorbach - $3,625 paid via NewDot

    Payment math laid out here.

  16. ZhenjaHorbach commented on Jul 4, 2025

    @ZhenjaHorbach
    Contributor

    Requested in ND !

  17. garrettmknight commented on Jul 21, 2025

    @garrettmknight
    Contributor

    $3,625 approved for @ZhenjaHorbach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

AutoAssignerNewDotQualityUsed to assign quality issues to engineersAwaiting PaymentAuto-added when associated PR is deployed to productionDesignNewFeatureSomething to build that is a new item.ReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions