You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] [CVP] Account is validated but still being asked to validate to add a VBBA #49813
@muttmuure FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
changed the title [-]Desktop - Bank account - Web page opened from the app asks to validate my expensifail account[/-][+][CVP] Desktop - Bank account - Web page opened from the app asks to validate my expensifail account[/+]on Oct 1, 2024
But I've also checked if the validation error will be shown after creating a new account on the web (and not validating it) and the message is not shown:
I think in this case we want it shown, don't we?
I see that some changes were introduced by this PR #51718. The message should be shown because there is a check for account.validated, but for some reason it doesn't.
I'll be working on refactoring the first step of enabling bank account #50422#51799 - because there are many issues with this step, so I also can fix it there.
And I've noticed that we have 2 ways of informing that the workspace currency is not set to USD
for the Expensify Card it looks like this:
and for the workflows:
Is there any reason that for the workflows we have only this info in the RHP and we cannot do this in the modal like for ECard? Or should we make it consistent?
I don't think I have strong feelings here, but I always love airing on the side of consistency. cc @Expensify/design @trjExpensify for the quick check here as well.
For the connect bank flow, I assume what's happening is that you click on the connect bank account row and you immediately see the RHP with the message about currency? If it's really the first step in the flow like that, I don't see why it couldn't be a modal either to match the Expensify Card page.
Interestingly, in the global reimbursement doc, we decided not to show the "Connect bank account" row if the workspace currency isn't USD, GBP, EUR, AUD or CAD (supported currencies for global reimbursement):
We could pull that out to move forward with it for non-USD for now, and extend it to the other currencies when global reimbursement is implemented? CC: @madmax330 for vis.
But I've also checked if the validation error will be shown after creating a new account on the web (and not validating it) and the message is not shown:
I'm not quite following this. Here's a test on staging web, am I missing something?
I'm not super passionate but I feel the same as Shawn. If we can make them consistent I think that'd probably be best, and I'd vote for standardizing on the modal approach from the Expensify Card page. I'm happy to defer to what Tom thinks is best though.
@trjExpensify aaah ok, because of this new feature we no longer have to display this message:
(I meant that this message is not displayed for the accounts that have not been validated)
We could pull that out to move forward with it for non-USD for now, and extend it to the other currencies when global reimbursement is implemented? CC: @madmax330 for vis.
@madmax330 let us know about the status of this one, and potentially expediting it for non-USD.
Activity
melvin-bot commentedon Sep 26, 2024
Triggered auto assignment to @muttmuure (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.IuliiaHerets commentedon Sep 26, 2024
We think that this bug might be related to #wave-collect - Release 1
IuliiaHerets commentedon Sep 26, 2024
@muttmuure FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
melvin-bot commentedon Sep 30, 2024
@muttmuure Whoops! This issue is 2 days overdue. Let's get this updated quick!
[-]Desktop - Bank account - Web page opened from the app asks to validate my expensifail account[/-][+][CVP] Desktop - Bank account - Web page opened from the app asks to validate my expensifail account[/+]48 remaining items
trjExpensify commentedon Nov 1, 2024
Hm, interesting. @koko57 can you give it a re-test and confirm that?
deetergp commentedon Nov 6, 2024
Any word on the retest @koko57?
koko57 commentedon Nov 7, 2024
@trjExpensify @deetergp Sorry I missed Tom's message as I was ooo that day. Will retest today
koko57 commentedon Nov 7, 2024
The original problem is fixed, works ok:
https://github.com/user-attachments/assets/ece7e513-ab86-4c17-8ddc-fbf0d71b7068
But I've also checked if the validation error will be shown after creating a new account on the web (and not validating it) and the message is not shown:
I think in this case we want it shown, don't we?
I see that some changes were introduced by this PR #51718. The message should be shown because there is a check for account.validated, but for some reason it doesn't.
I'll be working on refactoring the first step of enabling bank account #50422 #51799 - because there are many issues with this step, so I also can fix it there.
koko57 commentedon Nov 7, 2024
And I've noticed that we have 2 ways of informing that the workspace currency is not set to USD
for the Expensify Card it looks like this:

and for the workflows:

Is there any reason that for the workflows we have only this info in the RHP and we cannot do this in the modal like for ECard? Or should we make it consistent?
cc @shawnborton
shawnborton commentedon Nov 7, 2024
I don't think I have strong feelings here, but I always love airing on the side of consistency. cc @Expensify/design @trjExpensify for the quick check here as well.
For the connect bank flow, I assume what's happening is that you click on the connect bank account row and you immediately see the RHP with the message about currency? If it's really the first step in the flow like that, I don't see why it couldn't be a modal either to match the Expensify Card page.
trjExpensify commentedon Nov 7, 2024
Interestingly, in the global reimbursement doc, we decided not to show the "Connect bank account" row if the workspace currency isn't USD, GBP, EUR, AUD or CAD (supported currencies for global reimbursement):
We could pull that out to move forward with it for non-USD for now, and extend it to the other currencies when global reimbursement is implemented? CC: @madmax330 for vis.
trjExpensify commentedon Nov 7, 2024
I'm not quite following this. Here's a test on staging web, am I missing something?
2024-11-07_13-28-21.mp4
dannymcclain commentedon Nov 7, 2024
I'm not super passionate but I feel the same as Shawn. If we can make them consistent I think that'd probably be best, and I'd vote for standardizing on the modal approach from the Expensify Card page. I'm happy to defer to what Tom thinks is best though.
koko57 commentedon Nov 8, 2024
@trjExpensify aaah ok, because of this new feature we no longer have to display this message:

(I meant that this message is not displayed for the accounts that have not been validated)
trjExpensify commentedon Nov 8, 2024
Yep, exactly!
koko57 commentedon Nov 8, 2024
@trjExpensify ok, so the original bug is fixed, this issue can be closed 🙂
trjExpensify commentedon Nov 8, 2024
Great stuff!
@madmax330 let us know about the status of this one, and potentially expediting it for non-USD.