Skip to content

[$250] [CVP] Account is validated but still being asked to validate to add a VBBA #49813

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.39-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4992364&group_by=cases:section_id&group_order=asc&group_id=283225
Issue reported by: Applause Internal Team

Action Performed:

  1. Open the app
  2. Log in with a new Expensifail account
  3. Create a workspace
  4. Navigate to Workspace settings - More features
  5. Enable "Workflows"
  6. Navigate to Workflows - Connect bank account
  7. Click on the note to open the process in a browser

Expected Result:

The account is already validated so the message shouldn't appear.

Actual Result:

Web page opened from the app asks to validate my expensifail account.

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6610078_1726848225304.Screen_Recording_2024-09-20_At_8.50.37.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021841225609645325117
  • Upwork Job ID: 1841225609645325117
  • Last Price Increase: 2024-10-01
  • Automatic offers:
    • suneox | Reviewer | 104246212

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 26, 2024
  2. melvin-bot commented on Sep 26, 2024

    @melvin-bot

    Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. IuliiaHerets commented on Sep 26, 2024

    @IuliiaHerets
    Author

    We think that this bug might be related to #wave-collect - Release 1

  4. IuliiaHerets commented on Sep 26, 2024

    @IuliiaHerets
    Author

    @muttmuure FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  5. melvin-bot commented on Sep 30, 2024

    @melvin-bot

    @muttmuure Whoops! This issue is 2 days overdue. Let's get this updated quick!

  6. changed the title [-]Desktop - Bank account - Web page opened from the app asks to validate my expensifail account[/-] [+][CVP] Desktop - Bank account - Web page opened from the app asks to validate my expensifail account[/+] on Oct 1, 2024
  7. 48 remaining items

  8. trjExpensify commented on Nov 1, 2024

    @trjExpensify
    Contributor

    Hm, interesting. @koko57 can you give it a re-test and confirm that?

  9. deetergp commented on Nov 6, 2024

    @deetergp
    Contributor

    Any word on the retest @koko57?

  10. koko57 commented on Nov 7, 2024

    @koko57
    Contributor

    @trjExpensify @deetergp Sorry I missed Tom's message as I was ooo that day. Will retest today

  11. koko57 commented on Nov 7, 2024

    @koko57
    Contributor

    The original problem is fixed, works ok:
    https://github.com/user-attachments/assets/ece7e513-ab86-4c17-8ddc-fbf0d71b7068

    But I've also checked if the validation error will be shown after creating a new account on the web (and not validating it) and the message is not shown:

    Screenshot 2024-11-07 at 09 52 02

    I think in this case we want it shown, don't we?

    I see that some changes were introduced by this PR #51718. The message should be shown because there is a check for account.validated, but for some reason it doesn't.

    I'll be working on refactoring the first step of enabling bank account #50422 #51799 - because there are many issues with this step, so I also can fix it there.

  12. koko57 commented on Nov 7, 2024

    @koko57
    Contributor

    And I've noticed that we have 2 ways of informing that the workspace currency is not set to USD

    for the Expensify Card it looks like this:
    Screenshot 2024-11-07 at 09 41 07

    and for the workflows:
    Screenshot 2024-11-07 at 09 40 45

    Is there any reason that for the workflows we have only this info in the RHP and we cannot do this in the modal like for ECard? Or should we make it consistent?

    cc @shawnborton

  13. shawnborton commented on Nov 7, 2024

    @shawnborton
    Contributor

    I don't think I have strong feelings here, but I always love airing on the side of consistency. cc @Expensify/design @trjExpensify for the quick check here as well.

    For the connect bank flow, I assume what's happening is that you click on the connect bank account row and you immediately see the RHP with the message about currency? If it's really the first step in the flow like that, I don't see why it couldn't be a modal either to match the Expensify Card page.

  14. trjExpensify commented on Nov 7, 2024

    @trjExpensify
    Contributor

    Interestingly, in the global reimbursement doc, we decided not to show the "Connect bank account" row if the workspace currency isn't USD, GBP, EUR, AUD or CAD (supported currencies for global reimbursement):

    image

    We could pull that out to move forward with it for non-USD for now, and extend it to the other currencies when global reimbursement is implemented? CC: @madmax330 for vis.

  15. trjExpensify commented on Nov 7, 2024

    @trjExpensify
    Contributor

    But I've also checked if the validation error will be shown after creating a new account on the web (and not validating it) and the message is not shown:

    I'm not quite following this. Here's a test on staging web, am I missing something?

    2024-11-07_13-28-21.mp4
  16. dannymcclain commented on Nov 7, 2024

    @dannymcclain
    Contributor

    I'm not super passionate but I feel the same as Shawn. If we can make them consistent I think that'd probably be best, and I'd vote for standardizing on the modal approach from the Expensify Card page. I'm happy to defer to what Tom thinks is best though.

  17. koko57 commented on Nov 8, 2024

    @koko57
    Contributor

    @trjExpensify aaah ok, because of this new feature we no longer have to display this message:
    Screenshot 2024-11-08 at 10 31 21
    (I meant that this message is not displayed for the accounts that have not been validated)

  18. trjExpensify commented on Nov 8, 2024

    @trjExpensify
    Contributor

    Yep, exactly!

  19. koko57 commented on Nov 8, 2024

    @koko57
    Contributor

    @trjExpensify ok, so the original bug is fixed, this issue can be closed 🙂

  20. trjExpensify commented on Nov 8, 2024

    @trjExpensify
    Contributor

    Great stuff!

    We could pull that out to move forward with it for non-USD for now, and extend it to the other currencies when global reimbursement is implemented? CC: @madmax330 for vis.

    @madmax330 let us know about the status of this one, and potentially expediting it for non-USD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2InternalRequires API changes or must be handled by Expensify staffReviewingHas a PR in review

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions