Repository navigation
Description
P/S authored by @staszekscp here
Problem
The TTI on HybridApp is longer than on a standalone NewDot application. In order to determine if a specific user should go to NewDot, HybridApp has to boot OldDot code first. The business logic for OldDot was written in JS in a framework called YAPL, and it runs on JSC.
Potentially also resolves:
Solution
Let’s replace JSC with Hermes! Hermes is known for its advantage over JSC in initial boot time, and it became a standard in the React Native world. Since YAPL is written in JS, theoretically should be able to do that, and get rid of JSC from the project. As bonus the app size would become smaller, too. 💪:skin-tone-2: 🚀
However, I’d like to emphasise that, since YAPL has been written in legacy JavaScript (mostly pre ES2015) there is a chance that the migration may become very time-consuming. Nevertheless I think it is worth to do at least a research, and see how far we can get, because it will speed up the both, OldDot, and HybridApp!
Mateusz' updated Solution
Adjust the current authentication flow on HybridApp to replace the OldDot sign-in page with the NewDot version.
- Currently, we perform authentication on the OldDot side and pass all necessary credentials to enable the New Experience and handle authentication/re-authentication. We could reverse this by using the NewDot sign-in page to generate all required credentials. These credentials could then be used to authenticate on the OldDot side. To trigger authentication on YAPL side, native methods can be used.
- We also need to decide at the start of sign-in whether the user should be redirected to OldDot or NewDot. The
SignInUsercommand should return an additional field withnvp_tryNewDot, allowing us to determine based on the value of thedismissedkey whether to stay on NewDot or transition to OldDot. - Another important aspect from the user’s perspective is error handling. OldDot initialisation might fail, so we should be able to display errors on the SignIn page, just as we do when NewDot authentication fails. We can track OldDot initialisation through native events and store the current state in Onyx. Errors returned by OldDot’s API can then be passed via these events and displayed on the NewDot SignIn page
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021933575711850825609
- Upwork Job ID: 1933575711850825609
- Last Price Increase: 2025-06-13
Issue Owner
Current Issue Owner: @Issue Owner
Current Issue Owner: @sonialiapMetadata
Metadata
Labels
Type
Projects
- StatusShow more project fieldsDone
Activity
staszekscp commentedon Sep 27, 2024
Hey! With @WoLewicki we'll be working on this issue!
[-]Improve HybridApp TTI[/-][+][HybridApp] Improve HybridApp TTI[/+][-][HybridApp] Improve HybridApp TTI[/-][+][HybridApp] Investigate improvement of HybridApp TTI[/+][-][HybridApp] Investigate improvement of HybridApp TTI[/-][+][HybridApp] Investigate improvement to HybridApp TTI[/+]241 remaining items
Julesssss commentedon Aug 19, 2025
The feature PRs are testing well and I have asked QA to run through our test cases once before we merge the feature.
Julesssss commentedon Aug 20, 2025
QA testing in progress.
Julesssss commentedon Aug 21, 2025
QA results here 🎉
Everything seems good to me. We have minor issues on specific platforms but nothing worth blocking over. One deep-link issue is unable to be verified on adhoc builds so we'll test on staging. Just running a final build with updated main before merging. -- I'll also verify notification registration on Android that Marcin highlighted here
Julesssss commentedon Aug 21, 2025
We're just about to merge the feature branches. I'm just waiting for the current checklist to ship to give us a bit longer. We're also blocked by our 1pass rate limit... I should be merging tomorrow.
Julesssss commentedon Aug 22, 2025
I ran a final test today and noticed two related issues on Android signin that will block the PRs a little bit longer. They shouldn't be too complex as we solved a similar issue previously.
Will check in on Monday, but we're still very close to shipping the feature.
danielrvidal commentedon Aug 25, 2025
Awesome, looking forward to it!
Julesssss commentedon Aug 25, 2025
The Sign-in feature tested great for me today with the new fixes 🎉
I have merged the feature and it'll hit staging with the next App release (hopefully today/tomorrow). We'll keep on top of any new issues that are noticed with the full regression test suite.
trjExpensify commentedon Aug 26, 2025
🤞 🤞 let's go!!
Julesssss commentedon Aug 26, 2025
Looking good so far. Here are the issues I have noticed:
_NativeReactNativeHybridApp.default.clearOldDotAfterSignOut is not a functionJulesssss commentedon Aug 27, 2025
Both deploy blockers have been fixed and Mateusz is making progress on the remaining low priority issue that won't block deployment to prod. QA have finished testing so we're looking good!
Julesssss commentedon Aug 28, 2025
NewDot authentication feature is on production 🤩
Due to the size of this we had quite a few signin related bugs held on this. After retesting a good amount of these are no longer reproducible and have been closed. Here is our current list of follow-up issues, half of which are completed with a few others in progress.
Julesssss commentedon Sep 3, 2025
Closing this issue. The feature has been merged and released without new bugs being raised. We'll now focus on TTI imrpovements and some remaining bugs.
trjExpensify commentedon Oct 3, 2025
approved $250 for @DylanDylann.