You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-10-30] [$250] [Dupe detection] Report header has "Hold" action when the expense is already in Hold status #49872
Version Number: 9.0.41-1 Reproducible in staging?: Y Reproducible in production?: N/A - new feature, doesn't exist in prod Issue was found when executing this PR:#48522 Email or phone of affected tester (no customers):applausetester+kh010901@applause.expensifail.com Issue reported by: Applause Internal Team
Action Performed:
Go to staging.new.expensify.com
[Employee] Submit two same expenses in the workspace chat.
[Admin] Go to any of the submitted expense in the workspace chat.
[Admin] Go offline.
[Admin] Click Review duplicates.
[Admin] Click Keep this one (any).
[Admin] Click Confirm on the confirmation page.
[Admin] Go to the other transaction thread that has "Hold" action in the expense preview.
[Admin] Click on the report header.
Expected Result:
Since the other expense has "Hold" action, the report header should have the "Unhold" action.
Actual Result:
The report header has "Hold" action when the expense is already in Hold status.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.52-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
[@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@eVoloshchak] Determine if we should create a regression test for this bug.
[@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon Sep 27, 2024
Triggered auto assignment to @jasperhuangg (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Sep 27, 2024
Triggered auto assignment to @stephanieelliott (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Sep 27, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
IuliiaHerets commentedon Sep 27, 2024
On prod, the other expense vanishes instantly
bandicam.2024-09-28.00-52-50-976.mp4
IuliiaHerets commentedon Sep 27, 2024
We think that this bug might be related to #wave-collect - Release 1
roryabraham commentedon Sep 29, 2024
Dupe detection is behind a beta w/ only internal users and developers, this is NAB
46 remaining items
melvin-bot commentedon Oct 23, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.52-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-10-30. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Oct 23, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
melvin-bot commentedon Oct 30, 2024
Payment Summary
Upwork Job
BugZero Checklist (@stephanieelliott)
stephanieelliott commentedon Oct 31, 2024
Summarizing payment on this issue:
Upwork job is here: https://www.upwork.com/jobs/~021851909474139768777
daledah commentedon Oct 31, 2024
@stephanieelliott accepted thx
stephanieelliott commentedon Nov 5, 2024
All paid!
melvin-bot commentedon Nov 5, 2024
@stephanieelliott @jasperhuangg Be sure to fill out the Contact List!
JmillsExpensify commentedon Nov 18, 2024
$250 approved for @eVoloshchak