You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-10-25] [$250] [Dupe detect] Not here page opens when opening distance receipt from another workspace #50107
Version Number: 9.0.43-3 Reproducible in staging?: Y Reproducible in production?: Y Email or phone of affected tester (no customers):applausetester+pso@applause.expensifail.com Issue reported by: Applause Internal Team
Action Performed:
Go to staging.new.expensify.com
Create two workspaces.
Submit a distance expense in the first workspace chat.
Submit the same distance expense in the second workspace chat.
Submit another expense to the second workspace chat (as we cannot review duplicates when there is only one expense).
Go to transaction thread of the second expense in Step 4.
Click Review duplicates.
Click on the second distance expense preview (to make Keep this one button appear).
Click browser back button.
Click Keep this one on the second expense preview.
Click on the receipt on the confirmation page.
Expected Result:
The receipt opens without issue.
Actual Result:
Not here page opens when opening distance receipt from another workspace in full screen.
@joekaufmanexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
Please re-state the problem that we are trying to solve in this issue.
Not here page opens when opening distance receipt from another workspace in full screen.
What is the root cause of that problem?
Here we are calculating shouldShowNotFoundPage based on moneyRequestReportID and transaction?.reportID and will show NotFoundPage when they are different
But in case review duplicates with expsense in another workspace, it is no longer true because this transaction does not belong to the same report so moneyRequestReportID will calculate wrong
Confirmed this is possible, but only for the submitter. Given the submitter can view the expense when resolving dupes, feels correct they should be able to view the receipt.
changed the title [-]Dupe detect - Not here page opens when opening distance receipt from another workspace[/-][+][$250] Dupe detect - Not here page opens when opening distance receipt from another workspace[/+]on Oct 4, 2024
[@rojiphil] The PR that introduced the bug has been identified. Link to the PR: Offending PR
[@rojiphil] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Added comment
[@rojiphil] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not Required. Existing checklist is good enough to capture such issues.
[@rojiphil] Determine if we should create a regression test for this bug. : Yes. We can
[@rojiphil] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Steps:
Create two workspaces.
Submit a distance expense in the first workspace chat.
Submit the same distance expense in the second workspace chat.
Submit another expense to the second workspace chat (as we cannot review duplicates when there is only one expense).
Go to transaction thread of the second expense in Step 4.
Click Review duplicates.
Click on the second distance expense preview (to make Keep this one button appear).
Activity
melvin-bot commentedon Oct 2, 2024
Triggered auto assignment to @joekaufmanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.IuliiaHerets commentedon Oct 2, 2024
We think that this bug might be related to #wave-control
IuliiaHerets commentedon Oct 2, 2024
@joekaufmanexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
nkdengineer commentedon Oct 2, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Not here page opens when opening distance receipt from another workspace in full screen.
What is the root cause of that problem?
Here we are calculating
shouldShowNotFoundPagebased onmoneyRequestReportIDandtransaction?.reportIDand will showNotFoundPagewhen they are differentApp/src/pages/TransactionReceiptPage.tsx
Line 62 in c3b4a65
But in case review duplicates with expsense in another workspace, it is no longer true because this transaction does not belong to the same report so
moneyRequestReportIDwill calculate wrongApp/src/pages/TransactionReceiptPage.tsx
Line 58 in c3b4a65
What changes do you think we should make in order to solve the problem?
isFromReviewDuplicatesfor routeTRANSACTION_RECEIPThereshouldShowNotFoundPagehereisFromReviewDuplicatesfrom Transaction Duplicate confirmation page hereApp/src/pages/TransactionDuplicate/Confirmation.tsx
Lines 107 to 112 in c3b4a65
What alternative solutions did you explore? (Optional)
joekaufmanexpensify commentedon Oct 4, 2024
I can reproduce this, but not sure if dupe detection across multiple workspaces is supposed to be a thing.
joekaufmanexpensify commentedon Oct 4, 2024
Discussing
joekaufmanexpensify commentedon Oct 4, 2024
Confirmed this is possible, but only for the submitter. Given the submitter can view the expense when resolving dupes, feels correct they should be able to view the receipt.
[-]Dupe detect - Not here page opens when opening distance receipt from another workspace[/-][+][$250] Dupe detect - Not here page opens when opening distance receipt from another workspace[/+]melvin-bot commentedon Oct 4, 2024
Job added to Upwork: https://www.upwork.com/jobs/~021842274975898423185
29 remaining items
joekaufmanexpensify commentedon Oct 21, 2024
@nkdengineer @rojiphil was the regression notice above legit?
rojiphil commentedon Oct 21, 2024
Yes @joekaufmanexpensify. That is correct.
joekaufmanexpensify commentedon Oct 22, 2024
Got it. TY for confirming!
joekaufmanexpensify commentedon Oct 22, 2024
@rojiphil can you also handle the BZ checklist so we can process payment in a few days?
rojiphil commentedon Oct 24, 2024
Steps:
rojiphil commentedon Oct 24, 2024
@joekaufmanexpensify BZ Checklist is done.
joekaufmanexpensify commentedon Oct 25, 2024
Regression test issue is here.
joekaufmanexpensify commentedon Oct 25, 2024
Checklist is complete. All set to issue payment!
joekaufmanexpensify commentedon Oct 25, 2024
We need to pay:
joekaufmanexpensify commentedon Oct 25, 2024
@nkdengineer $125 sent and contract ended!
joekaufmanexpensify commentedon Oct 25, 2024
@rojiphil $125 sent and contract ended!
joekaufmanexpensify commentedon Oct 25, 2024
Upwork job closed.
joekaufmanexpensify commentedon Oct 25, 2024
All set, thanks everyone!