You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-10-17] [HOLD for payment 2024-10-16] Chat - No space between "con" and user name in "Este chat es con<username>." #50381
Version Number: 9.0.46-1 Reproducible in staging?: Y Reproducible in production?: N/A - new feature, doesn't exist in prod Email or phone of affected tester (no customers):applausetester+pso@applause.expensifail.com Issue reported by: Applause Internal Team
Action Performed:
Precondition:
App language is Spanish.
Go to staging.new.expensify.com
Open DM.
Expected Result:
There should be a space between "con" and user name in "Este chat es con ."
Actual Result:
There is no space between "con" and user name in "Este chat es con."
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-]Chat - No space between "con" and user name in "Este chat es con<username>."[/-][+][HOLD for payment 2024-10-16] Chat - No space between "con" and user name in "Este chat es con<username>."[/+]on Oct 9, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.46-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@thienlnam] The PR that introduced the bug has been identified. Link to the PR:
[@thienlnam] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@thienlnam] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@thienlnam] Determine if we should create a regression test for this bug.
[@thienlnam] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@RachCHopkins] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
changed the title [-][HOLD for payment 2024-10-16] Chat - No space between "con" and user name in "Este chat es con<username>."[/-][+][HOLD for payment 2024-10-17] [HOLD for payment 2024-10-16] Chat - No space between "con" and user name in "Este chat es con<username>."[/+]on Oct 10, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.47-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@thienlnam] The PR that introduced the bug has been identified. Link to the PR:
[@thienlnam] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@thienlnam] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@thienlnam] Determine if we should create a regression test for this bug.
[@thienlnam] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@RachCHopkins] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon Oct 8, 2024
Triggered auto assignment to @RachCHopkins (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Oct 8, 2024
Triggered auto assignment to @techievivek (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Oct 8, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
abzokhattab commentedon Oct 8, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Chat - No space between "con" and user name in "Este chat es con
What is the root cause of that problem?
a space is missing in the Spanish translation here
App/src/languages/es.ts
Line 665 in 79dda7a
unlike the english translation
What changes do you think we should make in order to solve the problem?
we need to add a space at the end here
What alternative solutions did you explore? (Optional)
13 remaining items
[-]Chat - No space between "con" and user name in "Este chat es con<username>."[/-][+][HOLD for payment 2024-10-16] Chat - No space between "con" and user name in "Este chat es con<username>."[/+]melvin-bot commentedon Oct 9, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Oct 9, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.46-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-10-16. 🎊
melvin-bot commentedon Oct 9, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
thienlnam commentedon Oct 9, 2024
Was a regression, no payments required here
[-][HOLD for payment 2024-10-16] Chat - No space between "con" and user name in "Este chat es con<username>."[/-][+][HOLD for payment 2024-10-17] [HOLD for payment 2024-10-16] Chat - No space between "con" and user name in "Este chat es con<username>."[/+]melvin-bot commentedon Oct 10, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.47-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-10-17. 🎊
melvin-bot commentedon Oct 10, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed: