Skip to content

[HOLD for payment 2024-10-17] [HOLD for payment 2024-10-16] Chat - No space between "con" and user name in "Este chat es con<username>." #50381

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.46-1
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Email or phone of affected tester (no customers): applausetester+pso@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

  • App language is Spanish.
  1. Go to staging.new.expensify.com
  2. Open DM.

Expected Result:

There should be a space between "con" and user name in "Este chat es con ."

Actual Result:

There is no space between "con" and user name in "Este chat es con."

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6628018_1728370091374!Screenshot_2024-10-08_at_14 45 56
Bug6627983_1728364648198.2024-10-08_08_10_53.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @RachCHopkins

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerCashThis issue or pull request should block deployment
    on Oct 8, 2024
  2. melvin-bot commented on Oct 8, 2024

    @melvin-bot

    Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Oct 8, 2024

    @melvin-bot

    Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. github-actions commented on Oct 8, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. abzokhattab commented on Oct 8, 2024

    @abzokhattab
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Chat - No space between "con" and user name in "Este chat es con

    What is the root cause of that problem?

    a space is missing in the Spanish translation here

    beginningOfChatHistory: 'Este chat es con',

    unlike the english translation

    What changes do you think we should make in order to solve the problem?

    we need to add a space at the end here

    beginningOfChatHistory: 'Este chat es con ',

    What alternative solutions did you explore? (Optional)

  6. 13 remaining items

  7. changed the title [-]Chat - No space between "con" and user name in "Este chat es con<username>."[/-] [+][HOLD for payment 2024-10-16] Chat - No space between "con" and user name in "Este chat es con<username>."[/+] on Oct 9, 2024
  8. melvin-bot commented on Oct 9, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  9. melvin-bot commented on Oct 9, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.46-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-10-16. 🎊

  10. melvin-bot commented on Oct 9, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@thienlnam] The PR that introduced the bug has been identified. Link to the PR:
    • [@thienlnam] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@thienlnam] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@thienlnam] Determine if we should create a regression test for this bug.
    • [@thienlnam] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@RachCHopkins] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  11. thienlnam commented on Oct 9, 2024

    @thienlnam
    Contributor

    Was a regression, no payments required here

  12. changed the title [-][HOLD for payment 2024-10-16] Chat - No space between "con" and user name in "Este chat es con<username>."[/-] [+][HOLD for payment 2024-10-17] [HOLD for payment 2024-10-16] Chat - No space between "con" and user name in "Este chat es con<username>."[/+] on Oct 10, 2024
  13. melvin-bot commented on Oct 10, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.47-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-10-17. 🎊

  14. melvin-bot commented on Oct 10, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@thienlnam] The PR that introduced the bug has been identified. Link to the PR:
    • [@thienlnam] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@thienlnam] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@thienlnam] Determine if we should create a regression test for this bug.
    • [@thienlnam] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@RachCHopkins] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions