Skip to content

[Hold for payment 2024-10-16] Public room - "Use the + button to or split an expense." is not consistent and incomplete #50382

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.46-1
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Email or phone of affected tester (no customers): applausetester+pso@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Create a public room.
  3. Note that there is no "Use the + button to or split an expense." message.
  4. Navigate to the public room anonymously in incognito window.
  5. Note that there is "Use the + button to or split an expense." message and it is incomplete.

Expected Result:

In Step 3 and 5, the appearance of the message "Use the + button to or split an expense." should be consistent.
The message should be complete.

Actual Result:

In Step 3, the message does not appear after the room is created.
In Step 5, the message only appears after it is visited anonymously.

The message "Use the + button to or split an expense." is also not complete (Use the + button to ..)
The same incomplete message also appears in group chat.
The message does not appear after relogin for public room.

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6628034_1728371365845.20241008_150523.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 8, 2024
  2. melvin-bot commented on Oct 8, 2024

    @melvin-bot

    Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Oct 8, 2024

    @melvin-bot

    Triggered auto assignment to @grgia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. github-actions commented on Oct 8, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. thienlnam commented on Oct 8, 2024

    @thienlnam
    Contributor

    Fixed with this PR #50384

  6. thienlnam commented on Oct 9, 2024

    @thienlnam
    Contributor

    This was fixed and CPed. All that's required left here is C+ payment for review to @jayeshmangwani

  7. changed the title [-]Public room - "Use the + button to or split an expense." is not consistent and incomplete[/-] [+][Hold for payment 2024-10-16] Public room - "Use the + button to or split an expense." is not consistent and incomplete[/+] on Oct 11, 2024
  8. sonialiap commented on Oct 14, 2024

    @sonialiap
    Contributor

    not overdue, payment on Wednesday

  9. sonialiap commented on Oct 16, 2024

    @sonialiap
    Contributor

    Payment summary:

  10. garrettmknight commented on Oct 23, 2024

    @garrettmknight
    Contributor

    $250 approved for @jayeshmangwani

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions