Skip to content

[HOLD for payment 2024-10-25] [Workspace feeds polish] SmartLimit option not showing on WorkspaceEditCardLimitTypePage #50784

Closed

Description

@MariaHCD

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number:
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation: https://expensify.slack.com/archives/C036QM0SLJK/p1728928454869509?thread_ts=1727196342.211239&cid=C036QM0SLJK

Action Performed:

  1. Create a workspace on NewDot with advanced approvals configured
  2. Configure the workspace for the Expensify Card
  3. Attempt to issue a new card to a member

Expected Result:

The SmartLimit option should display

Actual Result:

The SmartLimit option was not displayed - only the Monthly and Fixed limit options were available

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

image

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @allgandalf

Activity

  1. VickyStash commented on Oct 15, 2024

    @VickyStash
    Contributor

    Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

  2. allgandalf commented on Oct 15, 2024

    @allgandalf
    Contributor

    @mountiny are you able to reproduce? i cannot

  3. mountiny commented on Oct 15, 2024

    @mountiny
    Contributor

    I think it has to be control policy with policy chats enabled

  4. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 16, 2024
  5. melvin-bot commented on Oct 16, 2024

    @melvin-bot

    Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  6. mountiny commented on Oct 16, 2024

    @mountiny
    Contributor

    @VickyStash are you able to reproduce this one? I think you might need to set up the approver on the control policy in oldDot (at the isPolicyExpenseChatEnabled to true there as well) and then try it

  7. VickyStash commented on Oct 16, 2024

    @VickyStash
    Contributor

    @mountiny Yeah, I think I'm able to reproduce it. I've updated the approval mode to Advanced approvals in the old dot and it caused the mentioned bug.
    cc @allgandalf

  8. 18 remaining items

  9. tgolen commented on Oct 23, 2024

    @tgolen
    Contributor

    Reopening this one so @allgandalf and @sonialiap can complete the regression checklist

  10. reopened this on Oct 23, 2024
  11. mountiny commented on Oct 24, 2024

    @mountiny
    Contributor

    @allgandalf lets add a regression test for the smart limit option with the approver, I dont think that was covered in the the original testing steps for workspace feeds

  12. melvin-bot commented on Oct 25, 2024

    @melvin-bot

    Payment Summary

    Upwork Job

    • Contributor: @VickyStash is from an agency-contributor and not due payment
    • ROLE: @allgandalf paid $(AMOUNT) via Upwork (LINK)

    BugZero Checklist (@sonialiap)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  13. melvin-bot commented on Oct 28, 2024

    @melvin-bot

    @sonialiap, @VickyStash, @mountiny, @allgandalf Whoops! This issue is 2 days overdue. Let's get this updated quick!

  14. sonialiap commented on Oct 29, 2024

    @sonialiap
    Contributor

    @allgandalf bumping for completion of the checklist #50784 (comment)

  15. allgandalf commented on Oct 30, 2024

    @allgandalf
    Contributor
    • The PR that introduced the bug has been identified. Link to the PR: [No QA] Create new Edit Limit Type page #45601

    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/45601/files#r1822324722

    • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A

    • If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    Regression Test Proposal

    • Create a workspace.
    • Configure the workspace for the Expensify Card.
    • Attempt to issue a new card to a member -> SmartLimit limit type shouldn't be displayed.
    • In More Features, enable Workflows. In Workflows, enable Approvals.
    • Attempt to issue a new card to a member -> SmartLimit limit type should be displayed.
    • Go to the old dot and turn on the Advanced Approval mode for the workspace.

    Verify that: when attempting to issue a new card to a member -> SmartLimit limit type should be displayed.
    Do we agree 👍 or 👎

  16. melvin-bot commented on Oct 30, 2024

    @melvin-bot

    @sonialiap @mountiny Be sure to fill out the Contact List!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions