You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-10-25] [Workspace feeds polish] SmartLimit option not showing on WorkspaceEditCardLimitTypePage #50784
@VickyStash are you able to reproduce this one? I think you might need to set up the approver on the control policy in oldDot (at the isPolicyExpenseChatEnabled to true there as well) and then try it
@mountiny Yeah, I think I'm able to reproduce it. I've updated the approval mode to Advanced approvals in the old dot and it caused the mentioned bug.
cc @allgandalf
@allgandalf lets add a regression test for the smart limit option with the approver, I dont think that was covered in the the original testing steps for workspace feeds
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Regression Test Proposal
Create a workspace.
Configure the workspace for the Expensify Card.
Attempt to issue a new card to a member -> SmartLimit limit type shouldn't be displayed.
In More Features, enable Workflows. In Workflows, enable Approvals.
Attempt to issue a new card to a member -> SmartLimit limit type should be displayed.
Go to the old dot and turn on the Advanced Approval mode for the workspace.
Verify that: when attempting to issue a new card to a member -> SmartLimit limit type should be displayed.
Do we agree 👍 or 👎
Activity
VickyStash commentedon Oct 15, 2024
Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.
allgandalf commentedon Oct 15, 2024
@mountiny are you able to reproduce? i cannot
mountiny commentedon Oct 15, 2024
I think it has to be control policy with policy chats enabled
melvin-bot commentedon Oct 16, 2024
Triggered auto assignment to @sonialiap (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.mountiny commentedon Oct 16, 2024
@VickyStash are you able to reproduce this one? I think you might need to set up the approver on the control policy in oldDot (at the isPolicyExpenseChatEnabled to true there as well) and then try it
VickyStash commentedon Oct 16, 2024
@mountiny Yeah, I think I'm able to reproduce it. I've updated the approval mode to Advanced approvals in the old dot and it caused the mentioned bug.
cc @allgandalf
18 remaining items
tgolen commentedon Oct 23, 2024
Reopening this one so @allgandalf and @sonialiap can complete the regression checklist
mountiny commentedon Oct 24, 2024
@allgandalf lets add a regression test for the smart limit option with the approver, I dont think that was covered in the the original testing steps for workspace feeds
melvin-bot commentedon Oct 25, 2024
Payment Summary
Upwork Job
BugZero Checklist (@sonialiap)
melvin-bot commentedon Oct 28, 2024
@sonialiap, @VickyStash, @mountiny, @allgandalf Whoops! This issue is 2 days overdue. Let's get this updated quick!
sonialiap commentedon Oct 29, 2024
@allgandalf bumping for completion of the checklist #50784 (comment)
allgandalf commentedon Oct 30, 2024
The PR that introduced the bug has been identified. Link to the PR: [No QA] Create new Edit Limit Type page #45601
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/45601/files#r1822324722
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Regression Test Proposal
Verify that: when attempting to issue a new card to a member -> SmartLimit limit type should be displayed.
Do we agree 👍 or 👎
melvin-bot commentedon Oct 30, 2024
@sonialiap @mountiny Be sure to fill out the Contact List!