You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-11-28] [$250] Attachment - The position of the attachment "Menu" modal is incorrect #50818
Version Number: 9.0.49-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team
Hover over the video and click on the "Fullscreen" button
Minimize the video
Hover over the image attachment and click on the "..." button
Hover over the video attachment and click on the "..." button
Expected Result:
"Menu" modal should appear close the attachment, but not overlapping any elements
Actual Result:
The position of the attachment "Menu" modal is incorrect. Sometimes it appears far away from the attachment, sometimes it overlaps the quick menu buttons and sometimes it appears on the LHN
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidenceBug6635272_1729000007658.bandicam_2024-10-15_15-38-21-833.mp4
@RachCHopkins FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
📣 @siddhakdak! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
@siddhakdak The process is for the issue to be triaged before any assignment. Right now we're still working out if it's a problem. If you can reproduce the issue, then that can help move things along towards the proposal stage. Otherwise I'm asking our testers to check anyhow.
changed the title [-][$250] Attachment - The position of the attachment "Menu" modal is incorrect[/-][+][HOLD for payment 2024-11-28] [$250] Attachment - The position of the attachment "Menu" modal is incorrect[/+]on Nov 21, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.64-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@rojiphil@RachCHopkins@rojiphil The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not Required. The existing checklist is good enough to capture such issues.
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Test:
Navigate to any 1:1 DM
Send any video attachment
Send any image attachment
Click on the video to play it
Hover over the video and click on the "Fullscreen" button
Minimize the video
Hover over the image attachment and click on the "..." button
Hover over the video attachment and click on the "..." button
Verify that the popover menu position is correct with respect to the report actions in steps 7 and 8
Activity
melvin-bot commentedon Oct 15, 2024
Triggered auto assignment to @RachCHopkins (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.lanitochka17 commentedon Oct 15, 2024
@RachCHopkins FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
siddhakdak commentedon Oct 15, 2024
@RachCHopkins can i start work on this issue.
melvin-bot commentedon Oct 15, 2024
📣 @siddhakdak! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Format:
siddhakdak commentedon Oct 15, 2024
Contributor details
Your Expensify account email: siddhakdak19@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01e9eca845d1af9067
melvin-bot commentedon Oct 15, 2024
✅ Contributor details stored successfully. Thank you for contributing to Expensify!
siddhakdak commentedon Oct 15, 2024
/assign
RachCHopkins commentedon Oct 16, 2024
I can't reproduce this - it's exactly where it should be every time for me. I'm on v9.0.49-1 so maybe it's been fixed organically.
Can we get a retest, please?
MelvinBot commentedon Oct 16, 2024
This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989
RachCHopkins commentedon Oct 16, 2024
@siddhakdak The process is for the issue to be triaged before any assignment. Right now we're still working out if it's a problem. If you can reproduce the issue, then that can help move things along towards the proposal stage. Otherwise I'm asking our testers to check anyhow.
FitseTLT commentedon Oct 16, 2024
BTW @RachCHopkins I easily reproduced it following the steps, are U interested in fixing it
2024-10-16.17-17-48.mp4
48 remaining items
[-][$250] Attachment - The position of the attachment "Menu" modal is incorrect[/-][+][HOLD for payment 2024-11-28] [$250] Attachment - The position of the attachment "Menu" modal is incorrect[/+]melvin-bot commentedon Nov 21, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Nov 21, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.64-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-11-28. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Nov 21, 2024
@rojiphil @RachCHopkins @rojiphil The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
RachCHopkins commentedon Nov 29, 2024
@rojiphil I'm just waiting on your checklist here before I issue payment.
rojiphil commentedon Nov 29, 2024
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not Required. The existing checklist is good enough to capture such issues.
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
rojiphil commentedon Nov 29, 2024
@RachCHopkins Sorry for the delay here. I have completed the BZ checklist here. Thanks.
RachCHopkins commentedon Dec 2, 2024
Payment Summary:
Upwork job here
RachCHopkins commentedon Dec 2, 2024
Contributor has been paid, the contract has been completed, and the Upwork post has been closed.