Skip to content

[HOLD for payment 2024-11-28] [$250] Attachment - The position of the attachment "Menu" modal is incorrect #50818

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.49-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Navigate to https://staging.new.expensify.com/
  2. Log in with any account
  3. Navigate to any 1:1 DM
  4. Send any video attachment
  5. Send any image attachment
  6. Click on the video to play it
  7. Hover over the video and click on the "Fullscreen" button
  8. Minimize the video
  9. Hover over the image attachment and click on the "..." button
  10. Hover over the video attachment and click on the "..." button

Expected Result:

"Menu" modal should appear close the attachment, but not overlapping any elements

Actual Result:

The position of the attachment "Menu" modal is incorrect. Sometimes it appears far away from the attachment, sometimes it overlaps the quick menu buttons and sometimes it appears on the LHN

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6635272_1729000007658.bandicam_2024-10-15_15-38-21-833.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021846647666370282624
  • Upwork Job ID: 1846647666370282624
  • Last Price Increase: 2024-10-16
  • Automatic offers:
    • rojiphil | Reviewer | 104546765
Issue OwnerCurrent Issue Owner: @RachCHopkins

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 15, 2024
  2. melvin-bot commented on Oct 15, 2024

    @melvin-bot

    Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. lanitochka17 commented on Oct 15, 2024

    @lanitochka17
    Author

    @RachCHopkins FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  4. siddhakdak commented on Oct 15, 2024

    @siddhakdak

    @RachCHopkins can i start work on this issue.

  5. melvin-bot commented on Oct 15, 2024

    @melvin-bot

    📣 @siddhakdak! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Make sure you've read and understood the contributing guidelines.
    2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
    
  6. siddhakdak commented on Oct 15, 2024

    @siddhakdak

    Contributor details
    Your Expensify account email: siddhakdak19@gmail.com
    Upwork Profile Link: https://www.upwork.com/freelancers/~01e9eca845d1af9067

  7. melvin-bot commented on Oct 15, 2024

    @melvin-bot

    ✅ Contributor details stored successfully. Thank you for contributing to Expensify!

  8. siddhakdak commented on Oct 15, 2024

    @siddhakdak

    /assign

  9. RachCHopkins commented on Oct 16, 2024

    @RachCHopkins
    Contributor

    I can't reproduce this - it's exactly where it should be every time for me. I'm on v9.0.49-1 so maybe it's been fixed organically.

    Can we get a retest, please?

  10. MelvinBot commented on Oct 16, 2024

    @MelvinBot
    Contributor

    This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

  11. RachCHopkins commented on Oct 16, 2024

    @RachCHopkins
    Contributor

    @siddhakdak The process is for the issue to be triaged before any assignment. Right now we're still working out if it's a problem. If you can reproduce the issue, then that can help move things along towards the proposal stage. Otherwise I'm asking our testers to check anyhow.

  12. FitseTLT commented on Oct 16, 2024

    @FitseTLT
    Contributor

    BTW @RachCHopkins I easily reproduced it following the steps, are U interested in fixing it

    2024-10-16.17-17-48.mp4
  13. 48 remaining items

  14. changed the title [-][$250] Attachment - The position of the attachment "Menu" modal is incorrect[/-] [+][HOLD for payment 2024-11-28] [$250] Attachment - The position of the attachment "Menu" modal is incorrect[/+] on Nov 21, 2024
  15. melvin-bot commented on Nov 21, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  16. melvin-bot commented on Nov 21, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.64-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-11-28. 🎊

    For reference, here are some details about the assignees on this issue:

  17. melvin-bot commented on Nov 21, 2024

    @melvin-bot

    @rojiphil @RachCHopkins @rojiphil The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  18. RachCHopkins commented on Nov 29, 2024

    @RachCHopkins
    Contributor

    @rojiphil I'm just waiting on your checklist here before I issue payment.

  19. rojiphil commented on Nov 29, 2024

    @rojiphil
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production
    • 2b. Reported on staging (deploy blocker)
    • 2c. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment:

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: Not Required. The existing checklist is good enough to capture such issues.

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal

    Precondition:

    Test:

    1. Navigate to any 1:1 DM
    2. Send any video attachment
    3. Send any image attachment
    4. Click on the video to play it
    5. Hover over the video and click on the "Fullscreen" button
    6. Minimize the video
    7. Hover over the image attachment and click on the "..." button
    8. Hover over the video attachment and click on the "..." button
    9. Verify that the popover menu position is correct with respect to the report actions in steps 7 and 8

    Do we agree 👍 or 👎

  20. rojiphil commented on Nov 29, 2024

    @rojiphil
    Contributor

    I'm just waiting on your checklist here before I issue payment.

    @RachCHopkins Sorry for the delay here. I have completed the BZ checklist here. Thanks.

  21. RachCHopkins commented on Dec 2, 2024

    @RachCHopkins
    Contributor

    Payment Summary:

    • Contributor: @teneeto paid via contract
    • Contributor+: @rojiphil paid $250 via Upwork

    Upwork job here

  22. RachCHopkins commented on Dec 2, 2024

    @RachCHopkins
    Contributor

    Contributor has been paid, the contract has been completed, and the Upwork post has been closed.

  23. moved this from Bugs and Follow Up Issues to Done in #expensify-bugson Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions